From: Andy Shevchenko <andy@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Paul Burton <paulburton@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] auxdisplay: img-ascii-lcd: Constify struct img_ascii_lcd_config
Date: Mon, 9 Dec 2024 18:55:39 +0200 [thread overview]
Message-ID: <Z1chC8GHeog24M33@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdVaJyW3bvTxRfcDavA9HaukUDGBaTWRoUtrwjy_rb2DpA@mail.gmail.com>
On Mon, Dec 09, 2024 at 09:55:48AM +0100, Geert Uytterhoeven wrote:
> On Fri, Dec 6, 2024 at 11:26 PM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
> > 'struct img_ascii_lcd_config' is not modified in this driver.
> >
> > Constifying this structure moves some data to a read-only section, so
> > increase overall security, especially when the structure holds some
> > function pointers.
> >
> > On a x86_64, with allmodconfig:
> > Before:
> > ======
> > text data bss dec hex filename
> > 6110 728 0 6838 1ab6 drivers/auxdisplay/img-ascii-lcd.o
> >
> > After:
> > =====
> > text data bss dec hex filename
> > 6198 632 0 6830 1aae drivers/auxdisplay/img-ascii-lcd.o
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-09 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 22:25 [PATCH 1/2] auxdisplay: img-ascii-lcd: Remove an unused field in struct img_ascii_lcd_ctx Christophe JAILLET
2024-12-06 22:25 ` [PATCH 2/2] auxdisplay: img-ascii-lcd: Constify struct img_ascii_lcd_config Christophe JAILLET
2024-12-09 8:55 ` Geert Uytterhoeven
2024-12-09 16:55 ` Andy Shevchenko [this message]
2024-12-09 8:54 ` [PATCH 1/2] auxdisplay: img-ascii-lcd: Remove an unused field in struct img_ascii_lcd_ctx Geert Uytterhoeven
2024-12-09 16:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1chC8GHeog24M33@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=geert@linux-m68k.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulburton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox