From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18C5219E971 for ; Tue, 10 Dec 2024 03:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733801510; cv=none; b=t3R1CBSlI/RwC9LibRkqUnD4vtdzL/aY4vH0Uwkjb1KvNh6BXOlqUAhgyGLRHrZq2qEoy8Ffad1nT/Pxl9SlYFSU6O7IopzdFLvJtKs1wTP7gQvvVC4mdNGOL2wGtLKeRIqIJnfnc4+Bz/MHise9wCrkK9BtseEUMB62OCjd/bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733801510; c=relaxed/simple; bh=FNzKszCuHp8YBw4zUen9q+/Su0cHKgEr5TQylNKG7Rg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VjK/4CcA17nKstnTiRDiqnAdPEF2h7lKQ4U3uc71NVpwlTqiCUvWAZP6Z8aP7ujoOp0kfez3UdfxzAgq2+VGbKkcoKqMLyjNUiZuHz9fVItB3h53JAE0DF5U6rFv63U7IwVlDqYnnECy1ydr6LBDpGy0Vt3H5vhgmmldyumuwac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Yonfa6r2; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Yonfa6r2" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2163affd184so28305ad.1 for ; Mon, 09 Dec 2024 19:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733801508; x=1734406308; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=vv0YJOP4wsTr0yQs0O9EirzGuPC4EYUuQmTwZ8ZwYDs=; b=Yonfa6r2aTAA7K2Q3rzZ31HLSWfK+rUQeeWpm5Y+rsanQPK5pVWu78frOs/uaV7M1d 0O9Sgmz/0HR5j7o0Dm+3vbiMldwpiOVHfRtF9W7NKKT2JPCKK6XJ6lgmKDuQ57mVNx0P ZL+BCVsNYZHT0Z7ruIl27v7c5wGEZiDnrTo1nGP0THLUH9sROLxgAr1ZwMXTt+TutR2g cF2o+NFblT7TutVJnLzY60BV7J+51pm3zH3B0h0kEpDXEBdyG+d6t4w+qv8Z8wcygVAX tjnLt0X/9TopjsP+gYdPGRbgyYri6+nSafDkWbsr8jUkspLwPalUsUYevUqvFdjtfFV8 AaiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733801508; x=1734406308; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vv0YJOP4wsTr0yQs0O9EirzGuPC4EYUuQmTwZ8ZwYDs=; b=X0bjSkBCT7hRroxO+BWUlhWlRnK2jq3srwlFVB856hEu5ZSm0TCm07SnG3UZRSKw3K 3Wg5xoKOvd099BelrJeO2/hbbkZqukdd2anFu5fgKxRptf9YYgWeLH2xVi5vLIKpP7Lc vnK5aCurSCyLumAtIco6Us2YllECXNxzk3kB9XlYpRm8kWbd7aFGjx3FTi1arsttxN/H uWSIcn6u34N3nZLxunmJ9L96abEK2nBjiMyoDmrQi2i296/nIv9PHvXrUkTqYGu8JEiD 6f3ZeQ5wldidRQNui+N2r4fY+ygMxJdl24Ad5dZTLXUX+KRABAG8eWO1ovRwviiungHp Leig== X-Forwarded-Encrypted: i=1; AJvYcCUIenDcXJ12cDAQfBrZpl/YSdEZIVkzkRF0b6sBIhd67NOcqXenQq65rtwHPzCeHNG4r2JaP5oWEBr0k7U=@vger.kernel.org X-Gm-Message-State: AOJu0YzyWGwzv8LYmZSW8B1Dc50huUV3SJ9xoKmfZ48fymeCPxz/yNdD eNjqyWY8PEa3Moi+siH6g3uHPwJIkojNInvCsCUi5DsDuj5geX0kqdZ/kVDZVQ== X-Gm-Gg: ASbGncspOkPg1Bw4JQaC34NQCFCUjkVkMYp3iOfr8nj7HQhumzCDs6brQ3V/usvFGRC 4EGeIQjGV39SaQuWB9c1bS8KASu5medGhX8yYtrGe+yZ1onMp/QicoMSN0q/SAtu6td4Vh153vd yTeqgd9b+AgDpepH7bVhfchVV/AqsN9xZDdhggfctZxF++xIv9qOJoJ6y8Fraoz8HThm3kLnSUt yUvXUb1Hrfl0W9BZ13v0FpztolVbYtquyFOh+fNUkxJNK9nuY5anEUA1eckfiS3wZWivlA+Mmw8 PhbqLqHp70dO6Rls X-Google-Smtp-Source: AGHT+IH+pvo4/VQN7viU5wtrvbWZV7k0OuEnVi1lVzkq1rjMfGLod9qaEdLeCxJfDRPWaSCkHHj1EQ== X-Received: by 2002:a17:903:2391:b0:215:44af:313b with SMTP id d9443c01a7336-216718a490bmr1533575ad.0.1733801506645; Mon, 09 Dec 2024 19:31:46 -0800 (PST) Received: from google.com (226.75.127.34.bc.googleusercontent.com. [34.127.75.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-215f8ef9ef1sm79715295ad.159.2024.12.09.19.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 19:31:46 -0800 (PST) Date: Tue, 10 Dec 2024 03:31:42 +0000 From: Carlos Llamas To: Li Li Cc: dualli@google.com, corbet@lwn.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, donald.hunter@gmail.com, gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com, maco@android.com, joel@joelfernandes.org, brauner@kernel.org, surenb@google.com, arnd@arndb.de, masahiroy@kernel.org, bagasdotme@gmail.com, horms@kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, hridya@google.com, smoreland@google.com, kernel-team@android.com Subject: Re: [PATCH net-next v9 1/1] binder: report txn errors via generic netlink Message-ID: References: <20241209192247.3371436-1-dualli@chromium.org> <20241209192247.3371436-2-dualli@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Dec 09, 2024 at 05:26:14PM -0800, Li Li wrote: > On Mon, Dec 9, 2024 at 4:44 PM Carlos Llamas wrote: > > > + > > > +Usage example (user space pseudo code): > > > + > > > +:: > > > + > > > + // open netlink socket > > > + int fd = socket(AF_NETLINK, SOCK_RAW, NETLINK_GENERIC); > > > + > > > + // bind netlink socket > > > + bind(fd, struct socketaddr); > > > + > > > + // get the family id of the binder genl > > > + send(fd, CTRL_CMD_GETFAMILY, CTRL_ATTR_FAMILY_NAME, > > > + BINDER_GENL_FAMILY_NAME); > > > > ok, what is happening here? this is not a regular send(). Is this > > somehow an overloaded send()? If so, I had a really hard time trying to > > figuring that out so might be best to rename this. > > > > This pseudo code means a few attributes are sent by a single send(). Ok, sorry this broke my brain trying to make sense of the arguments to send(). You imply that the nlmsghdr, genlmsghdr and so on need to be populated accordingly with these arguments.