Re: [PATCH v4 04/15] media: i2c: ds90ub960: Fix logging SP & EQ status only for UB9702

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Huomenta,

On Tue, Dec 10, 2024 at 09:38:30AM +0200, Tomi Valkeinen wrote:
> Hi,
> 
> On 09/12/2024 11:11, Sakari Ailus wrote:
> > Huomenta,
> > 
> > On Fri, Dec 06, 2024 at 10:26:40AM +0200, Tomi Valkeinen wrote:
> > > UB9702 does not have SP and EQ registers, but the driver uses them in
> > > log_status(). Fix this by separating the SP and EQ related log_status()
> > > work into a separate function (for clarity) and calling that function
> > > only for UB960.
> > > 
> > > Cc: stable@vger.kernel.org
> > > Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver")
> > > Reviewed-by: Jai Luthra <jai.luthra@ideasonboard.com>
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> > > ---
> > >   drivers/media/i2c/ds90ub960.c | 90 ++++++++++++++++++++++++-------------------
> > >   1 file changed, 50 insertions(+), 40 deletions(-)
> > > 
> > > diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> > > index 24198b803eff..94c8acf171b4 100644
> > > --- a/drivers/media/i2c/ds90ub960.c
> > > +++ b/drivers/media/i2c/ds90ub960.c
> > > @@ -2950,6 +2950,54 @@ static const struct v4l2_subdev_pad_ops ub960_pad_ops = {
> > >   	.set_fmt = ub960_set_fmt,
> > >   };
> > > +static void ub960_log_status_ub960_sp_eq(struct ub960_data *priv,
> > > +					 unsigned int nport)
> > > +{
> > > +	struct device *dev = &priv->client->dev;
> > > +	u8 eq_level;
> > > +	s8 strobe_pos;
> > > +	u8 v = 0;
> > > +
> > > +	/* Strobe */
> > > +
> > > +	ub960_read(priv, UB960_XR_AEQ_CTL1, &v);
> > 
> > How about adding __must_check to the ub960_read()?
> 
> Actually, this is just moving code around (behind an if), so I'd rather not
> add more to this patch, especially as this is a fix.
> 
> We'll add the error handling separately on top.

Works for me.

-- 
Sakari Ailus