public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@kernel.org>
To: Mikulas Patocka <mpatocka@redhat.com>, zkabelac@redhat.com
Cc: Mohammed Anees <pvmohammedanees2003@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: dm: Allow the use of escaped characters in str_field_delimit()
Date: Tue, 10 Dec 2024 11:25:32 -0500	[thread overview]
Message-ID: <Z1hrfMRedzEJb26O@kernel.org> (raw)
In-Reply-To: <d62bac7e-432e-23bc-3d4c-d860e164dcaf@redhat.com>

On Mon, Nov 18, 2024 at 11:38:05AM +0100, Mikulas Patocka wrote:
> 
> 
> On Tue, 12 Nov 2024, Mohammed Anees wrote:
> 
> > Escape characters were not handled before, which could lead to
> > unwanted issues. Some device-mapper names may contain backslashes (`\`)
> > as valid characters and should not be treated as escape characters. Only
> > escape characters followed directly by the separator are considered
> > valid and need to be processed. After handling, the escape characters
> > are removed to ensure the final string is correctly parsed without
> > unwanted escape sequences which were used only for escaping.
> > 
> > Signed-off-by: Mohammed Anees <pvmohammedanees2003@gmail.com>
> 
> Hi
> 
> Does anyone really need this? Is there some use case for using escape 
> characters in device mapper names?

It would seem Mohammed cared enough to write the patch, but not reply
to you with further clarification on why it needed...

BUT, in this instance it follows that: if lvm2 is allowing weird names
which require escacped characters _and_ dm-init is used then dm-init
needs to support handling them (dm-init is all about _not_ using
normal initramfs with lvm2 in all its glory).

Mike

  reply	other threads:[~2024-12-10 16:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 17:57 [PATCH] dm: Allow the use of escaped characters in str_field_delimit() Mohammed Anees
2024-11-13 10:39 ` Zdenek Kabelac
2024-11-18 10:38 ` Mikulas Patocka
2024-12-10 16:25   ` Mike Snitzer [this message]
2024-12-15 10:13     ` Mohammed Anees
2025-01-03 16:21       ` Mikulas Patocka
2025-01-06 21:27         ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1hrfMRedzEJb26O@kernel.org \
    --to=snitzer@kernel.org \
    --cc=agk@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=pvmohammedanees2003@gmail.com \
    --cc=zkabelac@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox