From: Joe Damato <jdamato@fastly.com>
To: Frederik Deweerdt <deweerdt.lkml@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Michal Luczaj <mhal@rbox.co>, David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, xiyou.wangcong@gmail.com,
David.Laight@aculab.com, stable@vger.kernel.org
Subject: Re: [PATCH v2 net] splice: do not checksum AF_UNIX sockets
Date: Tue, 10 Dec 2024 08:28:45 -0800 [thread overview]
Message-ID: <Z1hsPdG3ITuDlWnT@LQ3V64L9R2> (raw)
In-Reply-To: <Z1fMaHkRf8cfubuE@xiberoa>
On Mon, Dec 09, 2024 at 09:06:48PM -0800, Frederik Deweerdt wrote:
> When `skb_splice_from_iter` was introduced, it inadvertently added
> checksumming for AF_UNIX sockets. This resulted in significant
> slowdowns, for example when using sendfile over unix sockets.
>
> Using the test code in [1] in my test setup (2G single core qemu),
> the client receives a 1000M file in:
> - without the patch: 1482ms (+/- 36ms)
> - with the patch: 652.5ms (+/- 22.9ms)
>
> This commit addresses the issue by marking checksumming as unnecessary in
> `unix_stream_sendmsg`
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Frederik Deweerdt <deweerdt.lkml@gmail.com>
> Fixes: 2e910b95329c ("net: Add a function to splice pages into an skbuff for MSG_SPLICE_PAGES")
> ---
> net/unix/af_unix.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2024-12-10 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 5:06 [PATCH v2 net] splice: do not checksum AF_UNIX sockets Frederik Deweerdt
2024-12-10 8:17 ` Kuniyuki Iwashima
2024-12-10 16:10 ` Frederik Deweerdt
2024-12-10 16:12 ` Eric Dumazet
2024-12-10 16:28 ` Joe Damato [this message]
2024-12-12 4:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1hsPdG3ITuDlWnT@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=deweerdt.lkml@gmail.com \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox