From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Ricardo Ribalda <ribalda@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev
Subject: Re: [PATCH v3 7/7] media: ipu-bridge: Remove unneeded conditional compilations
Date: Wed, 11 Dec 2024 08:32:08 +0000 [thread overview]
Message-ID: <Z1lOCGJvgFcqmR3R@kekkonen.localdomain> (raw)
In-Reply-To: <20241211091954.42a5c778@foz.lan>
Hi Mauro,
On Wed, Dec 11, 2024 at 09:19:54AM +0100, Mauro Carvalho Chehab wrote:
> > @@ -768,15 +755,10 @@ static int ipu_bridge_ivsc_is_ready(void)
> > unsigned int i;
> >
> > for (i = 0; i < ARRAY_SIZE(ipu_supported_sensors); i++) {
> > -#if IS_ENABLED(CONFIG_ACPI)
> > const struct ipu_sensor_config *cfg =
> > &ipu_supported_sensors[i];
> >
> > for_each_acpi_dev_match(sensor_adev, cfg->hid, NULL, -1) {
> > -#else
> > - while (false) {
> > - sensor_adev = NULL;
> > -#endif
> > if (!ACPI_PTR(sensor_adev->status.enabled))
> > continue;
> >
> >
>
> Considering that you drop patch 1, and keep the ACPI dependencies
> at the header, as proposed by patches 2-6:
>
> Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kerenel.org>
The 1st patch fixes a compilation warning when CONFIG_ACPI is disabled.
Merging that patch as a temporary solution is simply easier than making
arragements for merging the ACPI patches to the Media tree so the last
patch may be merged, too.
Besides, the fix should also be backported.
Ricardo: how about adding Cc: stable for that one?
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2024-12-11 8:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 19:55 [PATCH v3 0/7] ipu6: get rid of all the IS_ENABLED(CONFIG_ACPI) Ricardo Ribalda
2024-12-10 19:55 ` [PATCH v3 1/7] media: ipu-bridge: Fix warning when !ACPI Ricardo Ribalda
2024-12-10 21:03 ` Sakari Ailus
2024-12-10 21:27 ` Ricardo Ribalda
2024-12-11 8:31 ` Mauro Carvalho Chehab
2024-12-11 8:27 ` Mauro Carvalho Chehab
2024-12-11 8:14 ` Mauro Carvalho Chehab
2024-12-11 8:19 ` Ricardo Ribalda
2024-12-10 19:55 ` [PATCH v3 2/7] ACPI: bus: implement for_each_acpi_dev_match " Ricardo Ribalda
2024-12-10 21:02 ` Sakari Ailus
2024-12-10 19:56 ` [PATCH v3 3/7] ACPI: bus: implement acpi_get_physical_device_location " Ricardo Ribalda
2024-12-10 20:53 ` Sakari Ailus
2024-12-10 20:54 ` Ricardo Ribalda
2024-12-11 8:16 ` Mauro Carvalho Chehab
2024-12-10 19:56 ` [PATCH v3 4/7] ACPI: header: implement acpi_device_handle " Ricardo Ribalda
2024-12-10 20:56 ` Sakari Ailus
2024-12-10 22:31 ` Ricardo Ribalda
2024-12-11 7:58 ` Sakari Ailus
2024-12-11 11:33 ` Rafael J. Wysocki
2024-12-10 19:56 ` [PATCH v3 5/7] ACPI: bus: implement for_each_acpi_consumer_dev " Ricardo Ribalda
2024-12-10 20:57 ` Sakari Ailus
2024-12-10 19:56 ` [PATCH v3 6/7] ACPI: bus: implement acpi_device_hid " Ricardo Ribalda
2024-12-10 21:01 ` Sakari Ailus
2024-12-10 22:35 ` Ricardo Ribalda
2024-12-11 7:57 ` Sakari Ailus
2024-12-11 8:40 ` Mauro Carvalho Chehab
2024-12-11 8:48 ` Sakari Ailus
2024-12-11 8:57 ` Mauro Carvalho Chehab
2024-12-10 19:56 ` [PATCH v3 7/7] media: ipu-bridge: Remove unneeded conditional compilations Ricardo Ribalda
2024-12-11 8:19 ` Mauro Carvalho Chehab
2024-12-11 8:25 ` Ricardo Ribalda
2024-12-11 8:50 ` Mauro Carvalho Chehab
2024-12-11 8:32 ` Sakari Ailus [this message]
2024-12-11 8:37 ` Ricardo Ribalda
2024-12-11 8:48 ` Mauro Carvalho Chehab
2024-12-11 9:14 ` Dan Carpenter
2024-12-11 8:22 ` [PATCH v3 0/7] ipu6: get rid of all the IS_ENABLED(CONFIG_ACPI) Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1lOCGJvgFcqmR3R@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=acpica-devel@lists.linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=ribalda@chromium.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox