From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2B7223FD1E for ; Wed, 11 Dec 2024 12:58:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733921926; cv=none; b=duvEEAg0oV4weVBfwwWpx3Eb6r5IFQAiUiA1w6iW/TEYeSp/i+hdGXDVqN7OotsV0EOdOtPLZPFlImdzRuY8sCWTDQ7WO16M+BBHB894wzvl1RARDOJ6hMs8P5/JUUoPSaJK1MhSe6/k/P+C/2TsIgiq5dsHTnA66/wt0z0ekro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733921926; c=relaxed/simple; bh=KEAn6OuOqUG3OsVVxWOZfTx8NtgFmhCRRDwlZmd0Oh8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Piwl5gDfJ42u4dbfdAfOtUkHYjsHlu+qEaZGHICVW26FhYKg/fzw5qG2+l+xsmyjCfT7dowohB41z1+zuBOlDdPurOMreILmkHnQJHVAi4HQenhnm9Ri71+R8eJJVG6QQmW0lm1/h7edZwvI6HI1Ft/DbTVquHL1gdqrn5yFx0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Qv/UOSCA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qv/UOSCA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733921923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+DEcDh+LdwGMntwkxIbCzkLoVBb89ABtlpvYyrYztn0=; b=Qv/UOSCA3FtkI8EuOuZIaDs7ZbObfoCHX3O/cZt85NLQonM1PxlGDRJGzagHATcDLOZLoA zses/32dFCShGT7D0trosgfjzDL1HzDbr6ewUbCoHCzg32a8bWS0aQxTP+HrEws2f76Nki PuKeq6BHzGpYnUr+rVfr4BipS3zfXZ8= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-_hM7nGCVOMm_QIe9A0sMKw-1; Wed, 11 Dec 2024 07:58:42 -0500 X-MC-Unique: _hM7nGCVOMm_QIe9A0sMKw-1 X-Mimecast-MFC-AGG-ID: _hM7nGCVOMm_QIe9A0sMKw Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 905441956089; Wed, 11 Dec 2024 12:58:40 +0000 (UTC) Received: from localhost (unknown [10.72.112.3]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 29C59300018D; Wed, 11 Dec 2024 12:58:32 +0000 (UTC) Date: Wed, 11 Dec 2024 20:58:27 +0800 From: Baoquan He To: Coiby Xu Cc: kexec@lists.infradead.org, Ondrej Kozina , Milan Broz , Thomas Staudt , Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , Kairui Song , Jan Pazdziora , Pingfan Liu , Dave Young , linux-kernel@vger.kernel.org, x86@kernel.org, Dave Hansen , Vitaly Kuznetsov , Greg KH , Vivek Goyal , Eric Biederman , Kees Cook , "Gustavo A. R. Silva" , "open list:KERNEL HARDENING (not covered by other areas):Keyword:b__counted_byb" Subject: Re: [PATCH v6 3/7] crash_dump: store dm crypt keys in kdump reserved memory Message-ID: References: <20241029055223.210039-1-coxu@redhat.com> <20241029055223.210039-4-coxu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241029055223.210039-4-coxu@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 10/29/24 at 01:52pm, Coiby Xu wrote: ...... > +int crash_load_dm_crypt_keys(struct kimage *image) > +{ > + struct kexec_buf kbuf = { > + .image = image, > + .buf_min = 0, > + .buf_max = ULONG_MAX, > + .top_down = false, > + .random = true, > + }; > + int r; > + > + > + if (key_count <= 0) { > + kexec_dprintk("No dm-crypt keys\n"); > + return -EINVAL; > + } > + > + image->dm_crypt_keys_addr = 0; > + r = build_keys_header(); > + if (r) > + return r; > + > + kbuf.buffer = keys_header; > + kbuf.bufsz = get_keys_header_size(key_count); > + > + kbuf.memsz = kbuf.bufsz; > + kbuf.buf_align = ELF_CORE_HEADER_ALIGN; > + kbuf.mem = KEXEC_BUF_MEM_UNKNOWN; > + r = kexec_add_buffer(&kbuf); > + if (r) { > + kvfree((void *)kbuf.buffer); > + return r; > + } > + image->dm_crypt_keys_addr = kbuf.mem; > + image->dm_crypt_keys_sz = kbuf.bufsz; Wondering why not assigning kbuf.memsz, but bufsz. > + kexec_dprintk( > + "Loaded dm crypt keys to kexec_buffer bufsz=0x%lx memsz=0x%lx\n", > + kbuf.bufsz, kbuf.bufsz); > + > + return r; > +} > + > + > static int __init configfs_dmcrypt_keys_init(void) > { > int ret; > -- > 2.47.0 >