The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"hanqi@vivo.com" <hanqi@vivo.com>
Subject: Re: Unicode conversion issue
Date: Wed, 11 Dec 2024 17:08:08 +0000	[thread overview]
Message-ID: <Z1nG-PSEe6tPOZIG@google.com> (raw)
In-Reply-To: <87v7vqyzh4.fsf@mailhost.krisman.be>

On 12/11, Gabriel Krisman Bertazi wrote:
> Jaegeuk Kim <jaegeuk@kernel.org> writes:
> 
> > Hi Linus/Gabriel,
> >
> > Once Android applied the below patch [1], some special characters started to be
> > converted differently resulting in different length, so that f2fs cannot find
> > the filename correctly which was created when the kernel didn't have [1].
> >
> > There is one bug report in [2] where describes more details. In order to avoid
> > this, could you please consider reverting [1] asap? Or, is there any other
> > way to keep the conversion while addressing CVE? It's very hard for f2fs to
> > distinguish two valid converted lengths before/after [1].
> 
> I got this report yesterday. I'm looking into it.
> 
> It seems commit 5c26d2f1d3f5 ("unicode: Don't special case ignorable
> code points") has affected more than ignorable code points, because that
> U+2764 is not marked as Ignorable in the unicode database.
> 
> I still think the solution to the original issue is eliminating
> ignorable code points, and that should be fine.  Let me look at why this
> block of characters is mishandled.

Thank you so much. If it takes some time to find the root cause, may I
propose the revert first to unblock production? The problem is quite severe
as users cannot access their files.

> 
> >
> > [1] 5c26d2f1d3f5 ("unicode: Don't special case ignorable code points")
> > [2] https://bugzilla.kernel.org/show_bug.cgi?id=219586
> 
> -- 
> Gabriel Krisman Bertazi

  reply	other threads:[~2024-12-11 17:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 15:46 Unicode conversion issue Jaegeuk Kim
2024-12-11 16:08 ` Gabriel Krisman Bertazi
2024-12-11 17:08   ` Jaegeuk Kim [this message]
2024-12-11 19:45     ` Gabriel Krisman Bertazi
2024-12-11 19:58       ` Linus Torvalds
2024-12-11 20:18         ` Linus Torvalds
2024-12-11 21:10           ` Gabriel Krisman Bertazi
2024-12-11 21:25             ` Linus Torvalds
2024-12-11 21:53               ` Jaegeuk Kim
2024-12-11 21:56                 ` Linus Torvalds
2024-12-11 22:01                   ` Jaegeuk Kim
2024-12-11 22:09                     ` Linus Torvalds
2024-12-11 21:13           ` Jaegeuk Kim
2024-12-11 19:22   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1nG-PSEe6tPOZIG@google.com \
    --to=jaegeuk@kernel.org \
    --cc=hanqi@vivo.com \
    --cc=krisman@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox