Re: [PATCH v3 0/4] Migrate PCI Endpoint Subsystem tests to Kselftest

[Niklas Cassel <cassel@kernel.org>]

Hello Mani,

On Wed, Dec 11, 2024 at 01:31:01PM +0530, Manivannan Sadhasivam wrote:
> Hi,
> 
> This series carries forward the effort to add Kselftest for PCI Endpoint
> Subsystem started by Aman Gupta [1] a while ago. I reworked the initial version
> based on another patch that fixes the return values of IOCTLs in
> pci_endpoint_test driver and did many cleanups. Since the resulting work
> modified the initial version substantially, I took over the authorship.
> 
> This series also incorporates the review comment by Shuah Khan [2] to move the
> existing tests from 'tools/pci' to 'tools/testing/kselftest/pci_endpoint' before
> migrating to Kselftest framework. I made sure that the tests are executable in
> each commit and updated documentation accordingly.
> 
> NOTE: Patch 1 is strictly not related to this series, but necessary to execute
> Kselftests with Qualcomm Endpoint devices. So this can be merged separately.

Having to write a big NOTE is usually a hint that you should just have done
things differently :)

If you need to respin this series, I strongly suggest that you send the
Qcom fix separately. It is totally independent, and should be merged ASAP.

As you know, this series conflicts with:
https://lore.kernel.org/linux-pci/20241116032045.2574168-2-cassel@kernel.org/

I don't see any reason why the above patch has not been merged yet,
but it would be really nice if the above could be picked up first,
so this series could also add a kselftest testcase for the above.


Kind regards,
Niklas