From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Chun-Tse Shao <ctshao@google.com>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, nick.forrington@arm.com,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v5 2/3] perf lock: Add percpu-rwsem for type filter
Date: Thu, 12 Dec 2024 12:58:50 -0800 [thread overview]
Message-ID: <Z1tOileaITRq7nwc@google.com> (raw)
In-Reply-To: <Z1sy2NgchmkOOVt_@x1>
On Thu, Dec 12, 2024 at 04:00:40PM -0300, Arnaldo Carvalho de Melo wrote:
> On Wed, Dec 11, 2024 at 11:15:34AM -0800, Namhyung Kim wrote:
> > On Tue, Dec 10, 2024 at 12:08:21PM -0800, Chun-Tse Shao wrote:
> > > percpu-rwsem was missing in man page. And for backward compatibility,
> > > replace `pcpu-sem` with `percpu-rwsem` before parsing lock name.
> > > Tested `./perf lock con -ab -Y pcpu-sem` and `./perf lock con -ab -Y
> > > percpu-rwsem`
>
> > > Fixes: 4f701063bfa2 ("perf lock contention: Show lock type with address")
> > > Signed-off-by: Chun-Tse Shao <ctshao@google.com>
>
> > Reviewed-by: Namhyung Kim <namhyung@kernel.org>
>
> Here the reviewer can also add info about where this should go, i.e.
> this is a fix, has a Fixes tag, but then there is extra work for
> maintainers to do: Is this a regression introduced in this merge window?
> Should this go to urgent or next? If the submitter adds this, it helps,
> if the reviewer agrees, even better, otherwise emit an opinion where it
> should go.
>
> In this specific case:
>
> ⬢ [acme@toolbox perf-tools-next]$ git tag --contains 4f701063bfa2 | grep ^v[56] | grep -v -- -rc
> v6.10
> v6.11
> v6.12
> v6.4
> v6.5
> v6.6
> v6.7
> v6.8
> v6.9
> ⬢ [acme@toolbox perf-tools-next]$
>
> Looks something its there for quite a while, so probably can go to
> perf-tools-next?
Yeah, I think it should be ok to go to perf-tools-next.
Thanks,
Namhyung
next prev parent reply other threads:[~2024-12-12 20:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 20:08 [PATCH v5 1/3] perf lock: Fix parse_lock_type which only retrieve one lock flag Chun-Tse Shao
2024-12-10 20:08 ` [PATCH v5 2/3] perf lock: Add percpu-rwsem for type filter Chun-Tse Shao
2024-12-11 19:15 ` Namhyung Kim
2024-12-12 19:00 ` Arnaldo Carvalho de Melo
2024-12-12 20:58 ` Namhyung Kim [this message]
2024-12-10 20:08 ` [PATCH v5 3/3] perf lock: Rename fields in lock_type_table Chun-Tse Shao
2024-12-11 19:16 ` Namhyung Kim
2025-01-16 19:08 ` Namhyung Kim
2024-12-11 19:15 ` [PATCH v5 1/3] perf lock: Fix parse_lock_type which only retrieve one lock flag Namhyung Kim
2025-01-16 23:41 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1tOileaITRq7nwc@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ctshao@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=nick.forrington@arm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox