From: Dave Penkler <dpenkler@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, dan.carpenter@linaro.org,
geert@linux-m68k.org, arnd@kernel.org
Subject: Re: [PATCH v6] staging: gpib: Fix i386 build issue
Date: Fri, 13 Dec 2024 11:53:23 +0100 [thread overview]
Message-ID: <Z1wSIzBOZu4gUJhv@egonzo> (raw)
In-Reply-To: <670d63a3-6b20-41a3-a4db-96b407b80202@roeck-us.net>
On Wed, Dec 11, 2024 at 11:42:36AM -0800, Guenter Roeck wrote:
> On 12/11/24 08:44, Dave Penkler wrote:
> > These drivers cast resource_type_t to void * causing the build to fail.
> >
> > With a 32 bit build and PHYS_ADDR_T_64BIT enabled the resource_size_t
> > type is a 64bit unsigned int which cannot be cast to a 32 bit pointer.
> >
> > Disable these drivers if not 64BIT and PHYS_ADDR_T_64BIT are configured.
> >
> > Link: https://lore.kernel.org/linux-staging/2c6c7e9d-ca10-47a9-82a7-a2e26b1f51ef@roeck-us.net/
> > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > Closes: https://lore.kernel.org/all/f10e976e-7a04-4454-b38d-39cd18f142da@roeck-us.net/
> > Fixes: e9dc69956d4d ("staging: gpib: Add Computer Boards GPIB driver")
> > Fixes: e1339245eba3 ("staging: gpib: Add Computer Equipment Corporation GPIB driver")
> > Fixes: bb1bd92fa0f2 ("staging: gpib: Add ines GPIB driver")
> > Fixes: 0cd5b05551e0 ("staging: gpib: Add TNT4882 chip based GPIB driver")
> > Signed-off-by: Dave Penkler <dpenkler@gmail.com>
>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
>
> Guenter
>
Hi Guenter,
These nice patches from Arnd fix the i386 build issue without having applied
my v6 patch:
Link: https://lore.kernel.org/linux-staging/20241213064959.1045243-1-arnd@kernel.org/
I tested only
make ARCH=i386 allmodconfig
make ARCH=i386 M=drivers/staging/gpib
-Dave
next prev parent reply other threads:[~2024-12-13 10:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 16:44 [PATCH v6] staging: gpib: Fix i386 build issue Dave Penkler
2024-12-11 19:42 ` Guenter Roeck
2024-12-13 10:53 ` Dave Penkler [this message]
2024-12-13 18:09 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1wSIzBOZu4gUJhv@egonzo \
--to=dpenkler@gmail.com \
--cc=arnd@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox