From: Tejun Heo <tj@kernel.org>
To: Chen Ridong <chenridong@huaweicloud.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, mkoutny@suse.com, roman.gushchin@linux.dev,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
chenridong@huawei.com, wangweiyang2@huawei.com
Subject: Re: [PATCH v2] freezer, sched: report the frozen task stat as 'D'
Date: Fri, 13 Dec 2024 06:43:02 -1000 [thread overview]
Message-ID: <Z1xkFq9WIeF-MvHr@slm.duckdns.org> (raw)
In-Reply-To: <20241213110332.3105932-1-chenridong@huaweicloud.com>
On Fri, Dec 13, 2024 at 11:03:32AM +0000, Chen Ridong wrote:
...
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index d380bffee2ef..dbe0cb97461f 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1630,8 +1630,9 @@ static inline unsigned int __task_state_index(unsigned int tsk_state,
> * We're lying here, but rather than expose a completely new task state
> * to userspace, we can make this appear as if the task has gone through
> * a regular rt_mutex_lock() call.
> + * Report the frozen task uninterruptible.
> */
> - if (tsk_state & TASK_RTLOCK_WAIT)
> + if (tsk_state & TASK_RTLOCK_WAIT || tsk_state & TASK_FROZEN)
Can you please add ()'s so that it's if ((a & b) || (c & d))? Other than
that,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2024-12-13 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 11:03 [PATCH v2] freezer, sched: report the frozen task stat as 'D' Chen Ridong
2024-12-13 16:43 ` Tejun Heo [this message]
2024-12-16 10:45 ` Chen Ridong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1xkFq9WIeF-MvHr@slm.duckdns.org \
--to=tj@kernel.org \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=chenridong@huaweicloud.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wangweiyang2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox