* [RFC net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops
@ 2024-12-26 14:09 linux
2024-12-26 14:13 ` Dr. David Alan Gilbert
2025-01-06 13:11 ` Simon Horman
0 siblings, 2 replies; 3+ messages in thread
From: linux @ 2024-12-26 14:09 UTC (permalink / raw)
To: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, davem,
edumazet, kuba, pabeni, intel-wired-lan, netdev
Cc: linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
The const struct ixgbevf_hv_mbx_ops was added in 2016 as part of
commit c6d45171d706 ("ixgbevf: Support Windows hosts (Hyper-V)")
but has remained unused.
The functions it references are still referenced elsewhere.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 1 -
drivers/net/ethernet/intel/ixgbevf/mbx.c | 12 ------------
2 files changed, 13 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
index 130cb868774c..a43cb500274e 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
@@ -439,7 +439,6 @@ extern const struct ixgbevf_info ixgbevf_82599_vf_hv_info;
extern const struct ixgbevf_info ixgbevf_X540_vf_hv_info;
extern const struct ixgbevf_info ixgbevf_X550_vf_hv_info;
extern const struct ixgbevf_info ixgbevf_X550EM_x_vf_hv_info;
-extern const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops;
/* needed by ethtool.c */
extern const char ixgbevf_driver_name[];
diff --git a/drivers/net/ethernet/intel/ixgbevf/mbx.c b/drivers/net/ethernet/intel/ixgbevf/mbx.c
index a55dd978f7ca..24d0237e7a99 100644
--- a/drivers/net/ethernet/intel/ixgbevf/mbx.c
+++ b/drivers/net/ethernet/intel/ixgbevf/mbx.c
@@ -505,15 +505,3 @@ const struct ixgbe_mbx_operations ixgbevf_mbx_ops_legacy = {
.check_for_ack = ixgbevf_check_for_ack_vf,
.check_for_rst = ixgbevf_check_for_rst_vf,
};
-
-/* Mailbox operations when running on Hyper-V.
- * On Hyper-V, PF/VF communication is not through the
- * hardware mailbox; this communication is through
- * a software mediated path.
- * Most mail box operations are noop while running on
- * Hyper-V.
- */
-const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops = {
- .init_params = ixgbevf_init_mbx_params_vf,
- .check_for_rst = ixgbevf_check_for_rst_vf,
-};
--
2.47.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops
2024-12-26 14:09 [RFC net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops linux
@ 2024-12-26 14:13 ` Dr. David Alan Gilbert
2025-01-06 13:11 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2024-12-26 14:13 UTC (permalink / raw)
To: kys, anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, davem,
edumazet, kuba, pabeni, intel-wired-lan, netdev
Cc: linux-kernel
Oops, forgot to cc in kys@microsoft.com:
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The const struct ixgbevf_hv_mbx_ops was added in 2016 as part of
> commit c6d45171d706 ("ixgbevf: Support Windows hosts (Hyper-V)")
>
> but has remained unused.
>
> The functions it references are still referenced elsewhere.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 1 -
> drivers/net/ethernet/intel/ixgbevf/mbx.c | 12 ------------
> 2 files changed, 13 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> index 130cb868774c..a43cb500274e 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> @@ -439,7 +439,6 @@ extern const struct ixgbevf_info ixgbevf_82599_vf_hv_info;
> extern const struct ixgbevf_info ixgbevf_X540_vf_hv_info;
> extern const struct ixgbevf_info ixgbevf_X550_vf_hv_info;
> extern const struct ixgbevf_info ixgbevf_X550EM_x_vf_hv_info;
> -extern const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops;
>
> /* needed by ethtool.c */
> extern const char ixgbevf_driver_name[];
> diff --git a/drivers/net/ethernet/intel/ixgbevf/mbx.c b/drivers/net/ethernet/intel/ixgbevf/mbx.c
> index a55dd978f7ca..24d0237e7a99 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/mbx.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/mbx.c
> @@ -505,15 +505,3 @@ const struct ixgbe_mbx_operations ixgbevf_mbx_ops_legacy = {
> .check_for_ack = ixgbevf_check_for_ack_vf,
> .check_for_rst = ixgbevf_check_for_rst_vf,
> };
> -
> -/* Mailbox operations when running on Hyper-V.
> - * On Hyper-V, PF/VF communication is not through the
> - * hardware mailbox; this communication is through
> - * a software mediated path.
> - * Most mail box operations are noop while running on
> - * Hyper-V.
> - */
> -const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops = {
> - .init_params = ixgbevf_init_mbx_params_vf,
> - .check_for_rst = ixgbevf_check_for_rst_vf,
> -};
> --
> 2.47.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFC net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops
2024-12-26 14:09 [RFC net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops linux
2024-12-26 14:13 ` Dr. David Alan Gilbert
@ 2025-01-06 13:11 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-01-06 13:11 UTC (permalink / raw)
To: linux
Cc: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, davem,
edumazet, kuba, pabeni, intel-wired-lan, netdev, linux-kernel
On Thu, Dec 26, 2024 at 02:09:23PM +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The const struct ixgbevf_hv_mbx_ops was added in 2016 as part of
> commit c6d45171d706 ("ixgbevf: Support Windows hosts (Hyper-V)")
>
> but has remained unused.
>
> The functions it references are still referenced elsewhere.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-06 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-26 14:09 [RFC net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops linux
2024-12-26 14:13 ` Dr. David Alan Gilbert
2025-01-06 13:11 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).