From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07B0F1ACE12 for ; Fri, 27 Dec 2024 15:57:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735315024; cv=none; b=DQ/WQCM4w9MdxVjCC592WKPHvdekjYXjYO418Z8a6qJIRlM3xn7aRXDb4f+p5+cuQ6qDAxyHRRg8VZgom2LuFKV2lHpTEfzmtVwl9W7m2ApwgK8ImXyEE04f7lF2mdcGeUAAq70kBm8HrgmNi1SdgMNNpluhTqUN+cP2UI2G1+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735315024; c=relaxed/simple; bh=b6d01YadW3nv0mjac4RO0sw8ylaBlTR49DusUYWUFP8=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uA2a+ArLKPUWn1rtF01qVzrzgtKDkVOC99Seg9oYHrm+6N7y57JDHtkcRXRHRg+oxALKyOjlKwMLs4+aBrsJSaGhRjGQmoRw+Sbh6a4EaS44cJ/xbZKFLy6x7D5CiynK7uooko8UQtL1FhOfmQWx8GNs1HXiCXdA/JOd1ng9EMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=p1bpqIBc; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="p1bpqIBc" Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6dd15d03eacso66905256d6.0 for ; Fri, 27 Dec 2024 07:57:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735315022; x=1735919822; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=BohRVSSvN0r8ok43rMrQlmWcz2gz4cQtz0ZWkUDg+/k=; b=p1bpqIBciDWKFFdpYiSl9BjigGHvfBNntUB4Cu9QQaxQo+Jipv2TIT4HaCKudczim7 3miswYA2X2TFtr3eqfXL/cPJKFWJjD5fzWaHrWLaPzZnnelwDsROpMeOeHmXveA1AhLG xQvA0xHDYDhU10cYzvOcMI3b6h3nTLJRhC5uA5AafGaQNm+BNbTJdNkqd1Hy/1YBc+rM FMs0IILxD0JQsIXOEtIgdhwRkxA8YPFQr/PYmx1ENrqsS+2/n0ikikCBB6k217lPUPK8 yhCB+jKdnrgHlRrdF2QsYFAhqD/zxVWzETGlCzSOJpyp8GGQi3oqQQZNCGSx4SiqoogG d1+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735315022; x=1735919822; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BohRVSSvN0r8ok43rMrQlmWcz2gz4cQtz0ZWkUDg+/k=; b=GrOmRbpraRHsDsH8oGrqpJ6fv/3uyLk3+MBSLjvkBCBFhDEAQyQpFF9QLVQWdOkC7X 2yCnDN4HBZFMlMJReCSfBWpCNuUbCjyfVMomtDsqXdEG5bt+IFXW6Ozz1ESdtpasfv6E rfTqLMgmyeDRbp73g6pziPv0nfdekVlXx4aYrX97F/0ejHZi7vwlNu6v+P+Yels6xtgS gU/CRy8+jbov+yrO2ydoLYbqbVZYRIRP1N0YqRXAIloQ5qoUFkJrfdYHtgh770p7fkyP MY3hT6f+0bF8OLaDtmnBCDs4nJpv98GtGletN4YGSRy0DyVDu7Sd5dhneo8koc6qPgf/ GSJQ== X-Forwarded-Encrypted: i=1; AJvYcCUJbTgB/rEvTs2Jt51ZrDEyCVkzPu3ep745ts7A4//ijk+CfiQMhv53ACcZbqLokUh2kf/RQ2qxghTEowE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+Wa+y2nNWV6DRgRbee5hgdtzTXJFSgKmidIfXHPXNP3Wbx9lx LrAknHvsxanDjXXoD7EvstF+fyrXLP64eZLqdjwnL4FszksJGlP6mEQBduoO1xM= X-Gm-Gg: ASbGncstmiVw5kXloGupHS4SLxGCUfXjfzUT7CYztZAv2fXJlzGwkYLU+cv2SXJjmCL ymK1vdKEvCHg9Bg+Kva3G07MfgTjy1hde6edIrYJ10Q9jPfG78ypf3jI54QMlITspWJpk5bjHPV RmRWtst1qxQwnbLMu4DWFqhSgc5LLpvpZOD17QsPo8ZEOWjyw/4hk43PO2nhIUkf5TdppWDbQuR UL3yy9sGZCg/KCkU2QXQI7B4Uss2+SVZxpuygGHHgOV/MyKKrg7gAEtKy9qYN6JMk5icbpR/GCu 1N4c18KYpzpjfYi5OJAMyZyx8CZ0aU9RAwSdWy4MkQ/7cwSavtaCWZw= X-Google-Smtp-Source: AGHT+IEbTliZMMMteEdizRos+1AHu9FPoptyHe9Rh+lSNJ1QAXfL4AckTCSdn7gI/5xVZtXQZ5HdFA== X-Received: by 2002:a05:6214:e4a:b0:6d4:1613:be3e with SMTP id 6a1803df08f44-6dd155eded1mr491439636d6.22.1735315022047; Fri, 27 Dec 2024 07:57:02 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd181d5ac1sm78866146d6.120.2024.12.27.07.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 07:57:01 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Fri, 27 Dec 2024 10:56:59 -0500 To: Donet Tom Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com Subject: Re: [RFC v2 PATCH 5/5] migrate,sysfs: add pagecache promotion Message-ID: References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-6-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 27, 2024 at 04:31:48PM +0530, Donet Tom wrote: > > > folio_clear_referenced(folio); > > workingset_activation(folio); > > + } else { > > + > > In the current implementation, promotion will not work if we enable MGLRU, > right? > Is there any specific reason we are not enabling promotion with MGLRU? > folio_mark_accessed may not be the best place to interpose for MGLRU, since MGLRU's semantics are so different. I didn't want to dive that deep until I could show traditional LRU benefit. Certainly open to ideas if you're familiar with MGLRU semantics. ~Gregory