From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCC8A13D518
	for <linux-kernel@vger.kernel.org>; Fri, 27 Dec 2024 21:36:54 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1735335414; cv=none; b=T1zrwEJ7AHLGfkQyZwKmpS1UZ34yPpw5LM6CCuFsL23p6DI9X1LMS1HisMbsz+98+VcKhLfEgDICv1Jb+CpVhHrFWmqElh9aUqzPFE1SMnG2giVnqiEU/z3ES6wrF48yXJ3SJSgTxI5nIISkulTA8Ezt3dOsOTdGAw9DokWBhlA=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1735335414; c=relaxed/simple;
	bh=Kle5ZH8p2WRwTwIbkgfeBnD8JHh114b3yt9Z06UAEvM=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=MCZzJtneWh4xKk/H7wdgI+0JJzk1zPKBvy3oa0Zdbi/+GaBrTCQXVFdByT1uyG2bCLFcFRF9rvliHkZQ8PYaxTBcXIeVVXGSmp2a4qXEYI4GLdV7rlCL+ro7tKSuGf5GFXBH1V3+2k0tZg4B+mrqNKjLa5V6mmmGdSA+Ltp2dzQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sKSYyOUV; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sKSYyOUV"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07821C4CED0;
	Fri, 27 Dec 2024 21:36:53 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1735335414;
	bh=Kle5ZH8p2WRwTwIbkgfeBnD8JHh114b3yt9Z06UAEvM=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=sKSYyOUVdnjixegj0LnJjex0oYicXdAyTmg10NVa5cZ9DRn8I3d19WWuO+EhCbJgX
	 9CKkqADOGZytbpqfMSfX8B8NGvF9LM1nfzPh/KZynr4XtTkXH9WKhK1J49pZ1RW+Eu
	 c1W8e/RgJRkTVZw67TLtqqer83UvqnZx+4hyX5yjxkaqG5W4EwjEzlLXQvg4EfCIc3
	 GwbMtWbDwAxaRisODDbmYNTktuMVEGDqiP56rTkMqkOw/SZlOtNbTTCWyxklkjO8yL
	 BXCC2kA2sF/jgKJxhfugiasfsQIDeH1xOxD0lYQpeg20x0exRaU/+b5mHThseJV1iH
	 riV1TGW/q92xw==
Date: Fri, 27 Dec 2024 14:36:52 -0700
From: Keith Busch <kbusch@kernel.org>
To: "brookxu.cn" <brookxu.cn@gmail.com>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	hare@suse.de
Subject: Re: [PATCH] nvme-tcp: remove nvme_tcp_destroy_io_queues()
Message-ID: <Z28d9GSF092kcAXr@kbusch-mbp.dhcp.thefacebook.com>
References: <20241203033955.394595-1-brookxu.cn@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20241203033955.394595-1-brookxu.cn@gmail.com>

On Tue, Dec 03, 2024 at 11:39:55AM +0800, brookxu.cn wrote:
> From: "Chunguang.xu" <chunguang.xu@shopee.com>
> 
> Now when destroying the IO queue we call nvme_tcp_stop_io_queues()
> twice, nvme_tcp_destroy_io_queues() has an unnecessary call. Here we
> try to remove nvme_tcp_destroy_io_queues() and merge it into
> nvme_tcp_teardown_io_queues(), simplify the code and align with
> nvme-rdma, make it easy to maintaince.

Thanks, applied to nvme-6.13.