From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBC49203D5C for ; Mon, 16 Dec 2024 11:45:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734349522; cv=none; b=UHbepoO55bdJrOT7PYzozVpw6ixCmYrZePyHJTuBQ6WuOwMpCpxuUsDy2+32uXcB2K8Y77095Yy31bSJGUQjCqnbZ5y0yMSemXnajWNc/Z4klNA6uHc0ZZaI0/gNrxqvahz96E+uHuN87ZYM+H7oZOMtR4HBOyZJDyuNz+6JQog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734349522; c=relaxed/simple; bh=WTOoaCm/YBEOFwnlmetmHLAw1bQPebroxLWPCI/KuzE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YT4EnlIesmNGJXnfGkbGUlGTeWBxuVIBZBFssiEoW7huUuZEFDC5tRl/N+mbUTlh0UZe+H9fT3WCSPGmES4M02WwByrzIknKBRFTAu12McNm3gWuAVEql8WGYyja92TCBu3cfTgPEp5IF7I/DkZ3CiywtQXobB/ieUMBc8wcybI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HBtpCDPi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HBtpCDPi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6361C4CED0; Mon, 16 Dec 2024 11:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734349521; bh=WTOoaCm/YBEOFwnlmetmHLAw1bQPebroxLWPCI/KuzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HBtpCDPiiLGdhIMrs2nzQ0gaX8GQiSsbg9IRMMdwgeEWTJCnNRfPkkmDlopn93+fP u5oSbwSqUdfqmE7hS5WiQX1dzbzp45l3N5c4e1ehPquM9rmKBbnMys3d+m7/y4n1H5 bQ8ad1/0Pm75iGknuobmgc+RpZi27qyyPKi2Hgc6wOPPiSkZnW2oVouZWDszqNicHG XCZdZTb6GR2y6wanoeCcIoaaSmBmm7B3dgC5u0IThQejxFZQO1OcPn1+wAVQD92V/c UHnZVrhmspfqU2KxRdnpsLGXuFBB6DvgjYcHmDphhnmKJHYNmqUFcotBPusfs+7u2B vqn1QQEUnY/vg== Date: Mon, 16 Dec 2024 12:45:15 +0100 From: Danilo Krummrich To: Dmitry Baryshkov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Karol Herbst , Lyude Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, Laurent Pinchart Subject: Re: [PATCH v2 0/2] drm/nouveau: remove drm_encoder_slave interface Message-ID: References: <20241215-nouveau-encoder-slave-v2-0-ef7a0e687242@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241215-nouveau-encoder-slave-v2-0-ef7a0e687242@linaro.org> On Sun, Dec 15, 2024 at 12:19:22PM +0200, Dmitry Baryshkov wrote: > The nouveau driver is the only user of the drm_encoder_slave interface. > Demote it from KMS helpers module to the nouveau driver itself, moving > corresponding I2C encoders to be handled by nouveau driver too. I understand nouveau is the only driver using this interface (and the corresponding i2c encoders). However, I'm not quite seeing the advantage of folding the interface (including the two i2c drivers) into nouveau. I don't think this legacy interface does harm the subsystem in any way / does prevent the subsystem from moving forward. Can't we just keep it as it is? > > Ideally those two drivers should be converted to the drm_bridge > interface, but it's unclear if it's worth spending time on that. Probably not. > > Signed-off-by: Dmitry Baryshkov > --- > Changes in v2: > - Renamed symbols in defconfig (Laurent) > - Added missing Kbuild file (Laurent, LKP) > - Renamed guarding defines in include files. > - Dropped mentions of two removed functions. > - Link to v1: https://lore.kernel.org/r/20241214-nouveau-encoder-slave-v1-0-beda767472e3@linaro.org > > --- > Dmitry Baryshkov (2): > drm/nouveau: incorporate I2C TV encoder drivers > drm/nouveau: vendor in drm_encoder_slave API > > arch/arm/configs/multi_v7_defconfig | 4 +- > arch/parisc/configs/generic-32bit_defconfig | 4 +- > arch/parisc/configs/generic-64bit_defconfig | 4 +- > drivers/gpu/drm/Makefile | 1 - > drivers/gpu/drm/i2c/Kconfig | 18 ---- > drivers/gpu/drm/i2c/Makefile | 6 -- > drivers/gpu/drm/nouveau/Kconfig | 20 ++++ > drivers/gpu/drm/nouveau/dispnv04/Kbuild | 3 + > drivers/gpu/drm/nouveau/dispnv04/dfp.c | 12 +-- > drivers/gpu/drm/nouveau/dispnv04/i2c/Kbuild | 5 + > .../drm/{ => nouveau/dispnv04}/i2c/ch7006_drv.c | 30 +++--- > .../drm/{ => nouveau/dispnv04}/i2c/ch7006_mode.c | 8 +- > .../drm/{ => nouveau/dispnv04}/i2c/ch7006_priv.h | 11 ++- > .../drm/{ => nouveau/dispnv04}/i2c/sil164_drv.c | 33 ++++--- > .../dispnv04/nouveau_i2c_encoder.c} | 85 +++++----------- > drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 20 ++-- > drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 4 +- > .../gpu/drm/nouveau/include}/i2c/ch7006.h | 4 +- > .../gpu/drm/nouveau/include/i2c/encoder_i2c.h | 109 ++++++++------------- > .../gpu/drm/nouveau/include}/i2c/sil164.h | 4 +- > drivers/gpu/drm/nouveau/nouveau_connector.c | 6 +- > drivers/gpu/drm/nouveau/nouveau_encoder.h | 13 +-- > 22 files changed, 172 insertions(+), 232 deletions(-) > --- > base-commit: 4176cf5c5651c33769de83bb61b0287f4ec7719f > change-id: 20241214-nouveau-encoder-slave-a6dd422fa4a9 > > Best regards, > -- > Dmitry Baryshkov >