From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80917204597 for ; Mon, 16 Dec 2024 13:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734355200; cv=none; b=TVoS8b0dCxXHSX2RDKwAjgEncN7v9SlFgOO0mj+SeCVbe+i8zIMRBBbMfdreNOKYO+3DGt1ZVmzf2nBUI2K6aGqU16CXXJvfSm3+N19MORUaoN9nLuSBGRmfZPedfhebkO/8JDF0ImaMn76dBWvfRcw566fAn+Kxm8Yb8630bZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734355200; c=relaxed/simple; bh=l5YhrR+CX9lbYsE/9OheTAC/N4CRxTnq2ihla+kxOiw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mso1xf5XCfq4wV+hmyuGS9lScPGjIK8S4YvnJ1J7pnMmhcNQVwNYC71VYVzP7sSe7P4dF1fqAUgsVEgpKFgxR/A2Tkn31Ljr5eM8Hb05w1k5zQIF7o5ux0GcFHx+0RDD+41HmFQLl7QbHKIEgy3x+n9X94LQTm59CYmjn/YsWnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNB0m-0000Fi-Fk; Mon, 16 Dec 2024 14:19:48 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tNB0k-003hfY-0Z; Mon, 16 Dec 2024 14:19:46 +0100 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tNB0k-002bbw-2i; Mon, 16 Dec 2024 14:19:46 +0100 Date: Mon, 16 Dec 2024 14:19:46 +0100 From: Oleksij Rempel To: Mateusz Polchlopek Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh , Andrew Lunn , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, Phil Elwell Subject: Re: [PATCH net-next v1 1/6] net: usb: lan78xx: Add error handling to lan78xx_get_regs Message-ID: References: <20241216120941.1690908-1-o.rempel@pengutronix.de> <20241216120941.1690908-2-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Mon, Dec 16, 2024 at 02:07:37PM +0100, Mateusz Polchlopek wrote: > > > On 12/16/2024 1:09 PM, Oleksij Rempel wrote: > > if (!netdev->phydev) > > return; > > /* Read PHY registers */ > > - for (j = 0; j < 32; i++, j++) > > - data[i] = phy_read(netdev->phydev, j); > > + for (j = 0; j < 32; i++, j++) { > > Maybe during this refactor is it worth to add some #define with > number of registers to be read? I prefer to remove this part. Please see patch 5 -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |