From: Johan Hovold <johan@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Jonathan Marek <jonathan@marek.ca>,
Stephan Gerhold <stephan.gerhold@linaro.org>,
Abel Vesa <abel.vesa@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [PATCH] Revert "arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports"
Date: Tue, 17 Dec 2024 18:12:56 +0100 [thread overview]
Message-ID: <Z2GxGJTrBJ6Md80b@hovoldconsulting.com> (raw)
In-Reply-To: <173445353301.470882.1221462093815662513.b4-ty@kernel.org>
On Tue, Dec 17, 2024 at 10:38:51AM -0600, Bjorn Andersson wrote:
>
> On Fri, 06 Dec 2024 18:24:02 +0100, Johan Hovold wrote:
> > This reverts commit 1a48dd7b9ac809d1bd0fd2fef509abba83433846.
> >
> > A recent change enabling OTG mode on the Lenovo ThinkPad T14s USB-C
> > ports can break SuperSpeed device hotplugging. The host controller is
> > enumerated, but the device is not:
> >
> > xhci-hcd xhci-hcd.5.auto: xHCI Host Controller
> > xhci-hcd xhci-hcd.5.auto: new USB bus registered, assigned bus number 3
> > xhci-hcd xhci-hcd.5.auto: hcc params 0x0110ffc5 hci version 0x110 quirks 0x000080a000000810
> > xhci-hcd xhci-hcd.5.auto: irq 247, io mem 0x0a800000
> > xhci-hcd xhci-hcd.5.auto: xHCI Host Controller
> > xhci-hcd xhci-hcd.5.auto: new USB bus registered, assigned bus number 4
> > xhci-hcd xhci-hcd.5.auto: Host supports USB 3.1 Enhanced SuperSpeed
> > hub 3-0:1.0: USB hub found
> > hub 3-0:1.0: 1 port detected
> > hub 4-0:1.0: USB hub found
> > hub 4-0:1.0: 1 port detected
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] Revert "arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports"
> commit: 1fb5cf0d165afc3be76ec754d1b1013515c3896a
Oh, you appear to have picked v1 here.
We need to revert also the other two patches from that series to address
a suspend issue and to unbreak UCSI and DP support:
https://lore.kernel.org/lkml/20241210111444.26240-1-johan+linaro@kernel.org/
Johan
prev parent reply other threads:[~2024-12-17 17:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 17:24 [PATCH] Revert "arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports" Johan Hovold
2024-12-07 21:49 ` Abel Vesa
2024-12-17 16:38 ` Bjorn Andersson
2024-12-17 17:12 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2GxGJTrBJ6Md80b@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=jonathan@marek.ca \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=robh@kernel.org \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox