From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.8bytes.org (mail.8bytes.org [85.214.250.239]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E078415852E for ; Wed, 18 Dec 2024 08:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.250.239 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734510870; cv=none; b=WV0PywtJT7Hixrr+K4E65pPb4z3O94SsUoh+SQ8OOewIlij1QwuwOGF/a3VdxlSR9YheKbtT5yRWFbZvOrw0m2LeMfddwBAEPkWVLVB4um1Z6+9j9XQhf2V6n1ThenqfKvMzYkcHvMvKy9cXwSLH7oSHKpTnGfZsXvyFEZjBGQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734510870; c=relaxed/simple; bh=AXgiAqf8zCy4z4l+ZTo7yj4JmZDdaTu2SLMSWq8tnIQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b6jcqqD/5uvsRCT96HeQ4x4I6Hdlrlhn/sH1iRKZMXp0tceA+28YdEIgUD2EGxpZFlVl0BBbpoUxiXGtWIXY/NQiyLxiOFmMQCDA7NVKqFL2JzF0fF2lOTOc6mgmJMdYLO+vRh5ORRqr//qSkAtHPmcmae0YGkuvAVoAV4Y2jus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=8bytes.org; spf=pass smtp.mailfrom=8bytes.org; dkim=pass (2048-bit key) header.d=8bytes.org header.i=@8bytes.org header.b=L/PhBiQX; arc=none smtp.client-ip=85.214.250.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=8bytes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=8bytes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=8bytes.org header.i=@8bytes.org header.b="L/PhBiQX" Received: from 8bytes.org (p54921e31.dip0.t-ipconnect.de [84.146.30.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id E881F2C1E66; Wed, 18 Dec 2024 09:34:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1734510867; bh=AXgiAqf8zCy4z4l+ZTo7yj4JmZDdaTu2SLMSWq8tnIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L/PhBiQXCXvUKtQdIm9SMrOIEG/IPm44+d3XGhPbvXnJbzybv53AcIZwyf5SkhHuR SXxBQukR52ioyiEwII+nyrYUhTxEHkzgjodjMVZ8iYc8HdTGW/efqBbcv7PqObKH54 kg0vTaoZECbO0HI+AlSTo6Bal7djOaqV+svGcDuFEgVuwAr54TiWk4ZZl/vU3WuN5E oUDwqenELP4tflBZycWNPIfrPW4ruT7LtRcZPyy5AN5WbzcbogyWo8qFgqkxt8Tdt+ 8NHubypRIuLmUBGw5BGckHCYHHy6ruqajXfLd/xwdoXYRsupbHfFkTejD7Kz8CWMG6 aUOmSPjK4elDQ== Date: Wed, 18 Dec 2024 09:34:25 +0100 From: Joerg Roedel To: Kees Bakker Cc: Baolu Lu , iommu@lists.linux.dev, Tian Kevin , Will Deacon , Robin Murphy , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] iommu: Avoid use of NULL after WARN_ON_ONCE Message-ID: References: <20241115190316.28A6B18DFF2@bout3.ijzerbout.nl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241115190316.28A6B18DFF2@bout3.ijzerbout.nl> On Fri, Nov 15, 2024 at 07:46:25PM +0100, Kees Bakker wrote: > There is a WARN_ON_ONCE to catch an unlikely situation when > domain_remove_dev_pasid can't find the `pasid`. In case it nevertheless > happens we must avoid using a NULL pointer. > > Signed-off-by: Kees Bakker > --- > drivers/iommu/intel/iommu.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) This patch is Intel VT-d specific, please use the 'iommu/vt-d:' prefix in the subject line.