From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2064.outbound.protection.outlook.com [40.107.94.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53C10481B3 for ; Wed, 18 Dec 2024 16:18:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.64 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734538695; cv=fail; b=d6R3WEHfalpmKK2fNbw6eOWl+Lt6oMy8v0gyVMNRqeBf5DlbghKOJq+1AOG7QytualaUgdtNgA2a+MUaHRkmMfblohrRpcl+3WRHZS+O3FrxtmowIqZCOCXG7mVky+/tVHDIrqOGFUF9vy4Q29avxDIfMj3TKHlQ79J3zBIE5Yc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734538695; c=relaxed/simple; bh=GcXehWFvw6AU1rOMW1WKo7HOQ90s0SH8QWLWvgj8iB8=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=XgtN8XDd0mFsKa+kblSfsWs45QEEt8bcN04ufRbwey1No7VL7C/x1/W1E+wPm94Xe92O4ZJDPMyE/8On7nZvSAK2wk3Z2CFiH4qBrLYtF550X0XoN5zrp7tY/J8N1BD8gDInvzYXLZZ33h7j/9fScZLF219nNn4DJIx6IuyFasc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=aSD+3Ffk; arc=fail smtp.client-ip=40.107.94.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="aSD+3Ffk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AfkzoK0n48J3ed54NZkmfW5OVzJmEtuXEq+w+nSs7qhcfWpiWlHMdmT+YdRmZ6qGkfihiY6Ds0ToCrg766cAN3iUoY1COeN3r7n4QHCWVezNQ7LH8ufkZtbVa1SlXYUoQzi1EOWM+ooVndUHIQRaJKcoU031KtbGGQoiw2w8nD69Xg4a/fT1gYMntdqzUvm2tSw9P7VPHgww7M76tCHEdyc1TmaMb6nEtBB7ZhrZMznrYKV80vULCBKZU8uY9KJmsNA8/WHTg3FBrklWBl10I4OdR/axWi6iX361gosiuzFX8HVSlj7OSbQ7lW2MOCeh8MwPXK8X6q2xi4JmN/5W3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6y1pQy5AIhODTGnFHVjwk7BNmc4ekyQ6Ll+JMRoWSwA=; b=j+cbCqE5GgKmCDtwtsmOrhu+alp1wHML8Qs3PaQ7UfZE8J9HHU9lZnb47K7m8Nk3phK1WL97sVHD5PCbttYjgKoJDf/ngsdiVOJIoQnxY9EMeaFKqCdpcqbtz27u7tU9au83+guYnhwHDjONSng2sJhcjZ++gCNXecbBDT15vwXJDgYBSofAWI/zV/LShb/iTr46lupA3dTvAQsA+ym4e2XLNt9UWgdlSRWNrWPc8zJTGJQEZiY8C8BuqbJ/0clgt4sT3x42/EnsDgAz95nElWR/PmZyR/qVm819LU4QRlKkAkBPVk0i8hqy8h94IV9xODSKQ62SQQly1nvG5uierw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6y1pQy5AIhODTGnFHVjwk7BNmc4ekyQ6Ll+JMRoWSwA=; b=aSD+3FfkwTx2TUncYmy7otzni4UOo5SnHrOp81Gpgdd4xX7lXoqpMmMdgH6goFi4KO5w6B98t0nu6BNF2siJPCazJvj3BRqzQrP55/NoISSdHCIClz6YVOziE8jN9FbHKrf27ceKXWtub0+ydKmInGZeHiF4SeT/dvfH8RdkvjFouQiixzSUcQis4Sdp+VeEOKFS/IXku4JBsUi+2uu/zPSM1TZKRUdvj9Hee+ho/Ju19CBcjWzUvJDOKfEdkuVeAKyDejhg58+/xR7V+vxpTiYhHK69+xEkY85uyF+Rzo+/sjxMx085mO3iqIYbvdwIuuBhk7JZVI1GreIMLRtxkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) by IA1PR12MB7685.namprd12.prod.outlook.com (2603:10b6:208:423::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.13; Wed, 18 Dec 2024 16:18:11 +0000 Received: from CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5]) by CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5%3]) with mapi id 15.20.8251.015; Wed, 18 Dec 2024 16:18:11 +0000 Date: Wed, 18 Dec 2024 17:18:07 +0100 From: Andrea Righi To: Tejun Heo Cc: David Vernet , Changwoo Min , Yury Norov , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] sched_ext: Introduce per-node idle cpumasks Message-ID: References: <20241217094156.577262-1-arighi@nvidia.com> <20241217094156.577262-4-arighi@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: FR4P281CA0096.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cb::10) To CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6405:EE_|IA1PR12MB7685:EE_ X-MS-Office365-Filtering-Correlation-Id: c50a61dd-a5fa-45d8-5ebc-08dd1f7f9126 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8vNKo65O1/HRZjU3k08uPRARJkSn3B6L3yKh3x5+vnCAFCZG6zHBL0Tv6sJm?= =?us-ascii?Q?j30ri+SudyStXwWRfkAnhktANGNAxwkhOVaO8Mux75oyd1mIQlvOYM6rfGCa?= =?us-ascii?Q?kl3P/FXbCTDKwPr/w4skPExBFZN6jFPbsE9kCrBYyJxi2LuBd5MGy/85EckY?= =?us-ascii?Q?ovgPAuKEHO5gWM8NJkdFipXXcr8c2Ks4/xdjkvoDHbiLZdfCqg4yPC0fuchA?= =?us-ascii?Q?kLh4pBYqfAVnqVIX/av4SZZ1L6SEgQTbg1vq2pAQcgogknBOqMieqwons/u1?= =?us-ascii?Q?BlY3GoTvVSTV57d33kwXQwVjWCaSY/k0mDzDLzUKnvpJagIySDPaPT1qScov?= =?us-ascii?Q?hC9Q+75Dutw16mn50UV/NuOWCetUe1RepcLFPOUp9Wc3f+LX5yBgng9AtaNh?= =?us-ascii?Q?OPKe8l4x2Oj/hDJuCcT6yZ1opBOQuHnem9zK5uszJgQbudt4mzI976LywnxH?= =?us-ascii?Q?PdJlXk6bQiT0hlcwD55DtmH6DsvW0YOoxxink8yM8g0tKGFJsb1DgY30v5dB?= =?us-ascii?Q?4jWZEQsFvPTy1oIIED1gxaW/IYQ+CUNRjDceL5zy04nV0d2unYzwvm7p7GpJ?= =?us-ascii?Q?rKojZXbTT/Ya6LvABpW61aaLU2icVNZZPbVmQ8vGmw47YlGAE+BV9ipR9mqQ?= =?us-ascii?Q?KEmMF3HEOIdbIi7gOarRoGkVGIZPW4H49IhE9Leuko+XxlFAPpgZGcyza4db?= =?us-ascii?Q?EwkcZRkcfhYY/okzBk1xrTMZtAswRSPrRVTLXHGKM7zU3hiA3OySeo/6Omxl?= =?us-ascii?Q?k6qs8h0MUC3BLQon9S8fWlqGLW4OHcWhVPoKeZPW6g8Mg47K0GoQVOsaVsmr?= =?us-ascii?Q?OjZxsqSygz6SJlT0dNgtIpd8VDdwEOlUYmYytwxuJ2mxfNEbMKcG7yM2JsX1?= =?us-ascii?Q?f4iLZIna3ERIsuNdE80TYfvuISdAeHL/q8xbREkyGu73OKEoRVwHaMP0KwAT?= =?us-ascii?Q?2RQS3WpoFw1cNYwFILeG6G59irhJRNDM1raMslyPfmz6rL40gqV84kyzew5+?= =?us-ascii?Q?xX7hP8yTnO7z/2r6AhX76GSloeGso0fBWaud1kuf07+7w0SdtjCBrJOLWn10?= =?us-ascii?Q?UNTfGVpQIg8Z/8La+qpLqoCwYLfkrRPaa2QXCIwEoCvUc9za7Ix1amweDjXs?= =?us-ascii?Q?VrU8fDdJsnxlLN3c5/d/KRwYH3AgAX83ldLPyHVcGYJJossIGqC5/tNAFUWH?= =?us-ascii?Q?dCqTT5toex+rtdztlk47tDcD4XXpe0CkyKDOf8R3dWmxLW1wbC/g5wXc6vN5?= =?us-ascii?Q?d0MvQWS3/UVcpAzRwCiFeu71uSHHntnxp5HMqWfkrDZ4nEfkrdnPXfcCzkyj?= =?us-ascii?Q?XpJn2SLGDivRFq5GWa12SCei8O51CwEPhlCT+QKaa8kG/fHbh+dZPYr4S5LT?= =?us-ascii?Q?83Y3qsYH+2fhx5XAmf8pPOIjUogw?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6405.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a5BXcWACSBMudc9J6hnlJMqWMSL0R8/9/jElrqFQr/S4vONKYy3NuIgV0Q/t?= =?us-ascii?Q?ZOMKNSrIuXN8WIq/fqzZIWsL0Wxh8I0w5OchEy6oSjPYHWUkkMpgYoIE5TNM?= =?us-ascii?Q?bF+6cHkQzAlrYTRnEiYSzNWI7xy55joslJ4jISKftw4i6lPD7lcPX6Vd/+9c?= =?us-ascii?Q?nU8ZI4NaaR9XscWVykXYXvMngK87p/G7uDbiK+SGvXgWGZ6DzIxS1der89hQ?= =?us-ascii?Q?s+7gi1iWk6nnXRYSk1bk3JlKK04rfitniLdChnN9QevoFQ9J0zoT6NGm+li8?= =?us-ascii?Q?sE0hHuZj/rPos+KGV7MuHpWbSGch9YNdONdCwtWfDRYCFaqjj3uFA2R2AT00?= =?us-ascii?Q?zQx18Y0PzxqV+llKf8TlTSwVBzSP3TE+8/1wiH6kD/QdxOPVaoJx3lnZFyFM?= =?us-ascii?Q?9ZtTfQJso/I+pqLE36lv/ZBOms/PvOoYo+uO3J6tz8o4vj4dRvYgvYesndwR?= =?us-ascii?Q?W94KxzN6mOhADtl7zV/LaoM0QRT1mgYHEKSEjh/IrDselApVlrNym7DPpgHM?= =?us-ascii?Q?Q8kLr+dS0Q6iBBEIS5WP6DuNdDZABRxfoWnCQCf+RQDJkjhuYfMUpmmRz3H5?= =?us-ascii?Q?zPtkIAq8PV4dbnLHJMI4ZjP70I3A+MONP85XrnAzLoRRrmbJ7temJjVcQpq9?= =?us-ascii?Q?Nw7HWFlc1ifphrb6AQU95p7yOPPiFtU3vl2pQFoXtKCvqIne0D684yZMTCu4?= =?us-ascii?Q?A4Ke0ouxwQe0M1lX54CDQ7Nrg8zNDA6PxZ4zSAFUc9PDtMopUAIUutDvr6g1?= =?us-ascii?Q?90QQGdmTSuICUzJMltDmR9aCML3CeQGKm51i9Zx6KQdGJrczZDv9JA9tpurD?= =?us-ascii?Q?/MAsiPh6aDazt+w0VgMjZDHTJovwb+7Bfh/MLAXq+dHiHZQ9okBJ0jPymNt6?= =?us-ascii?Q?vBA/8MqIOW6mDNWyI82cgAx5Q1Bq5cxsTYrOJlRppGmQ5G9mRFtw30+hj37L?= =?us-ascii?Q?KY34KZcRJ+bXGAJHQ2WP0K/dOYWaEa66mOslvQ973IrvicS+EJNxWAcCOLSw?= =?us-ascii?Q?ZZYWqBweNBF/E6c0IJqCK8rgWwSXnMSgdPfUhIDLgXLI6NDqRBGFg3AWveL4?= =?us-ascii?Q?IYfpi3V2c0sUNvNIp0RSt5UZUMWfNUG6XGExdeLcgVFqDVYbFPOXJ29+gBfk?= =?us-ascii?Q?dyJOmSLqjKaO9bm1z9UUnXBVS5ADtmzjBb/z3GLthU57XV+dOkKusETebygY?= =?us-ascii?Q?Euc4Z6EXytMyYRehfZsn+iVSOcPTcI79UZRffSgdRhQlTyAj/nt3UNbHZgxA?= =?us-ascii?Q?9YbOSu2boRKa4t+OdBSmZ0pZvEz0Sj+tAg+4xlrF3q0JUr1YTJ27UMEjX5VV?= =?us-ascii?Q?HvXxbUhPb/1JE0vLngkuPGjy5ETpCBeBFl/Qc5xanbmE2/tuJy/wZUKB8y5T?= =?us-ascii?Q?J4QpChLrqsqwqoJS9DQcjvMGluxFtsZ1ryNlqoySeRwesNINBBrZ+12HwTig?= =?us-ascii?Q?WyidSYNphLTVyEKvhkYRKdCnHHuJ111zkG+d6kwWuZXLvxB2Amz8tDFxO/8f?= =?us-ascii?Q?3vZSHf3n5A2MhHQQFrIHOTK9/YkOFnWlblg6sBhgyIgBanq1btoajrF1efWO?= =?us-ascii?Q?y5RRFNl3wRrMCQSwzVIN4nnrWPXhujOL2h8ekRtA?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c50a61dd-a5fa-45d8-5ebc-08dd1f7f9126 X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6405.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2024 16:18:11.4071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9SHI9tDrve9L2tIgPTzn+zQWd6Qroxw1g7e7KP1u/MHnITzzy3S54eF0xZBY/LevyI286rVdAnhQVXwsWJSvgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7685 On Wed, Dec 18, 2024 at 06:10:17AM -1000, Tejun Heo wrote: > Hello, > > On Wed, Dec 18, 2024 at 11:21:30AM +0100, Andrea Righi wrote: > ... > > > Are node IDs guaranteed to be consecutive? Shouldn't it be `node >= > > > nr_node_ids`? Also, should probably add node_possible(node)? > > > > Or even better add node_online(node), an offline NUMA node shouldn't be > > used in this context. > > That can be too but then we'd have to worry about synchronizing against > going on/offline. Looks like that's protected by mem_hotplug_lock, so we'd > have to require get_online_mems() around these iterations, which might not > be worth it. Besides, if we want to triger abort on incorrect input, we'd > have to call sched_ext ops under mem_hotplug_lock, which we probably can't > do. We can probably ignore this for now and add a "restart" logic like we do with CPU hotplugging at some point. -Andrea