From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54413222D6B for ; Thu, 19 Dec 2024 11:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734606871; cv=none; b=PNrLk7QZHVz9DgQosu0kTLSWFzABAXqKuD2Av7DiWQSH0AUK+Jlo+RZ3xkYHA3MaePKKzp0yuhIDi8eZphWw3X7tTWJqmsIZgtYQVcxSF5yEBMg0mprav5MqLoXKVgWmaUdJAl+a3b5ZMi9RGkZu6dgBOIQOOxt6IQRRiQWA2qM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734606871; c=relaxed/simple; bh=8RuIoJ0q/4dY8lZ6nY/JYhaMNSssJ3bm0ZjjKWMF2fc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UvDS8tGQwWdUBeea/xs7qN8c7gYCo4/tjwp1cdjrF9ayPvF4QVxqjzQBBLDj4ukGSVYuG2FV3CAoTVSFKVZ/XnHYDWOuxs12iZ0Evg2Bm9+Pv0ZxwA1N39ep1LBOmXkDWnTnAYS1Ya+Umhb+zH9+RIOdqK06mE+16UYCnRZZG3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dlx9f1SI; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dlx9f1SI" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aa684b6d9c7so111922866b.2 for ; Thu, 19 Dec 2024 03:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734606866; x=1735211666; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=k232UiDWZ9i334Ovjw0KByCgbnjokcMOWAtrXY0DoWA=; b=dlx9f1SIhONap9JFnFSFHc++JDLMyU8U8DclgWfYuDfNNtPHGU9kD/jz6TZS49R47e fHh96wQKUJSbZhL8Sq/qDzGqrxx8dme6QiJ97mFSfOOc7qTal2fFFCZng3ab6BHqMCdf mhZBwBSfeqRlo9SgdaRC92Ji9tEDSEEy/JGmn92oOSLLK4Hl4ieAcqOVXzZcof4P0Mqm LvHZfudUg21eGlT0EG1rJYTBLgiZZwv5p/DCUEwb2uQz+SZd0RI20QM7zzJW15J5sgtQ 4f9yPo+jZqKnXjlT9PuV5p95uRZgMC3GMcxctmGs8+ld3U+HGcw+z1B7X6XmlrlTvXEh S/tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734606866; x=1735211666; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k232UiDWZ9i334Ovjw0KByCgbnjokcMOWAtrXY0DoWA=; b=UIGrQazwzE6Rc7ChLnKfGJKPDXJHXDO+RfmuelwhQYKsNnVJcGO0np8YmCEDP1EeQ2 pz31N5Dt0ikdeOv8HTndMjRCLS9ZfbQTVVhXtpKaab/briTWWmSRSYxVFmRCODlUSFuu jg9fPymJ6dytxgE3OQUlm7QlfZSH5gOd25huvvzsb+XFIN8TxSjEYQest9aDPuPVPCjW 4GGWirmuW9XCfmU0UM0ChcFmGZIKRvdduW0ran3A2O6sJUE2m/XsPx5KmrykicMu26Wl hYRmVdSKzQXc4p13LxslzOet0+m24HKf+yan4rh8CS4YukLJ0UwifxwPp1nGoCMhvJo6 0VEA== X-Forwarded-Encrypted: i=1; AJvYcCUQcpf3gpKt91AeSMc8cMIQQoyiIiZcZmTOBSruEz14/0s/8XXyRmHNV6yurp07ojHg/zR2Ib0/y88NU40=@vger.kernel.org X-Gm-Message-State: AOJu0YwOIjw7NgPLcMBiqqxgnf1oix5NgB5+pP5k0j2+SWBVkXVNjt9a OAawd9izS8lrSXKFbuUjkgsAvdE+bbGMdT96CmRKN7HC1uDl6q3Xe4T5FLJiQA== X-Gm-Gg: ASbGncttBQBaPa1Gdh9sq/2oegsMxS1KSK6UHMH6R5BMxh/4LYvMRTXd9+cX83Ub9yd 7DaynB8Fpe7vuWcCoRm2RWegkgjukDDj8u1BoD/7F+bO1ItfRA0Z5DEH1D3HPB95f7eXtn877Jl 5/RxmvlIFOitx5MqD+bt4io4ZvygvypmHk1q0y8ZxfWVEePLxdLARHSZCUfvjAt1ISNHk3ZqL9p LlPGiRaronG5dnSAmLLR+5WEKbm/rOE335c6pd94/iy3zUFXmPZfA9jJZ1i5KqO9rYZmAH4Zqwk EA6OJ8H96ryQHLo= X-Google-Smtp-Source: AGHT+IHKoh5EsN1uLkOfWMRdI2tQtHhYwKploXkp4V8soZqdefYj8PoGPzqWp1FX9+8rm326OJSgBg== X-Received: by 2002:a17:907:1c90:b0:aa6:85d0:1486 with SMTP id a640c23a62f3a-aabf496eb16mr518756966b.54.1734606866353; Thu, 19 Dec 2024 03:14:26 -0800 (PST) Received: from google.com (61.134.90.34.bc.googleusercontent.com. [34.90.134.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e8954adsm55343466b.64.2024.12.19.03.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 03:14:26 -0800 (PST) Date: Thu, 19 Dec 2024 11:14:23 +0000 From: Quentin Perret To: Mostafa Saleh Cc: iommu@lists.linux.dev, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, robdclark@gmail.com, joro@8bytes.org, robin.murphy@arm.com, jean-philippe@linaro.org, jgg@ziepe.ca, nicolinc@nvidia.com, vdonnefort@google.com, tabba@google.com, danielmentz@google.com, tzukui@google.com Subject: Re: [RFC PATCH v2 11/58] KVM: arm64: pkvm: Add pkvm_udelay() Message-ID: References: <20241212180423.1578358-1-smostafa@google.com> <20241212180423.1578358-12-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241212180423.1578358-12-smostafa@google.com> On Thursday 12 Dec 2024 at 18:03:35 (+0000), Mostafa Saleh wrote: > From: Jean-Philippe Brucker > > Add a simple delay loop for drivers. > > This could use more work. It should be possible to insert a wfe and save > power, but I haven't studied whether it is safe to do so with the host > in control of the event stream. The SMMU driver will use wfe anyway for > frequent waits (provided the implementation can send command queue > events). Mooh, I'm thoroughly hating that we need this -- pKVM is non preemptible so we better not wait for too long. I can surely figure it out from the following patches, but could you please expand on the use-case? On a side note I'm not too worried about the power impact of not having a wfe in there, again we better not be spinning for long enough that power starts to be noticeable.