From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E969221D9A for ; Thu, 19 Dec 2024 11:19:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734607175; cv=none; b=OqIp1+UgyLvN5WnunVOlV9aN99DPVgybU0z9dLpLz8uQs3O9ro8cprSsqx733w97VJ6sTS3YC1prdpndS431euZbt0l46NQTYbjX9OBrmsrQBQ907DpKVrIPG1DUXLcQJY7+p7XDJQi1N5kyQ5Q9p29SJTA3YESCsesQNm4N768= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734607175; c=relaxed/simple; bh=uCO8XIxLkLERtbLGEzOZDP1Nn56oL2YEsBEMIpvgr34=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J9Q8LXtZ4GyG5JLZieGGug2u0YxHcXK48EjXshsUTFA7Ouw/X8jGgVtXIMsUBE8ZYH9b54DoWGPY0MnCRzCo8G5jbCRDB4+wvaU6YXxBnVTFwe/aJIoOXzQ9XuFMRkjcuOIxqjjwSfhKgC9Or9uaKwp7DvF8YkC9JYDDAf0Hvyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=yGFy+2Wx; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="yGFy+2Wx" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4361d5730caso34635e9.1 for ; Thu, 19 Dec 2024 03:19:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734607171; x=1735211971; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DaFUYqfbJ0FVFTC0Qejf2fBra+Am279oXsL2ycAM8YU=; b=yGFy+2WxxmgNzs0qiy1oKH/tYnUxalPTpmagvwcspqUn3tRqLUSxiTXXrmONAy1nMj PwFGAYR9FEgP60P/lrTJ96grJRMspBbtFt2uRS6/RvU5xwG/24fi4CVoOasjwl0cn6o0 5cRAnXVKVyoQDxq825fL5geIwtZ/+0YgDd0eeRkv3oCCALoicvRtHCp7Tad6Qhf00QUs uxTs/Kz2unROw3YYNTmrLuio7qRO173oCOX3R9YYjQ/EGWqHgAMwDKe7cUEsZGp3GK5R Pgif1R8nJnAgklv1ikOe1FQsFB12q1uhYVZdVea4x69nd/l/zEG8G7W+aoJiY6YGcb5w inrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734607171; x=1735211971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DaFUYqfbJ0FVFTC0Qejf2fBra+Am279oXsL2ycAM8YU=; b=RjYnMN6hOCgSEJtYoQKyHABOaoYhb7G/Hb6y0u4c+Izf0QZIAR8dPBcPD1no2FTuYI TIQ7mg/B8SUpXJvQ9gJ5TSwlLs5hCkaVj2GaIZd0qMIUTQ2YYAlbOXcq6Oz++qwbp4fo Iwz+Br0bAHDDon+rcpsBVxHRpOaPfDJWJ4vCj7qee3R2P8E/eVJfdRnwjmlDtcaUNdih 7FX+svY5tbNN2q1tVpPPE1MJvVLjjwrkFXeCrpzHKe0syw6xQTGHY2/i04AHeIq2fU0x K+BXc8OHHOlcX5tLk5wc13LmzyWIWMUkkCWMVJZ0emKQMUE9JfTIloZOuCtb6VnRf09f MpaQ== X-Forwarded-Encrypted: i=1; AJvYcCWj3lpPMu2Y3Ff1Y4FT4SlHMYawcYI35V95mhb7ap1ncQSxEFqHN2ZU8+wDowEd+NT6ulRYr4U2wCNjLG0=@vger.kernel.org X-Gm-Message-State: AOJu0YwNEdPY3Bdw9Yj/Xj3U8U8rOhHrbG2ftbpgnC6mE6jY/c6Rmp2r dRsNrjdI/Rv3q2gIHeAuPNFoboWnjEWnSswi23jsWIxN6fBwXecmyMjtxCBhTQ== X-Gm-Gg: ASbGnct7jItP2P4YhaPVlvENYKiGGGv2zoIH8SkJCYqffgQUc5sfhlBdHjXHohdXslt tYYxHA2xLhzoLSd+5+/H2d2j7ZqTksI1lTZ/6kojE4m0naEdTxHGl8xZx9hejnMXQLdMNYroMSH T93ww1lk6DYGrPV9wBRUMDwBvB+OnTRYENOpYSyDaiHiiL94e2K69l3wgBlgIeyGoMn4Y1xe+3o oRnO3dz62wZe7U/mCImD7W4AiZOAi1ogFBaYE6N9orwO532J52ydaDcVyTwgVztVlSdzgLdicKu Wtd3PC6Yam5wogcjcG4= X-Google-Smtp-Source: AGHT+IGXfoawYuXIuMfIIDaYD8hngDHiUTctYslUp+cxCbwWzZSbONX4t2aPmw9QcUFfEenJ6bez4w== X-Received: by 2002:a05:600c:3590:b0:434:9fac:3408 with SMTP id 5b1f17b1804b1-4365e5dd70dmr1072565e9.2.1734607171199; Thu, 19 Dec 2024 03:19:31 -0800 (PST) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8a6cb1sm1345355f8f.89.2024.12.19.03.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 03:19:30 -0800 (PST) Date: Thu, 19 Dec 2024 11:19:26 +0000 From: Mostafa Saleh To: Quentin Perret Cc: iommu@lists.linux.dev, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, robdclark@gmail.com, joro@8bytes.org, robin.murphy@arm.com, jean-philippe@linaro.org, jgg@ziepe.ca, nicolinc@nvidia.com, vdonnefort@google.com, tabba@google.com, danielmentz@google.com, tzukui@google.com Subject: Re: [RFC PATCH v2 21/58] KVM: arm64: pkvm: Add __pkvm_host_add_remove_page() Message-ID: References: <20241212180423.1578358-1-smostafa@google.com> <20241212180423.1578358-22-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 19, 2024 at 11:10:23AM +0000, Quentin Perret wrote: > On Thursday 12 Dec 2024 at 18:03:45 (+0000), Mostafa Saleh wrote: > > From: Jean-Philippe Brucker > > +/* > > + * Temporarily unmap a page from the host stage-2, if @remove is true, or put it > > + * back. After restoring the ownership to host, the page will be lazy-mapped. > > + */ > > +int __pkvm_host_add_remove_page(u64 pfn, bool remove) > > +{ > > + int ret; > > + u64 host_addr = hyp_pfn_to_phys(pfn); > > + u8 owner = remove ? PKVM_ID_HYP : PKVM_ID_HOST; > > + > > + host_lock_component(); > > + ret = host_stage2_set_owner_locked(host_addr, PAGE_SIZE, owner); > > Any reason why this can't be expressed using __pkvm_host_donate_hyp() > and __pkvm_hyp_donate_host()? That makes more sense, I will fix it. > > This doesn't check any state, so it feels like a dangerous primitive to > have. Is the issue the overhead of mapping/unmapping into EL2 stage-1?