From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90292218EB9 for ; Fri, 20 Dec 2024 18:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734719810; cv=none; b=IM/LpPVs5pTVhlgQApAs9q89k5ppP6By8ijerwa4Ysv2pKHsrWeNHU2rivCWnYQe0gBcWOaWnn1Iru7LvEgWFvDVWHLOfD7dGeBwJK0Fd/PozNEbYnx8zWntw7wm1CtidZQ4/45+VbY9L06fYuCiyfO1XK5U6ODsOBoZ/Nh6EEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734719810; c=relaxed/simple; bh=M6g8bK5Gkl/ysQcGTsLg1VMAYjpt8OizXwA+HR2u9bo=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=faMy16ROON9ruvRL1djLicp/QBGqQ6O+OmlELSQxTMzAgeTxrzAU8+xWtwXi0q4jsAI8jEJkztzYHqPF0bPq4jy8Lzh1p++A2AiIhgKJBG6j/Uu5rw+YQF/EXndcHdWf1QhxURrkVL+uot4m2x1qcmrgQWM6suTlfGlwsfC6VzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=YJ41yX84; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="YJ41yX84" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7b700c13edaso108818485a.3 for ; Fri, 20 Dec 2024 10:36:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1734719807; x=1735324607; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=+8l87UkO1FsVBdmut5rv9MW930uB7khYn6pwlB72Hhw=; b=YJ41yX84OGN6A86nh4gIST9iu1tTLRyiffHc305lORxgY7Pa0dxOAFLSns+ES6vgOG DN66hS6veQNjgHRyArTEP9IM9iJn+0/MsJ9HNMJp5aQiREOhTDXudP+QPl5JZEjZuIak 8kZsWlVMCCpfnrzyv4cv/P/wG5F1cpDpa9gJX+UV1JQ6iZljrjRnR6IiKgNwvFwBtVVN CebGgR/tg1D0An3asHSr1j6XkRh6nXN0GweyV/tMm/OmUZpEckw7c28Uans4w8Yl+7Py 5+QTK5n3QUBWNlmj6PqT6NOWIOXnA3ym1LccfOZj2Zr95z8E9kL9Ayh5uf3FGd2eS7cG Ew2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734719807; x=1735324607; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+8l87UkO1FsVBdmut5rv9MW930uB7khYn6pwlB72Hhw=; b=r8BI9NSHgt/lS17IIoivL1OH+hlU4DpsN7CW5csEYuUBRYsZ24EDcel3clu26+UVve S0hCFN2iyi1PeCHDVCvd7WEDznlWiEDDGp03n2jDZHCH0BfzwOvjf922v0RkZYI+ECxE Y0+tZ1htEiESOeUOTxGN3BjYfROX83mEsIm8J4cGwoZcUIZH+W/v6Be1ZlYW9YxtUS5V Xh4awQ30vwMpMccZ+Qn9TXc26USFBn8JDfEcchJZ899EJ6xm0zDqXaGYUFwX+DDtCkIw 6e5gcX7Kao17f2QhoSHWJyaY9f+VGQ3/hddBGnd580kYhmolIQb87CwG+3SmON2Q0y3d x2BA== X-Forwarded-Encrypted: i=1; AJvYcCV5c1aBySiMRxUSAydIhMYiryTYmQja46eUOHZxSAwDl8IrBxS4GhnusE52qmCAXvZ1nHc0yZUnVDaSKLE=@vger.kernel.org X-Gm-Message-State: AOJu0YyvsLUcfodINq3jW7DRUNYfb+a7UZT+9w115Nj4ohI55pWcN+lo UiJ3CUvbZqK3C5C1IGq20qOlj0JxUTArtRg98925NB37gUGryv6V85JZhdspNKHnoxCzhtynttu 3 X-Gm-Gg: ASbGnctckEq/twSbSD2DsG40mioU0Cm8VmyAECtu47qOFbW8WX3zeg/i/D+WjjLwPpI F6pnRv5DyBiUHoXV1nVpN+KFCWahiBB2I+IfLP/t4NF6MJwIa127vTiizdcWZ8DNDK9xYSInbk4 427W9xqmXF1AQdwmQtEu6zFpZ50AqgCPoEPJSpN18z6updWlN6AnzxLXdxTRuJqSlFtnNOcurL/ t5CIOfdXmHjOWlgheRmyLdaKDkgqNfthGbLiCkgMyiQxFrS9eI4hc9yhJlGbDSlOIoblxE4jhsU HYdV5ByB2reMLZVsRB9b5iBH/cOZ11d5qyzoG4u2CqlF9TnX7dOhDIs= X-Google-Smtp-Source: AGHT+IGPURTnMr02miProdqy6sJQjCwglzS51IyPoS1yC3iwi8sQwJ8SiFrixyM/TpmlQrI6TJMlQg== X-Received: by 2002:a05:620a:3193:b0:7b8:629a:69b8 with SMTP id af79cd13be357-7b9ba725121mr631052185a.17.1734719807519; Fri, 20 Dec 2024 10:36:47 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac480908sm158435485a.80.2024.12.20.10.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 10:36:47 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Fri, 20 Dec 2024 13:36:45 -0500 To: David Hildenbrand Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm: add build-time option to set hotplug default type Message-ID: References: <20241220144518.206208-1-gourry@gourry.net> <3775fe9c-460e-4b31-9d5c-068a1f685513@redhat.com> <2721ef36-abc9-4261-a4e2-d9f219ebd551@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2721ef36-abc9-4261-a4e2-d9f219ebd551@redhat.com> On Fri, Dec 20, 2024 at 07:25:57PM +0100, David Hildenbrand wrote: > > If you have another suggestion, I'm open > > I'd just do it like CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS, and simply do > > if (IS_ENABLED(MEMHP_DEFAULT_ONLINE_TYPE_ONLINE)) > ... > else if (IS_ENABLED(MEMHP_DEFAULT_ONLINE_TYPE_ONLINE_MOVABLE)) > ... > > No need for parsing strings and dealing with unexpected values. > onward to V3 :P ~Gregory