From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2054.outbound.protection.outlook.com [40.107.237.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CF141C3040 for ; Fri, 20 Dec 2024 14:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.54 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734706750; cv=fail; b=gcT6b/GhRgfL2AerXo6rm2tZ3YjtIYfo4Zw6kjXWP9WCrnE3rOUqfX7E9f+TRqphY0Sz1RNLHDREu7EpKEzYl11BAZTTr/ScnMGc8iiXynKdkDLwAhDeN60T/YDGUuh2T7M+vomd6Yr1EsD9mqIcc1U+WMlc+Xxlw1b8B9uhnVk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734706750; c=relaxed/simple; bh=bbbsRCCJtT8+LvwCDdhuSIhJMT0YLsDznyXIOytW1Kg=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=gr8jlf/QoddPHEMwR5/g24JUoa1eLM50xRhQKGi3ApHqChI1W/cjfr6itbFkxrpQWZdIB1mj0l4CHFFmoc2WRGq6nO1YED0Qf66hPPnKnVxxvIoXqr+ZH+nFCYPWbQ4UhvMyW3nVrE5DlSzunXyuxd2OtwscRGNUPBUW9OpSTto= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IZrnu5bd; arc=fail smtp.client-ip=40.107.237.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IZrnu5bd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RELmJmXnCJ0s6rD37KiC0G3wU4PGttQtCcLUNLPScExUIGI3sG2K553CSffZu0wRV0vj9OUm+dpjWrtMjNxp0gekb1MvBcyRC/VsahUtM9ofew2GDmmIEl0HPytwRMA1eDdSyZqMWZ8072XKBa7Sft2lzzxFZbYgAG7VyT3eAdajDlO7KQd4X6S8h49XrHSSm1Dd4o6tYJVtZjlX3It3Gk8aRZwdjqb5+R1RLKa3MdMJmYD7eqc7+ihy2tNsQd39r+u6Qp/e2q5n4RF8wyB3hBu3QUR8a6Qqv+amx1QBKogwJKM7iqI/iufzwV6aoOvpIH5zga+kwk9vDBs+DjqeAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=47BlwFrksqoThOTU7K6qBon/fnlQvyD6obSRJxBGvt8=; b=ZmETIQN5A3Gd7SxhSeqHgJUmS5zqjKm5tiSpvfJlITs5NOQgHi2GAyzSkTiLyW/4fNrCn06KBZ1PUZ92yyknqig354QWmKQckh/a2g9+5p7vcu77ImZs6wWX9V//fqQOyGObAA2Rtb3UqeBkcd344eeYeMHhHcqXp0wHxXp3O6uMKtboUJVzQyhP2yyLIg1Xy22G2lzSjS52p4afrJwSKAESouX3yY7oo0ll7CPlscExVykkgKs4hEPYXJKSIrtneUzGQbrG/bgzUxWQJ/HQ5fhY3PAtcnuD9tYnQ8nh/cqjUnGlbFEdA/eqaKQI+bDykSzq6kwgB9tJfDpzbZMo9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=47BlwFrksqoThOTU7K6qBon/fnlQvyD6obSRJxBGvt8=; b=IZrnu5bdEWOcnZMQfAx9BuXpy+8wyJkHvEhwGywbqD41yK2jHfWtNk2S4TBvU+adTt/EDQcZ4SiwggiVPB6x2CJEtzsDDBIoWBzf14YSwnSLjR0q0VdNJ+RlEwzaS5o2dC9xEcGqwsbTT0zBlAbjuU2X7BbHU/e7FsBj1tdDto17AcnOBc3Q62LoaViq6V87r8Avc4a5kMPnSK1xE7Q/PAwjs20AZFHa+Dw0bUzYmlSFBObtuUnApq8SlxdAybzy3B/tQqhI9zDU3vv9xNRfyAr3mZtWhQ+esgmltm067vBs27eX9dt6CYl4aXeL272ZEJsV/CLsSUAYZawDR4ZB4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) by SA1PR12MB5615.namprd12.prod.outlook.com (2603:10b6:806:229::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.14; Fri, 20 Dec 2024 14:59:02 +0000 Received: from CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5]) by CY5PR12MB6405.namprd12.prod.outlook.com ([fe80::2119:c96c:b455:53b5%3]) with mapi id 15.20.8272.005; Fri, 20 Dec 2024 14:59:02 +0000 Date: Fri, 20 Dec 2024 15:58:57 +0100 From: Andrea Righi To: Yury Norov Cc: Tejun Heo , David Vernet , Changwoo Min , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] sched_ext: Move built-in idle CPU selection policy to a separate file Message-ID: References: <20241217094156.577262-1-arighi@nvidia.com> <20241217094156.577262-7-arighi@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: FR4P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cd::18) To CY5PR12MB6405.namprd12.prod.outlook.com (2603:10b6:930:3e::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6405:EE_|SA1PR12MB5615:EE_ X-MS-Office365-Filtering-Correlation-Id: d1937e97-b43d-4700-5135-08dd2106d73f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?te5mSs3VFmNaNhlekEtIoIh1TbsbnQLBjVOZl7aShWBd7aGj5H8QE1KYP0rB?= =?us-ascii?Q?OUi6QRvW0X1T/62tEgrg7OmJdk+ln9dusABlK1FMV3ktbMnhGopmbvBWlBso?= =?us-ascii?Q?oLtoKbQ+R1IV0QABr5wkgjJqYTRRh7mgcH4+iCaUfrai+7FD9HAmnYlpX+Mi?= =?us-ascii?Q?0Z3ZBlsUA/wo92bijrL4feOkSSmQgIwmbuEYeXKqt0j7Zw7EQkNYn8p9eOg2?= =?us-ascii?Q?zbOli+peHwd9uzl67qLSy+xAkajeL0qYmcS5K77csOC+P7Y/gUBiPjJm63Hg?= =?us-ascii?Q?hjWe6dTY+gQRF+ASmnkXh2r0gnrli+a+D+rdv8L4aXKTcahr2meMxTv1ISY5?= =?us-ascii?Q?vmrY3XxIE9lVOBzr9RrNyh7WNEQW5O84LMMluhGLS18Pess4YcXL2WXnnfyy?= =?us-ascii?Q?/XVXtL0//crJkBZ/XIcEoRwIebxdA5QfWA6p+K9lTXBqF3zsT5mQAYjLGkpQ?= =?us-ascii?Q?M57ippLAr9aKCDXdMZi8/w9C0mUQkZNHn4mJpi9L4+kbyKUUm4tBmU3BGvVN?= =?us-ascii?Q?1v1WqZESmW2sMs33/pDYV0R8eXx2d1W53u2NLLFURr1QmDm/FT2Go7LYeRhS?= =?us-ascii?Q?Uk9EqbVJ0UtQZU/H2+ew+F9D9AnrsZNIrWRYIt7XR2fyvv/kvTL1cJ3OdcKo?= =?us-ascii?Q?MYkDSoUVykdqAdMYcm2X9i74umqgiEcY2/BRTIyMC3/8taesP+sP7jF/7XM7?= =?us-ascii?Q?UzNRtJO4w5sVDjd0P7oNVxpEsiy53oKcOfiyxGpzlX0Aq/1g4bBF6SA8W/dw?= =?us-ascii?Q?xNtt1RuQkw9SyJYSObk0eOzEBkle24p6EYpNgllJ0vW7UCdn7nC+WD49Ka+X?= =?us-ascii?Q?jxNzEGsTMUZDPe2+FCXX6s/AZw+agy2oQrm2wRJJeITQAM3lhgs4o6cYcCkA?= =?us-ascii?Q?otBpmAHgeY2+BoB3EBKATvx1pZS0WyHdMAFB3CIkwY4ygwVvtddPdILjjO/R?= =?us-ascii?Q?cYY+S0eJscVvbVFcj5Wk/yTYDfqDftiLeAcXbDZdm45Iy0gxlxkL4qSB9z0e?= =?us-ascii?Q?SgBSQ+ahZnT7/cZuxVv1D8WG4WbaorMhOUgJlxeJ3zI/JE0LrgAt6VgCZj/d?= =?us-ascii?Q?9ft8AcYh5D63z8VFuwszIq0NPoJkv7M0pU3TqgJSxBgw8YakCyaPDqGCFR/G?= =?us-ascii?Q?NU0Vo/TaWa4oj9QoE0YOkvC6A74Chtsk1HP+u8HLfiCva+nH271w1OsRMXCk?= =?us-ascii?Q?B12qgd5YDbAzEzcn5ZqLQi8/jadEnvw3B9hgHdD6+PShjnVxiEOlcApSSrho?= =?us-ascii?Q?/EfxZzYCYagYO74sNRUckBaSKuobqO+t3NBtEsJm9gZVox8K8P9pWXLJSfTN?= =?us-ascii?Q?A9nDzF4II0qr1foaChNK4W5aOE6ftvlUGaD0TuuIJeqTH3I3tXsikoP1aVwg?= =?us-ascii?Q?yCNbSHt47sq6DQrkRCsiYGI3BTy8?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6405.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bVf/B2xQCqy+yMVRXPe5lILhYFUcHHGAoFCSZITOgDOhEOzWEyXFfQp4hz4f?= =?us-ascii?Q?RMfzs8icMtIAc92wFoFOoZYBwLpYH+HHUCIFJ9aNxlEPcnYRglap3K1SC5CK?= =?us-ascii?Q?y7rXIW5ZMxx5pZX9YEsHJ8PbOipSnXTg7pAZsFgW1Zgp4HRf1XzJTE9X3D44?= =?us-ascii?Q?ePZnVPRSgP/BIfVmLEmCl7CejrsjB12qT5Av7o+aheVjtaKUZfljn8fkuGhm?= =?us-ascii?Q?XJVwO8go6QXRVg3Z//X6DFd+iAdNEGoS4ZlIXBlQ6I78KwIFNCM0rGvnBL7i?= =?us-ascii?Q?GdWbva8bOvZiZFn/tJ4a7+X+3suJVTZeM9IiOzlubB3gqAwOGKITxpUbGgNl?= =?us-ascii?Q?iPu7AMUFkuBoZ6br8vx9v9xVoHKtG6QyDeHTJ4rQUDdMeijlVgHV8iWi4dS+?= =?us-ascii?Q?/2bM8iL95pbbrClPaKbp+m7TOqYsdkuKWZTpBLUX7hrH2QitN5KNfFD4hjvq?= =?us-ascii?Q?VxItvJfJk9aks2/VM5RUALGzyjiyF2e2o2Byr8aao0zFV3H5uiKaWPFEXRf1?= =?us-ascii?Q?506xVb0L5evQsT7UxCqMZoEUuSEx8uETwXqKlLp9KO5asX3uHIPdN+ZlIBLo?= =?us-ascii?Q?qii4rJSQnAq68MWjUQSaojpGbHfSaxIaW8AxPaEoJdMCnUzPSi1QamKZBCqE?= =?us-ascii?Q?/2fVFI46K2P7CqzMZztgUSiOUoc906Rr+8Mn1HYWiTqrA6M5A7CZwlI7MVju?= =?us-ascii?Q?wGKWM2U45AcgMQJgSYZ+li3mDV0201Nhp98PZpVa0m7mU3suR1q1FDRP0kbK?= =?us-ascii?Q?i8FQ4qmLEOmADhIsBBfqv03LeaI6VJ2neA3pwe2uwtQK4MENSh7k2MaUpC1B?= =?us-ascii?Q?wSqzBhR3vmOWJHGsUKFx89yyzFxgtuUqqi1mUROU8ppsDz2uZN7XPK1vsGz6?= =?us-ascii?Q?NH28Gm/6npZx+3+gJJlR23nCupP0ov0i+zEzBSgET5l3TK6eU2LuvTVZuKT0?= =?us-ascii?Q?OV9p35y1/pghjqPqOBjFyUV9cQhxmlsRF0HzD736CLbWSyrtfxjTaUdKzl1E?= =?us-ascii?Q?dZA/CgTcDMxX/JrUYTq+mAuzDOh09s7wbs2gyRcrNnOUSsyNRVZYJJxfRgB7?= =?us-ascii?Q?Xs/pqChVh3RR4HRUk+NPfhc1nXo8B1WyGqSrtcijto0zBlf8g6eDfwLBbRHL?= =?us-ascii?Q?M/WuBlpqB49ieXpmVp8Kgc2GILjU3r2EVWuknxxop7nQ9R9TIyPjKo9LPO1S?= =?us-ascii?Q?CZcWL0TnCBUf3pUUNZVerEyhlCbgq6I9qJdX1EbwAxOvZ+Zn0Lrx0mXqFagg?= =?us-ascii?Q?uqUKI/BdcC4bju4h5Ot6Nued6AwoQcafMb720bpeWgEsxH4r2i/Qnndz/qE6?= =?us-ascii?Q?aA/ANii91LDh9oHl1ERmkeBZVkf6ic3OqsaOzjHvSEZMUdCWiyK7rbgIoHf0?= =?us-ascii?Q?sD/lQz6YAzjgcntM0OTsO8F5b2CEYQm1umz33GDs8zEvNAp70yQZjOmNUe8w?= =?us-ascii?Q?K/Z2CBQU9K9OZ14kL9fud8QHQsSAiZi7mFa2yiDVAJ5sTvV/fmArKk+qiZw4?= =?us-ascii?Q?24tk1PdkvR/1JkhR39y8pqO59XQrfoo4vFqVGLorqnx/dMHxPwdMyiGViZt+?= =?us-ascii?Q?i7CuY6wotlqpqCeWkbo9n0ft0Ty0WK/HQf4EXgu4?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1937e97-b43d-4700-5135-08dd2106d73f X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6405.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2024 14:59:02.2442 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dpkqIT5RfaqksTxEcRqEG0lGhAFgpUUS2GjfENhMzRv7IEQ1JdPPs4N8457EfFMAbuUmsUqTIV8QSBjxECwyig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5615 On Fri, Dec 20, 2024 at 06:53:28AM -0800, Yury Norov wrote: > On Tue, Dec 17, 2024 at 10:32:31AM +0100, Andrea Righi wrote: > > As ext.c is becoming quite large, move the idle CPU selection policy > > to a separate file (ext_idle.c) for better code readability. > > > > No functional change, this is purely code reorganization. > > > > Suggested-by: Yury Norov > > Signed-off-by: Andrea Righi > > I think it should be a preparation patch at the beginning of the > series. The one major downside of patches of that sort is that when > moving code, you wipe git history. If you have to do that, you need > to move code before doing the work, such that at least your updates > will be accessible to git blame. Right, I've already moved this at the beginning. :) I'm re-running the usual set of tests and will likely send a new patch set if everything looks good. Thanks! -Andrea