From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Prabhakar <prabhakar.csengg@gmail.com>,
Chris Brandt <chris.brandt@renesas.com>,
Andi Shyti <andi.shyti@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Wolfram Sang <wsa@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v2 0/9] Add support for I2C bus recovery for riic driver
Date: Fri, 20 Dec 2024 22:28:57 +0100 [thread overview]
Message-ID: <Z2XhmWiocC8m3JTY@ninjato> (raw)
In-Reply-To: <Z2Vc61czIYHHNMI_@ninjato>
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
On Fri, Dec 20, 2024 at 01:02:51PM +0100, Wolfram Sang wrote:
>
> > This patch series introduces support for I2C bus recovery in the RIIC
> > driver, which is utilized in RZ series SoCs. The addition of bus recovery
> > functionality enhances the reliability of the I2C interface by allowing it
> > to recover from error conditions that might leave the bus in an unusable
> > state.
> >
> > Alongside the bus recovery implementation, the series includes several
> > cleanup and improvement patches that simplify and modernize the driver
> > code. These include replacing `dev_err` calls with `dev_err_probe`,
> > consistent usage of the `BIT` and `GENMASK` macros, leveraging devres
> > helpers for reset management, and improving code readability by marking
> > static data as `const`.
>
> I am planning to review and test this series later today.
Thanks for this series! Regarding the cleanups, rhe driver is indeed in
a better shape afterwards. Good work. Patch 9 still needs discussion but
for patches 1-8:
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On a RZ/G3S, doing bus scans and some transfers with checksumming.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-12-20 21:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 0:16 [PATCH v2 0/9] Add support for I2C bus recovery for riic driver Prabhakar
2024-12-18 0:16 ` [PATCH v2 1/9] i2c: riic: Replace dev_err with dev_err_probe in probe function Prabhakar
2024-12-20 21:17 ` Wolfram Sang
2024-12-18 0:16 ` [PATCH v2 2/9] i2c: riic: Use local `dev` pointer in `dev_err_probe()` Prabhakar
2024-12-19 12:21 ` Andi Shyti
2024-12-19 12:44 ` Lad, Prabhakar
2024-12-19 21:08 ` Andi Shyti
2024-12-20 21:18 ` Wolfram Sang
2024-12-26 1:19 ` Andi Shyti
2024-12-26 7:39 ` Lad, Prabhakar
2024-12-26 10:06 ` Andi Shyti
2024-12-18 0:16 ` [PATCH v2 3/9] i2c: riic: Use BIT macro consistently Prabhakar
2024-12-20 21:19 ` Wolfram Sang
2024-12-18 0:16 ` [PATCH v2 4/9] i2c: riic: Use GENMASK() macro for bitmask definitions Prabhakar
2024-12-20 21:20 ` Wolfram Sang
2024-12-20 21:21 ` Wolfram Sang
2024-12-18 0:16 ` [PATCH v2 5/9] i2c: riic: Make use of devres helper to request deasserted reset line Prabhakar
2024-12-18 13:30 ` Geert Uytterhoeven
2024-12-18 0:16 ` [PATCH v2 6/9] i2c: riic: Mark riic_irqs array as const Prabhakar
2024-12-18 0:16 ` [PATCH v2 7/9] i2c: riic: Use predefined macro and simplify clock tick calculation Prabhakar
2024-12-20 21:23 ` Wolfram Sang
2024-12-18 0:16 ` [PATCH v2 8/9] i2c: riic: Add `riic_bus_barrier()` to check bus availability Prabhakar
2024-12-18 13:31 ` Geert Uytterhoeven
2024-12-20 21:26 ` Wolfram Sang
2024-12-22 4:16 ` Lad, Prabhakar
2024-12-18 0:16 ` [PATCH v2 9/9] i2c: riic: Implement bus recovery Prabhakar
2024-12-20 21:16 ` Wolfram Sang
2024-12-22 4:12 ` Lad, Prabhakar
2024-12-22 12:44 ` Wolfram Sang
2024-12-23 6:35 ` Lad, Prabhakar
2024-12-26 1:21 ` Andi Shyti
2024-12-27 11:27 ` Wolfram Sang
2024-12-27 22:05 ` Andi Shyti
2025-01-06 17:45 ` Lad, Prabhakar
2025-04-16 7:43 ` Wolfram Sang
2025-04-16 13:04 ` Wolfram Sang
2024-12-21 9:13 ` Claudiu Beznea
2024-12-22 4:14 ` Lad, Prabhakar
2024-12-20 12:02 ` [PATCH v2 0/9] Add support for I2C bus recovery for riic driver Wolfram Sang
2024-12-20 21:28 ` Wolfram Sang [this message]
2024-12-21 9:42 ` Claudiu Beznea
2024-12-26 1:24 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2XhmWiocC8m3JTY@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=chris.brandt@renesas.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).