From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: lib/gf128mul - Remove some bbe deadcode
Date: Sun, 22 Dec 2024 11:54:49 +0000 [thread overview]
Message-ID: <Z2f-CXgNGkstB4ds@gallifrey> (raw)
In-Reply-To: <Z2eTGr3l-Zu_Tgi3@gondor.apana.org.au>
* Herbert Xu (herbert@gondor.apana.org.au) wrote:
> On Wed, Dec 11, 2024 at 10:02:18PM +0000, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > gf128mul_4k_bbe(), gf128mul_bbe() and gf128mul_init_4k_bbe()
> > are part of the library originally added in 2006 by
> > commit c494e0705d67 ("[CRYPTO] lib: table driven multiplications in
> > GF(2^128)")
> >
> > but have never been used.
> >
> > Remove them.
> > (BBE is Big endian Byte/Big endian bits
> > Note the 64k table version is used and I've left that in)
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> > include/crypto/gf128mul.h | 6 +---
> > lib/crypto/gf128mul.c | 75 ---------------------------------------
> > 2 files changed, 1 insertion(+), 80 deletions(-)
>
> Patch applied. Thanks.
Thanks! I'd appreciate if you could also look back at one
from September:
async_xor: Remove unused 'async_xor_val'
Message ID: 20240929132148.44792-1-linux@treblig.org
Thanks again,
Dave
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2024-12-22 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 22:02 [PATCH] crypto: lib/gf128mul - Remove some bbe deadcode linux
2024-12-22 4:18 ` Herbert Xu
2024-12-22 11:54 ` Dr. David Alan Gilbert [this message]
2024-12-23 2:53 ` Herbert Xu
2024-12-23 12:21 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2f-CXgNGkstB4ds@gallifrey \
--to=linux@treblig.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox