From: Vinod Koul <vkoul@kernel.org>
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
sanyog.r.kale@intel.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, venkataprasad.potturu@amd.com,
Mario.Limonciello@amd.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH RESEND] soundwire: amd: clear wake enable register for
Date: Mon, 23 Dec 2024 11:38:21 +0530 [thread overview]
Message-ID: <Z2j+VQ4BPjr3HXsX@vaman> (raw)
In-Reply-To: <20241203091006.4096890-1-Vijendar.Mukunda@amd.com>
On 03-12-24, 14:40, Vijendar Mukunda wrote:
for...? Pls write the full subject
> As per design for power off mode, clear the wake enable register during
> resume sequence.
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> drivers/soundwire/amd_manager.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
> index 5a4bfaef65fb..96a3aa6da711 100644
> --- a/drivers/soundwire/amd_manager.c
> +++ b/drivers/soundwire/amd_manager.c
> @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev)
> if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) {
> return amd_sdw_clock_stop_exit(amd_manager);
> } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) {
> + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance));
no need for 0x for a zero value
> val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL);
> if (val) {
> val |= AMD_SDW_CLK_RESUME_REQ;
> --
> 2.34.1
--
~Vinod
next prev parent reply other threads:[~2024-12-23 6:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 9:10 [PATCH RESEND] soundwire: amd: clear wake enable register for Vijendar Mukunda
2024-12-03 9:23 ` Mukunda,Vijendar
2024-12-23 6:08 ` Vinod Koul [this message]
2024-12-23 6:13 ` Mukunda,Vijendar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2j+VQ4BPjr3HXsX@vaman \
--to=vkoul@kernel.org \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=sanyog.r.kale@intel.com \
--cc=venkataprasad.potturu@amd.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox