From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03DFB3987D for ; Mon, 23 Dec 2024 06:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734934996; cv=none; b=BsK18V+ibSSaUU2q6PG0Oj3+g63Y1eJoKIGeYVFYOo1pXmrEezKgJEQep7+frCwu4mA3cjakBIEUEj2UywFqKFCO8u0zOsk0mRl6BAUwdtFn0CPCaFVjn/f4kOKawz2L3ymEt3wT3PYW8Q1bLrJTmeXLLlgFHnT4G8V2e48EAXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734934996; c=relaxed/simple; bh=OGS5qBtJK2WByTsQU3Z8m7w6pUSMMuWMvb5Fns3QsZs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dGDRyRaBPesLSqaADOmdG9m+OIR8e7NIctP83OhHDrnAjTSz42a6P7RU3uk6JP++j1S9GLyxD/qU8KPycm6pQMAlYhhTLaI6OP5d66MRVOj1ipHbwoEszxs4YHQQ/dYRHATwTBDzADwrL7ui1RaTjDGiG9S2O3JyEgnDY6voiyI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPbqK-0003I4-UY; Mon, 23 Dec 2024 07:23:04 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tPbqI-004p3r-22; Mon, 23 Dec 2024 07:23:03 +0100 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tPbqJ-00GB8e-0y; Mon, 23 Dec 2024 07:23:03 +0100 Date: Mon, 23 Dec 2024 07:23:03 +0100 From: Oleksij Rempel To: Kory Maincent Cc: Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni Subject: Re: [PATCH net] net: pse-pd: tps23881: Fix power on/off issue Message-ID: References: <20241220170400.291705-1-kory.maincent@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241220170400.291705-1-kory.maincent@bootlin.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Fri, Dec 20, 2024 at 06:04:00PM +0100, Kory Maincent wrote: > An issue was present in the initial driver implementation. The driver > read the power status of all channels before toggling the bit of the > desired one. Using the power status register as a base value introduced > a problem, because only the bit corresponding to the concerned channel ID > should be set in the write-only power enable register. This led to cases > where disabling power for one channel also powered off other channels. > > This patch removes the power status read and ensures the value is > limited to the bit matching the channel index of the PI. > > Fixes: 20e6d190ffe1 ("net: pse-pd: Add TI TPS23881 PSE controller driver") > Signed-off-by: Kory Maincent Acked-by: Oleksij Rempel Thank you! -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |