Re: [PATCH 04/10] sched_ext: idle: use assign_cpu() to update the idle cpumask

Yury Norov
2024-12-23T22:26:50Z

On Fri, Dec 20, 2024 at 04:11:36PM +0100, Andrea Righi wrote:
> Use the assign_cpu() helper to set or clear the CPU in the idle mask,
> based on the idle condition.
>
> Cc: Yury Norov <yury.norov@gmail.com>
> Signed-off-by: Andrea Righi <arighi@nvidia.com>

Acked-by: Yury Norov <yury.norov@gmail.com>

> ---
> kernel/sched/ext_idle.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/kernel/sched/ext_idle.c b/kernel/sched/ext_idle.c
> index 0e57830072e4..dedd39febc88 100644
> --- a/kernel/sched/ext_idle.c
> +++ b/kernel/sched/ext_idle.c
> @@ -460,10 +460,7 @@ void __scx_update_idle(struct rq *rq, bool idle)
> return;
> }
>
> - if (idle)
> - cpumask_set_cpu(cpu, idle_masks.cpu);
> - else
> - cpumask_clear_cpu(cpu, idle_masks.cpu);
> + assign_cpu(cpu, idle_masks.cpu, idle);
>
> #ifdef CONFIG_SCHED_SMT
> if (sched_smt_active()) {
> --
> 2.47.1