From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2073.outbound.protection.outlook.com [40.107.103.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3576C1D7E50 for ; Tue, 24 Dec 2024 13:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.73 ARC-Seal:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735045653; cv=fail; b=CRHQFsqiKi1wpkIfOlygjOvX1au6g7ejCCI8zBK1+xkZkvSD0QpfkmfDCqKBGAbXrnnPktoQ6JId8eiCd7EBaXU9KlrIJrthHJ3iZw0TZ5NSRbGVCigZEHLGlJCdfDprbkXc29W4Hih1VRJ0LGqNWUlAQvsI0hC8OGrDHn9ROM8= ARC-Message-Signature:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735045653; c=relaxed/simple; bh=xwKmDy5hcu7Ttt8Zy6lbGpo5iXJ/Xq8TV94xpeB/SFc=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=XOVWkKhfCklULQOEr+Ez6NGgzbhEGKJtDYXHAY+lmiXP0yAzU6XVi0XmA8p15OGcnCQMjCaKzKwsGldSpcN/RlXcGMT411gVxV6XCwZbCgeh4UTNRi3LdJ87OUV7AU9Mzb5oC79ArVfYc59HdvtXoSoGmywKJ5ZpFO/ccOk8GKY= ARC-Authentication-Results:i=3; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=D+WprKXH; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=D+WprKXH; arc=fail smtp.client-ip=40.107.103.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="D+WprKXH"; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="D+WprKXH" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=fasUGOqFLrKIrQgz6W70pdLRB7OeP8iUfLuKU86+loegWit25kT5kp9rE0jlUndjG36FWZrdEKAsqr2kVl1SviNKvrSG+q6mVMpP3j9U6z6x4XgnF9EH+9rlE9qZL3siXpVgMk/0Zc43h6Y1OTCzzIQR06nNt+TLTxtlknSFNzzwPX3V+6Xb3/tO6GeiRD9LN8x0Nybd3iM6ZEEOKIG2y2ZZODtPIrXS7gpeB+N8gxNvqppQZC1bPWhCHJV4EWgEQVO5XYqZ6GhV7wcoIrXf+b8egJzkfni+NCTgwgRzpBCr/4YbT3LQfWKnsfqOvO3Hu5jD90GqZ4BkFKGsCDm4wQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5UwpPAFj2nynQYsSn9iOw06xQFqiq92YoLtaFHkezBQ=; b=R5OkScRL4gN9p2rKAK5i4ELaD/2mRFyzqnoLEmJW+ukGX2+WzSmachPiS5D56mRtCyZtW9IZXJro//Ptl0qIQUvlCsROzOHOEQoW9/RbH5lvkKyyUj2Ehg7j6WKBFUKamn75gvPTR1E+aoD1Y6CUlbnVYNOGb/+VslrGlS25qyItg4skhYSHFsjX8ng9HsZjMq6t93fMFNp53+Oqy3pyXT5K2Q0jWWMI855GzJbNm26MufyLZNYKpw4/CLGh9Pda2XP2jcp8DYqMGrv6h1n7V4B/OCN/lOwNvRBHWPjGlsdsnhx6CMbBErBt7mdM7y5b+Db+6ZqYhRXnwLP1t1Vctw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5UwpPAFj2nynQYsSn9iOw06xQFqiq92YoLtaFHkezBQ=; b=D+WprKXHg3P4I1b+6gCTpM7CRzt9YnbKOLMJB8dOyjlxtJw+2Nsxgpf7WegQDKnYGfh+y9Sofe19NZDIDqfMfxq4BJK9W3w5T7uNw21RLDOKyU3mC2g4z+wFbsv/iuV43RH2N/ezLckn2bz+Acv7iw43IIlEL5nGYgWG0cPvKBE= Received: from DUZPR01CA0131.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bc::16) by PAVPR08MB9817.eurprd08.prod.outlook.com (2603:10a6:102:31d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.20; Tue, 24 Dec 2024 13:07:20 +0000 Received: from DB1PEPF00039230.eurprd03.prod.outlook.com (2603:10a6:10:4bc:cafe::85) by DUZPR01CA0131.outlook.office365.com (2603:10a6:10:4bc::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8272.21 via Frontend Transport; Tue, 24 Dec 2024 13:07:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF00039230.mail.protection.outlook.com (10.167.8.103) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8293.12 via Frontend Transport; Tue, 24 Dec 2024 13:07:19 +0000 Received: ("Tessian outbound 7762b28e8285:v528"); Tue, 24 Dec 2024 13:07:18 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 444f25eff68942a8 X-TessianGatewayMetadata: wf0n/nMiGkV2aX3UZ8yLHPd/FSymWuklM0We0cICwRprFtR3AvqxHOmX4XpZilLEBFYSSb9n4EUrTlezgYewjmpXSclV7rfESyIXgal066NSnRCuh8WI4S3QZ8kGvxWmn8ej1c6MK7/8cfWC0dtQgQ== X-CR-MTA-TID: 64aa7808 Received: from Lef9af36d66f7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D254245B-333C-478A-885F-7E5A433D12AE.1; Tue, 24 Dec 2024 13:07:11 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id Lef9af36d66f7.1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 24 Dec 2024 13:07:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JJFaF6a/ALr9/XNIiLpSfzra/qDMtl9zNeXJtjq7MCGhtzqleXDYMlryEBtwEdmkDYgwHkduhs7kHMbDhoJKvI2yP91ZSARusjH1rlTIhhOfsjBa+RDtddzksIIkfBquzW2Rf3mtQniKR1kmSIfvuVVJ96ZQ9lTvxXvjUdHmOttU6X3o1QLK1MmczsUy46hA/MnSTUHCXtgBmKyU8vYDAAtknKwREZMM5lTyPUlx8qK1dUr5ZGKd8HDE/DZUEgE8C6IK1/GHUDKwI9LmGdWTe0jBX9Xgg0fQ8eTsOXg7AhEGOmHPnaT1R4I1sTK9ybBL67A296NGOQ39b2SEHSgWdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5UwpPAFj2nynQYsSn9iOw06xQFqiq92YoLtaFHkezBQ=; b=V5AG9bfDlxZQq3Y/iDASnuP60+f/Db0hQlBCzL8T+it27oIDCAXWWLCG2Mb8lC2d1smQGxTXc1HTxMu/KIho6Wg/oTRjWjTWi+xFQbMW0DJmBdyOXNO81+L6gX/YKVmfLAzhnOHZr2J4Xf3VoOFIrQBSNpkJvg0WgCYvKJNrp3CFTyNZ7WXKecc5OpQ1SxIQYzNGn0B0pYcHHXV8W+GMO3lUOQya2rOxQSTxkS/KrXH64JZlQSid/qSdV2clhBrawqqr0qwHhBBL/gv1C/7NAQyurctLYCS333yuiLvjnpjgDgKYwYLRtNEEJXqtTmRX+1+MA56NgFdy7pxZiklXow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5UwpPAFj2nynQYsSn9iOw06xQFqiq92YoLtaFHkezBQ=; b=D+WprKXHg3P4I1b+6gCTpM7CRzt9YnbKOLMJB8dOyjlxtJw+2Nsxgpf7WegQDKnYGfh+y9Sofe19NZDIDqfMfxq4BJK9W3w5T7uNw21RLDOKyU3mC2g4z+wFbsv/iuV43RH2N/ezLckn2bz+Acv7iw43IIlEL5nGYgWG0cPvKBE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from GV1PR08MB10521.eurprd08.prod.outlook.com (2603:10a6:150:163::20) by VI0PR08MB10584.eurprd08.prod.outlook.com (2603:10a6:800:1b8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.20; Tue, 24 Dec 2024 13:07:03 +0000 Received: from GV1PR08MB10521.eurprd08.prod.outlook.com ([fe80::d430:4ef9:b30b:c739]) by GV1PR08MB10521.eurprd08.prod.outlook.com ([fe80::d430:4ef9:b30b:c739%4]) with mapi id 15.20.8272.013; Tue, 24 Dec 2024 13:07:03 +0000 Date: Tue, 24 Dec 2024 13:07:00 +0000 From: Yeoreum Yun To: James Clark Cc: Mike Leach , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nd@arm.com, suzuki.poulose@arm.com, alexander.shishkin@linux.intel.com Subject: Re: [PATCH 1/1] coresight: prevent deactivate active config while enable the config Message-ID: References: <20241218084833.609876-1-yeoreum.yun@arm.com> <0efe4ef1-30f5-47f8-b818-79b4cfa0891f@linaro.org> <79e11033-181a-418a-a56f-068b9ca62f56@linaro.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79e11033-181a-418a-a56f-068b9ca62f56@linaro.org> X-ClientProxiedBy: LO2P265CA0218.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::14) To GV1PR08MB10521.eurprd08.prod.outlook.com (2603:10a6:150:163::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: GV1PR08MB10521:EE_|VI0PR08MB10584:EE_|DB1PEPF00039230:EE_|PAVPR08MB9817:EE_ X-MS-Office365-Filtering-Correlation-Id: 592c081c-3eae-4543-7e7d-08dd241be58e X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info-Original: =?us-ascii?Q?Newf/sOcFj8J5hazWCYfwCS1K9kb0VgWIT3HfdrQDWl8q3zSED/+ho5/W0V+?= =?us-ascii?Q?3aeeApyRd81kMnyOaOGfVpwxbY0Q8Rs71MIBphS9voEak6k7g2g//xAL3rAl?= =?us-ascii?Q?TeLA2GN/vLB08GU3LsUB1tAel8kaoeGrMzplk0slkTxUfidAJPYsBgJVRr25?= =?us-ascii?Q?cfZBou+jqz+KjSF8X2zQ662EbcDz4Dxoa1g2XVu4UlTkbURSIqKFRUUseH+c?= =?us-ascii?Q?zefdzb2HpNfIa9IafnMXmJwdYvNTpGu0CHD439rXIu7i+lQGlEOwse22esjh?= =?us-ascii?Q?4WPUg8bdOFHYUoK6UarsCVdOFO9UV18Rp4V6keHr9njwKPzafBH/hE9ZFIMG?= =?us-ascii?Q?LGWQnShIGmnATyK+LRS/bHmddymdu9rq244Eo+QfB7i6hen+T9UEX5L8nmCK?= =?us-ascii?Q?kkAA/B4ujdWBie8o1BEgruGTSkEF43vDAklWzc/Y+T53Fy5B7IjoYN5jcnk9?= =?us-ascii?Q?U1NI0FfeJPwwVloXILvMl/vKstCYuVn8EGTbQGrddDfc0NrUGSloZ9m7Tbxq?= =?us-ascii?Q?sXrteoeB2NXHmklOyokWomhDPpzgRLKuz/k7Gv505VUSauEgjSK8FtjAZ+FJ?= =?us-ascii?Q?Qu0bjN6Fs9kPQ0B+QH7ctiIFD2mYoucbY/NG07PcWgbyUxkjOdhUtNwKDz9F?= =?us-ascii?Q?Y7qs1IPx4RlXlvulROAHPq/YntKcR4IvPjPUEUOtyuIdfRFkTRa+dsZNhflm?= =?us-ascii?Q?eS2R9Mm69n1WxmoVl37s0IHgo2z03Fc2nnaC6oPeUd48MsHcnsB+zSLSnrXg?= =?us-ascii?Q?puxBnvPsPzy599rJYu1N+4LPqIIT9Qj+XQF2L/AGz8Qw+XqTEha8M/cMxsWS?= =?us-ascii?Q?4bvecWcUIy4CKBGcg6BtQPpisJqsBhhFNMMFnsA8Bm3YioMPgWWGnoEN5vrA?= =?us-ascii?Q?2RwSZgizsWZPLuLtJcK2grRTtaJBaZXXh/STC6Ll/2Wa+SZ4FnuNmVKLmrBh?= =?us-ascii?Q?eYLgw1STsJuykPQh6pX5Je+UtcE1TQ9djIeyu5sohkujgIJAwRM7rm0C+Wa7?= =?us-ascii?Q?DOL4CjvWDMhWxy5hzNCKN1o+qDOtLXKqnHD0K+ME8eSo6Enn5w+H/4ttcwh7?= =?us-ascii?Q?Utusb20VnEskKPRqw5nltXotHP4BuaQYBWXlwivCsFGUUd90dTtzbYR0bz1t?= =?us-ascii?Q?TwIQIMFLqpdtlyfhNi7lzuddSQfcBZX4KIsmGniRdOOv8xyhacUUoMjoykBk?= =?us-ascii?Q?+nPOgNOXtQxh84Xg4iRS1XbHEmDSbJC3X8KU6JYUg0D0g1rVp2wnEP4IhfOP?= =?us-ascii?Q?d5h6UFntil+dyAXK8HJ8+GtX+k3VwhL19xtmOtG01o6PygtbMis2KCbExA2U?= =?us-ascii?Q?vGIyff8dvbtOVvple0I/RLudgrbtiDwn4MdnqyrFiRJsRh+ESc6cv3GDNkgt?= =?us-ascii?Q?QfZe9vi9xV2oHwsmNl9qy7FAEIB/?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR08MB10521.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10584 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-SkipListedInternetSender: ip=[2603:10a6:150:163::20];domain=GV1PR08MB10521.eurprd08.prod.outlook.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF00039230.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a020bdfc-a2e2-4612-13bc-08dd241bdc04 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|14060799003|36860700013|82310400026|35042699022; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/q5zhbaPynkMO/VuEC/fY06fb5htViVlyyJLdljxNBj8Mp9McE7SX/wZee7T?= =?us-ascii?Q?4YBfjHtpbhyYJ9GbXlD4nj4GJXC9PlyUZxQy/8l7jw2d8GOVnpMJUJM0gG4+?= =?us-ascii?Q?6ONza80Se2KwWOHvUoOhl9C6GIa2MHt9Q03YtdnQ50qAp8JpcoWDTe0yL5wD?= =?us-ascii?Q?GmjapKsW3BLn8uEGYX3bfoVTegTBK8ERsaObqLSHqjE5gyGC3Bv6FaL8aabI?= =?us-ascii?Q?LJHrk4JG2+kmGKQSsJAfh+1aLCRqhSurMdChdyJrB/FnHEUrvI57uf5nRUDz?= =?us-ascii?Q?Ovc4M2wlMFbJ505cFeVravuH9gXOLiFXceuWwDKvXPOxZ07bw4ozszGZ5Dvy?= =?us-ascii?Q?/l86ZOPxsQ6/jOANoC0DfWz55rqB0FTBDVgL4QbG1+Ix3+aiGqCSx99Jl+Wj?= =?us-ascii?Q?r0tF0WdwNW5xtFDIixVLEh/+1Q6+fMxA8t44q4iRKO+x+qqie91WuUuc7bPl?= =?us-ascii?Q?mH9TFOEPQUBYzEayHmC22seLngj0BddGAA92V11ZYYqYvFM0EvJL7XJIFXMI?= =?us-ascii?Q?fPvgTwcEwOSBKThkwDbbCDHAhRHaZGoJY1N0M+m3jGNeR58YyjBIDQRkn3AL?= =?us-ascii?Q?NZvEMvI6gMYJcbVsGmCcIi+CW83oNe9KJR5H+4UOI85LRjI45HOFK1tNAErI?= =?us-ascii?Q?fmQXtlyp9cZFpPaeHxVIeBey4a89u/7XZm1KicP5VcAd05VrtDRtyRnSyEdW?= =?us-ascii?Q?oFNcIIdVhN0x66jCudWwDuCPdbxw1NVPy+jgy1KPj9Z8fe63pYQzILn7rny1?= =?us-ascii?Q?qRz4KNqa3pmwypYBvlUVFWaAoIKC2sBFWQkQmIG3w2krFT1UDn5inS6nazGs?= =?us-ascii?Q?nJs5q2mrCIGR5306JXFHyCb16rG0SoVxacj3Gz0vjpaupMPeb4XM83tFJUD6?= =?us-ascii?Q?UNjt+7Q+baodirqFoVuccsRSFrKNGHNL123NAqtTr4QPQwjfpwaihBYkPYOC?= =?us-ascii?Q?v6WfXOxlDF1fHOcjBXk2ZDIGJ9bvDq1Bzq+110DRgF9ttyp84LCHmEd8Kd0k?= =?us-ascii?Q?6iEM463Pxjmriqy5NmQnbHCiSIYvZOQ5peb8/ntFkPA9w7P8ysU5JG3Ep4TV?= =?us-ascii?Q?I1fGeZ3t0FpUpZbAvPvzwZ3F92zj0p++Kqerux10krvQal82jhZlxpwrqTUX?= =?us-ascii?Q?ByC8m1ea+iXfjjnmuDb+TIC88+Ok35hP8gSAN0TcVWqfRhU0oSN0Fvfe0gSn?= =?us-ascii?Q?ffIdOlL7hFKAuy0AT7SElHQOPl6pu8zX47JdijMwprw1mHU5Wb8s2QYQn9ar?= =?us-ascii?Q?IIwKmrHeYiW80P51u1V5+hThhHx7jT8+HbM9kopNBqhePwMgqQPjI8ylgayM?= =?us-ascii?Q?RJ1BEUXPhMpe8w9B94zpvvSyUDJcMvGOZaIjNu6/nQTQOdMCoBlfgWeWdEKD?= =?us-ascii?Q?ZOVKPSWPoGhVBDUutmxtFAfo7TmhuQExxjCdKSmfiY/DrOFkP9nwOwNvDVBn?= =?us-ascii?Q?vjceMIQaouD7P6oPE6VSz8IzWtREijO2HIWk0kHlQORazecNVAD0ZvVE2qfB?= =?us-ascii?Q?CkLYOANys053Fhw=3D?= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:64aa7808-outbound-1.mta.getcheckrecipient.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(14060799003)(36860700013)(82310400026)(35042699022);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2024 13:07:19.0516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 592c081c-3eae-4543-7e7d-08dd241be58e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF00039230.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9817 Hi James, > > Hi James. > > > > diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c > > > > index a70c1454b410..dfa7dcbaf25d 100644 > > > > --- a/drivers/hwtracing/coresight/coresight-syscfg.c > > > > +++ b/drivers/hwtracing/coresight/coresight-syscfg.c > > > > @@ -953,7 +953,8 @@ int cscfg_config_sysfs_activate(struct cscfg_config_desc *config_desc, bool acti > > > > cscfg_mgr->sysfs_active_config = cfg_hash; > > > > } else { > > > > /* disable if matching current value */ > > > > - if (cscfg_mgr->sysfs_active_config == cfg_hash) { > > > > + if (cscfg_mgr->sysfs_active_config == cfg_hash && > > > > + !atomic_read(&cscfg_mgr->sys_enable_cnt)) { > > > > _cscfg_deactivate_config(cfg_hash); > > > > > > So is sys_enable_cnt a global value? If a fix is needed doesn't it need to > > > be a per-config refcount? > > > > > > Say you have two active configs, sys_enable_cnt is now 2, how do you disable > > > one without it always skipping here when the other config is enabled? > > > > Sorry to miss this one!. > > Because when one configuration is enabled, > > cscfg_mgr->sysfs_active_config becomes !NULL, so it wouldn't happen > > there is no two activate configurations. so sys_enable_cnt wouldn't be > > 2. > > > > > > > > Maybe "sys_enabled" is a better name then. Count implies that it can be more > than one. And the doc could be updated to say it's only ever 0 or 1. I think I'm not fully explained. sys_enable_cnt could be more than 2 if it runs with perf and sysfs both. Because, perf uses cscfg_active_config() to activate configuration. but, "sysfs" only can activate 1 configuration because it enables with cscfg_config_sysfs_activate(). so the sys_enable_cnt could be more than However, sys_enable_cnt can be increased only 1 by sysfs interface. Maybe It could be hinder to disable by enabled activated by the sysfs. However, That's wouldn't be critical. > > But what about my other point about enabled always being a subset of active? > Can we not change "sys_active_cnt" to a more generic "refcount", then both > activation and enabling steps increment that same refcount, because they are > both technically users of the config. Then you can solve the problem without > adding another separate counter. I think that's potentially easier to > understand. Actually, I think merging this two count (or with module ref too), seems increasing commplexity right now. To make clear It would be good However to fix bug for above case, I think it's enough to add sys_enable_cnt and I think it doesn't loss its name meaning and it seems more to be backportable. > Although the easiest is just locking every function with the mutex (or a > spinlock if it also needs to be used from Perf). Obviously all these atomics > are harder to get right than that, and this isn't performance sensitive in > any way. Agree, That's why there's one option to merge cscfg_mutex with coresight_mutex. But I think this is too much to fix this problem. Thanks.