From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AACE129A78 for ; Tue, 24 Dec 2024 19:04:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735067094; cv=none; b=CMig9ZAYjxfq18ITSW/o2UNllSpruV32gd/+a6DSaXqr0K/O5MtYNoSZ5MyWaxw4qWPgplWD7P0MyZOyeGW+NMj2vYENoLuX+u+pQPzupVRAgzWQAPBtiQNWi8dFz9SZuEb5vxFjt7gTAuYv/I5ADFBQGVDDNjC01UV9StITTRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735067094; c=relaxed/simple; bh=y35Df4h8cW99KUsObzqKxOON8qVDMDNfiOTKQqYOH6w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n8xjuta6hCf+FlBhjMsrFZjrXe5NMTgrr6H36gcu8aiTgF7F4Rrtl20Au7PKFDerCWj3px2CETZI8Ue1GzFbDG8W0xvIXkxaHEUgGzvYyyipF3+jYwU45s91XLXgfwaWjqGtzsqdtovdpMgl2BiwL8zDHpLAZJ+OqOWZqg2BZmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zfhdz+uA; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zfhdz+uA" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2162c0f6a39so64428815ad.0 for ; Tue, 24 Dec 2024 11:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1735067091; x=1735671891; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h+gQgO0It7CURSu9wG5Nm/XdljrqD36vrZMH4FWJBR8=; b=zfhdz+uAxNL9StZvr2tkDonbpBJCL6tXiMZ/mQ9e6RvrztA93l0gcoakixsf9m7thp ifZgbUIg3/2I4iQjLnE3Co91RtY6d6ukImCuNQyqTdfAuDheK06rPleny4DLovrCzlp8 MCZ+TLOFkEfz2NUxsgOBlV+m7uWsTNc26yjbOxaFRUBJD9FY6mp84UAbYX+JSfdNExbZ L1/hbLJmrmaoAyt9yiL+bfDZPAom4xuT2dZ3vjjwYLB18RAuU4pGXIRmjEQUZ2o5JV4k 5VPPrG13Y5xb5FstTaXq5Dn88FJ4sgtXpPnnn6kwtGKGF5bafCdWN/+TQsfFWzK/fgaN R+0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735067091; x=1735671891; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h+gQgO0It7CURSu9wG5Nm/XdljrqD36vrZMH4FWJBR8=; b=DeE0D7c8CQYBAni1aVh+Jg4a0C2QYuzSaRztsb0kPXeBJM4TRUwoNSh8wpCLRxeQzF DQ0Fn4oE8HKrq+qz2LPkpUpzvRjajupzvT/htqhQp9D8qC1Wh6r6bcHInM22aOd7hfdP MSO0oN6Mjc3DIWlNfYx3zPsZuzaql24VRKGQXdiO/jPZarBV9JE7h9ClL8lNgXlStm4c +A3z6+mT3V23rEv4reeMJuiplE7w3Xedcyz7OuYW49emMHX5uk0Axc3GmashoCB5WDDM a+6cNVvx/MuOIt4RLWjXtMGIuSOK+LL5MZMP1tF+cyzj7XEgi5DYsouQmNNOfuRhBQE3 utBg== X-Forwarded-Encrypted: i=1; AJvYcCW5zdIeEpNpggYzFrb9TB6yin0Zpj6+jQWc2D5ONqFJS1FbrTyAyxvKa1x/jMLCfkT/wtDqmqB0o6PgEGc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx480O0R7n43gwW37qVMVAA+3A/9FoBSGII/C4j7ExjlzCVR0Wv NPrYxn5lVS51mOfC5SGAclHmmSiuFA003oLyKKSVt+YqVcqVc15WoQjfD4//tQ== X-Gm-Gg: ASbGncsXtt5Wlu9WjhOd4rbVz2qyV/4wzV/i5qPs/1vqUILzrm5bGBO9ntKkmn5a3xV sXN/1b9EPd2f+ndpWjj7PKmAd1zJGp5g4L/nI+siuJBrKC0ozajvSbnmNx9fvoIXK3l5oDyq4Gc 6rK9gTDSyvuS2iaZCzkKiEf+BYcdmMSWagPG21M5DJjEHAVHFwsvGXgzyWK1q7zggnrPNyBB98a 2KtxiStXUXeupvyfZnYPSoV+CLcCELJ4oN+/M+nG/j9IahKoEbInLmnOnEDCBX65voKK9BjmHka Z4WZuCqPCnM= X-Google-Smtp-Source: AGHT+IGgGVLlkjA9w/VtqNXWyqg+jv5tiTXwN8tN2Oz9Yo90E1ls4Xqit+S0t1EQxNnAyTSX36f2ig== X-Received: by 2002:a05:6a00:858b:b0:725:f359:4641 with SMTP id d2e1a72fcca58-72abdab904fmr27560136b3a.1.1735067091430; Tue, 24 Dec 2024 11:04:51 -0800 (PST) Received: from google.com ([2a00:79e0:2e28:6:3042:405c:6cff:1a37]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72afb89fedesm630246b3a.84.2024.12.24.11.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2024 11:04:50 -0800 (PST) Date: Tue, 24 Dec 2024 12:04:44 -0700 From: Yu Zhao To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Kairui Song , Kalesh Singh , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable v3 6/6] mm/mglru: rework workingset protection Message-ID: References: <20241207221522.2250311-7-yuzhao@google.com> <202412231601.f1eb8f84-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202412231601.f1eb8f84-lkp@intel.com> On Mon, Dec 23, 2024 at 04:44:44PM +0800, kernel test robot wrote: > > > Hello, > > kernel test robot noticed a 5.7% regression of will-it-scale.per_process_ops on: Thanks, Oliver! > commit: 3b7734aa8458b62ecbfd785ca7918e831565006e ("[PATCH mm-unstable v3 6/6] mm/mglru: rework workingset protection") > url: https://github.com/intel-lab-lkp/linux/commits/Yu-Zhao/mm-mglru-clean-up-workingset/20241208-061714 > base: v6.13-rc1 > patch link: https://lore.kernel.org/all/20241207221522.2250311-7-yuzhao@google.com/ > patch subject: [PATCH mm-unstable v3 6/6] mm/mglru: rework workingset protection > > testcase: will-it-scale > config: x86_64-rhel-9.4 > compiler: gcc-12 > test machine: 104 threads 2 sockets (Skylake) with 192G memory > parameters: > > nr_task: 100% > mode: process > test: pread2 > cpufreq_governor: performance I think this is very likely caused by my change to folio_mark_accessed() that unncessarily dirties cache lines shared between different cores. Could you try the following fix please? diff --git a/mm/swap.c b/mm/swap.c index 062c8565b899..54bce14fef30 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -395,7 +395,8 @@ static void lru_gen_inc_refs(struct folio *folio) do { if ((old_flags & LRU_REFS_MASK) == LRU_REFS_MASK) { - folio_set_workingset(folio); + if (!folio_test_workingset(folio)) + folio_set_workingset(folio); return; }