From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72BAA1B4148 for ; Wed, 25 Dec 2024 13:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735134149; cv=none; b=Pgb4DQ9vEFKwmaCeSNDpFuGA51zMGOu+fh5IJ1WQpLjcghNN4M+0BMGDhyxraOggwfzMA9KfX8lA1BbVKZgYgiY1LsUbDzznfrF5zM6P943nUz73c25/kRM/ogG+kXspGrxvmOql6hoNl/x9LuPQKCZ6DL7wKes97eIkxcCsbyU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735134149; c=relaxed/simple; bh=diPVJuFOZfEC5hwbZSqtnC+aaFP7mq4bIfPNYvQszhw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qXr57q+SjfPb4p6/9JppE1904Mb+hyUDoYFNmuBvz+ANH+FsEnPue9mgPn8SD8gXty6v+BtqbyOqdNHnrFxvyfYar7jW5BFQcW/rkU8SFboq74ekOaIJXHOpnnKQQINnpuBnGawAZ7nS+mquTWe5mSrp1tO7obiRE3i47vNkI/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dnTkYuyU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dnTkYuyU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A38EDC4CECD; Wed, 25 Dec 2024 13:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735134147; bh=diPVJuFOZfEC5hwbZSqtnC+aaFP7mq4bIfPNYvQszhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dnTkYuyUYYACrHtQwuv895ZdWmH7+YdKq7CkWdEJy7sJGbOtCjPuEm+RDsVPKGkZ5 wqkhP04mL0bLu88IPMgzF2eB2CHcIDFpju3+VPJQdtE3o42Goc0xKkKA+r+d0ra43K Y9yOTFVn4bypjYadalImiqrmS0HLfNHIC8u3eM8qY4Rf6HQPwl1Qj9F3lkLsUkj0i5 VVC/AOWm013uAgS5k5LwDQ/wFjX+U7CytSFAWssILjvLD9wkoWZQ6a0KK9LUSJzhDk hH0U3rSn/MYzHsg1QoiVFiC3/6Gendkr9pn4vwsSgk/t3UJx4uUVJUsyqG8KQHP4Gw YX8u2HAVwxItg== Date: Wed, 25 Dec 2024 15:42:15 +0200 From: Mike Rapoport To: Thorsten Blum Cc: Russell King , David Hildenbrand , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] arm/pgtable: Remove duplicate included header file Message-ID: References: <20241225123037.444716-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241225123037.444716-2-thorsten.blum@linux.dev> On Wed, Dec 25, 2024 at 01:30:35PM +0100, Thorsten Blum wrote: > The header file asm-generic/pgtable-nopud.h is included whether > CONFIG_MMU is defined or not. > > Include it only once before the #ifndef/#else/#endif preprocessor > directives and remove the following make includecheck warning: > > asm-generic/pgtable-nopud.h is included more than once > > Signed-off-by: Thorsten Blum Reviewed-by: Mike Rapoport (Microsoft) > --- > arch/arm/include/asm/pgtable.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h > index be91e376df79..6b986ef6042f 100644 > --- a/arch/arm/include/asm/pgtable.h > +++ b/arch/arm/include/asm/pgtable.h > @@ -19,14 +19,13 @@ extern struct page *empty_zero_page; > #define ZERO_PAGE(vaddr) (empty_zero_page) > #endif > > -#ifndef CONFIG_MMU > - > #include > + > +#ifndef CONFIG_MMU > #include > > #else > > -#include > #include > #include > > -- > 2.47.1 > -- Sincerely yours, Mike.