Re: [PATCH] ASoC: wm8994: Add depends on MFD core

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Tue, Jan 07, 2025 at 03:39:31PM +0800, kernel test robot wrote:
> Hi Charles,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on broonie-sound/for-next]
> [also build test WARNING on linus/master v6.13-rc6 next-20250106]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Charles-Keepax/ASoC-wm8994-Add-depends-on-MFD-core/20250106-235153
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> patch link:    https://lore.kernel.org/r/20250106154639.3999553-1-ckeepax%40opensource.cirrus.com
> patch subject: [PATCH] ASoC: wm8994: Add depends on MFD core
> config: alpha-kismet-CONFIG_SND_SOC_WM8994-CONFIG_SND_SOC_SAMSUNG_MIDAS_WM1811-0-0 (https://download.01.org/0day-ci/archive/20250107/202501071530.UwIXs7OL-lkp@intel.com/config)
> reproduce: (https://download.01.org/0day-ci/archive/20250107/202501071530.UwIXs7OL-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501071530.UwIXs7OL-lkp@intel.com/
> 
> kismet warnings: (new ones prefixed by >>)
> >> kismet: WARNING: unmet direct dependencies detected for SND_SOC_WM8994 when selected by SND_SOC_SAMSUNG_MIDAS_WM1811
>    WARNING: unmet direct dependencies detected for SND_SOC_WM8994
>      Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] && MFD_WM8994 [=n]
>      Selected by [y]:
>      - SND_SOC_SAMSUNG_MIDAS_WM1811 [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_SOC_SAMSUNG [=y] && IIO [=y]
> 

Well I guess this is maybe an argument in favour of adding the
depends since unlike that issue these are actual things one
might hit in practice. Both Aries and Midas appear to be missing
selects for the MFD part of 8994, fine as long as it gets manually
selected but will blow up if it doesn't. Will send a patch for this,
but it needed not block this patch, its a separate issue.

Thanks,
Charles