From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5548F1EB9E8 for ; Tue, 7 Jan 2025 12:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736254566; cv=none; b=q5RN7vOc5tY8MmoPHBPZWcf+vPHF+rNZUH43MyHA1sHPsURtFu0yDUw/Ff/996ZpQmJ97FlDkv21gX2A1jTQmoJFwBfCssMUAajS62iUQzJ2MvbkNc0E012XKNzULtOCnl7UA3HczpwS9OBx85nUm7BaiddFD2ZZPCKXY77lWz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736254566; c=relaxed/simple; bh=6c0tGgmq2VHFAd0FPZKcrOIoxEX7i1zayzPfZhXJWjQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hsyftIkq7vd8NsGLH8Q3CrrTPFTmflFtPZXpEJ+0QBHOBc2ia+/n5seKntRA0r7K5IqaGzvUnPf7s/nh92AzOVvoWQdDdldHRnyqWc4k3yVLcOMM15XtwQnBsB4kgjcdV3lpdaUG67Jqg8XL49Mv5MXnvhG4frVqs+h0DteT+aU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Luw3x7aF; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Luw3x7aF" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-435b0df5dbdso45415e9.0 for ; Tue, 07 Jan 2025 04:56:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736254560; x=1736859360; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dJHF6OgALpXsDMgREdanysBcHUY87rvlDcgFVe73W1A=; b=Luw3x7aFi8NOeBovCeDDEHxvynjasDi5y75HunDUlBnnei+TSTSetKpa+vCuQX+QwN MdbseL4Qe72NwlInZbIpIrQe5BNDP2lzEk8wseYF969o/uxbD7skFbPhR+QcBOCmsd/8 rbtMTdahgOkObYabkhiaNtpzhl2bY3EbUBjNf87/pYLrfGNZ7vtPTBJ8Kt6pb96503oD f0eBrV9X7wzpZGxmIV/53AwDbHiPMFFRhakE5jI424bpa6PSwYyCvCnFODWpolie5J5E QEgnaO0AU4XdWgfxDsltsomopbT6dOpffbpDfVlVkngF+eNe+//ZBUxHXXAPJemivTNY h/BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736254560; x=1736859360; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dJHF6OgALpXsDMgREdanysBcHUY87rvlDcgFVe73W1A=; b=XzvWs1gnCKLML7FGHzgna7EnIfRU7qXfy+bsiV9cbEp4MIOwpTPA47THUitv9M6HsH mG8b0mrfboTpc1Gc0FkaKD4kDOVKCMkG19OK3PR7ybgeGDJoQVolAXnEYSTsUnfj2H0W 9mnPUQzGciK8RqnX/ednLxkqzNHjrEW65DogaMzRJbWlDu4eNgEycIb2aAU8WaZ/gr4z xWPjRGbhlVUMQlbeyYUi/osJ6C1J/4KxnakWvmPZqYE72OXDRVk48/Gvq+nbIOSpZ75R V581TALspNOV0cgGDJBuvaENJWfTCW/ChNERNl3iJZ6TONwaDb5oBvmjgWpw55y1f7V8 9JaA== X-Forwarded-Encrypted: i=1; AJvYcCX4Qw2YXCKztKONk1AEqXOk/tTTGfgzPMjryLt2thOc4erR+yQjuh5sKNOxb0En1oQT8yJMgB1ApzSLL0I=@vger.kernel.org X-Gm-Message-State: AOJu0YxmHZ1hh0dMoAxDstoISzFfSdBK8KjzhoRL9YjtvxWF0xtvEuVv 6V3M/iLLFYgFEKEyK2MVVcjsHuOfRecaeKTUkXU0+rlge8lrz9fqANTwoiwxAA== X-Gm-Gg: ASbGncttBk4F6fdN6d0V1IdYfoIQ/cfOOC525aNYnx1ZL4RkwcWTBRKAmPEAo4g29Yt c+QzT9XhbAQVivmVCoTRFd4ojjHQVKj0Yb0YBQx0itBTL/QOd3dARFew9j21VGV/pdILRvts9TL ZdLL2fVCQv/0ToDO7seyLqXM8exz3ZnqrjgL+qeiW1SgTcacjT+ElHw3tsEs3IxCU70aVH7jiW1 0pDhNAa+OiRVbRZRFkKbME6B0Fpm6yh8bXn9ksYvuM4fGwUgMau+0vl+Y6Q/CN3hg4pdB9s0LQg svdGFwyJte/WgzeliJU= X-Google-Smtp-Source: AGHT+IGshgYKYU49AS8Yt3DzTbm9jzfDb1zOfiYsDlqWPz/kk/iuG9opzk/qyzVKRNqNypOg626I8w== X-Received: by 2002:a05:600c:4f8f:b0:434:c967:e4b5 with SMTP id 5b1f17b1804b1-436dcf7356fmr901395e9.1.1736254559456; Tue, 07 Jan 2025 04:55:59 -0800 (PST) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a2e25edbbsm42740762f8f.110.2025.01.07.04.55.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 04:55:58 -0800 (PST) Date: Tue, 7 Jan 2025 12:55:55 +0000 From: Mostafa Saleh To: Rob Clark Cc: iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Will Deacon , Rob Clark , "open list:DRM DRIVER for Qualcomm Adreno GPUs" , Jason Gunthorpe , Joao Martins , Kevin Tian , Konrad Dybcio , "moderated list:ARM SMMU DRIVERS" , open list , "open list:SUSPEND TO RAM" , Marijn Suijten , "Rafael J. Wysocki" , Robin Murphy , Ryan Roberts , Sean Paul Subject: Re: [PATCH v11 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging Message-ID: References: <20241210165127.600817-1-robdclark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241210165127.600817-1-robdclark@gmail.com> Hi Rob, On Tue, Dec 10, 2024 at 08:51:18AM -0800, Rob Clark wrote: > From: Rob Clark > > This series extends io-pgtable-arm with a method to retrieve the page > table entries traversed in the process of address translation, and then > beefs up drm/msm gpu devcore dump to include this (and additional info) > in the devcore dump. > > This is a respin of https://patchwork.freedesktop.org/series/94968/ > (minus a patch that was already merged) > > v2: Fix an armv7/32b build error in the last patch > v3: Incorperate Will Deacon's suggestion to make the interface > callback based. > v4: Actually wire up the callback > v5: Drop the callback approach > v6: Make walk-data struct pgtable specific and rename > io_pgtable_walk_data to arm_lpae_io_pgtable_walk_data > v7: Re-use the pgtable walker added for arm_lpae_read_and_clear_dirty() > v8: Pass pte pointer to callback so it can modify the actual pte > v9: Fix selftests_running case > v10: Call visit cb for all nodes traversed, leave the decision about > whether to care about non-leaf nodes to the callback > v11: Adjust logic in 3/4 [smostafa@] I see the level initialization was not removed as it was in the diff[1], so it seems to me that’s redundant as the level is set anyway in the callback, and actually looking at that I see it’s not used or printed from the driver, so may it can be removed all together, anyway that’s nit that may be Will can fix it up while merging. Otherwise, For the whole series Reviewed-by: Mostafa Saleh diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c index ed3ba47df350..a884af8fb101 100644 --- a/drivers/iommu/io-pgtable-arm.c +++ b/drivers/iommu/io-pgtable-arm.c @@ -731,7 +731,6 @@ static int visit_pgtable_walk(struct io_pgtable_walk_data *walk_data, int lvl, { struct arm_lpae_io_pgtable_walk_data *data = walk_data->data; data->ptes[lvl] = *ptep; - data->level = lvl + 1; return 0; } @@ -746,8 +745,6 @@ static int arm_lpae_pgtable_walk(struct io_pgtable_ops *ops, unsigned long iova, .end = iova + 1, }; - ((struct arm_lpae_io_pgtable_walk_data *)wd)->level = 0; - return __arm_lpae_iopte_walk(data, &walk_data, data->pgd, data->start_level); } diff --git a/include/linux/io-pgtable.h b/include/linux/io-pgtable.h index 0f17a38a304d..c62e344a4058 100644 --- a/include/linux/io-pgtable.h +++ b/include/linux/io-pgtable.h @@ -190,7 +190,6 @@ struct io_pgtable_cfg { */ struct arm_lpae_io_pgtable_walk_data { u64 ptes[4]; - int level; }; /** [1]https://lore.kernel.org/all/Z1AtDgLD0SDUxDHl@google.com/ Thanks, Mostafa > > Rob Clark (4): > iommu/io-pgtable-arm: Make pgtable walker more generic > iommu/io-pgtable-arm: Re-use the pgtable walk for iova_to_phys > iommu/io-pgtable-arm: Add way to debug pgtable walk > drm/msm: Extend gpu devcore dumps with pgtbl info > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 ++ > drivers/gpu/drm/msm/msm_gpu.c | 9 ++ > drivers/gpu/drm/msm/msm_gpu.h | 8 ++ > drivers/gpu/drm/msm/msm_iommu.c | 22 ++++ > drivers/gpu/drm/msm/msm_mmu.h | 3 +- > drivers/iommu/io-pgtable-arm.c | 157 +++++++++++++++--------- > include/linux/io-pgtable.h | 15 +++ > 7 files changed, 167 insertions(+), 57 deletions(-) > > -- > 2.47.1 >