From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46DC31F1928 for ; Tue, 7 Jan 2025 15:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736264278; cv=none; b=HXC+urcAk1ikxqamtu1mRMwVlmQ8eX+7/HyFtJ8KMmQFDU+hGcus8sywZF3IVyXAvZf1eeNh/nioA2p2v2x0CLhOu45PRJNejNdt4A9LgLymlfAGwbHZnzP39awX3Sr9bkVlSw6BcmneWLpY+aUg7GzJ3cQFS6W6GUns6Cz3gG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736264278; c=relaxed/simple; bh=LJeOLSx3TO9m513NwbnkeDQ6maYTT/dIQ73DSi02NXg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=gHYHJdIOqhLZbL8cmhnD5AhQ3JVqFFeB7zAk0T//YYrpOCGCfDhghAft1/yUeh0fUJyJmxn+xgx9vk7elxx5g6FQfmtsSVbqtF3r4xBLt5paPCCG9mUSCBNhrM+n6i/T7D1Btr2KO4B82OArBEQ2ZtKNqChbB1JMch52uOAWou4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=A7S5fEOC; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="A7S5fEOC" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2166a1a5cc4so210077955ad.3 for ; Tue, 07 Jan 2025 07:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736264275; x=1736869075; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5em+kVXHMZ6KEpaSnxRKl0QMtZenxzWVITT8lA9geoY=; b=A7S5fEOCQduPE3Po0Od6cABBrqNli4vPo8ddmF50LJnnDD25ZSgILyZlz1dw8u+jUK kYTwwWHAzSK8+dAr+VDMW0trLkKyu4rP/sz1DxlcKncs4NFPkoDCfQ3H+wi+LSKUZGtb 9oM5y05E7UD2Tm961hBwm/ph7SCgCgNI9oRNYntln7bNxyxU8770Qu752U3XsdkiRNLv qvMcNRxZDyh/gFy2bGpz2bnUbO9Yr4fqZprlj9ByOh4cm9rOuBoNoJgW7Bd6TNAHMxks h9cM//k2L+ArSJeq0TuLhk1/Q4WxnyAg2B9rLEIaUizbyS8XMIqJj+maIa2fJubsyDYG NviA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736264275; x=1736869075; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5em+kVXHMZ6KEpaSnxRKl0QMtZenxzWVITT8lA9geoY=; b=DOhkX4LjcExFEuQ/0+DP86IacOJttZwe+9/peN9u00Wl26Cro8JuPH1i3fem5Ho0Gh gp8t3A2IJU2GRT//UM3keQ+jSzbWypW7XSHiDnZcaSGlKUOp4nO4r8aEozIQ/vrYEzqC Q9zgu/XPmb8BXV5KHe97sN3dsmv+ukVI2Q8b2MAaNPSmZjI/foVi4XErm539GOYnzivo N9zw96vOOuaeHZrJtm1FQQl6tTNslSsIFC/zWQ/SYIlj1IdYNH9ZSNze4A1BDNcs+xs9 t0XJf7SJHMYI7e+oF+NS24Hzvclk0+2Uaet5CYhm64MdQw9jn7zw2nHbKIYybv0DEE5K Y6WQ== X-Forwarded-Encrypted: i=1; AJvYcCWjmUnCQ3sOCJu9y7P4K84uYNYTd2dhztIvJaohfRxE7lBO3YGF7ox3gLW2RlC29oV7psjvXXuODuhfdHQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwS/qV0SXRIkI6hDAQ/g2UjDtIuqb4rm7SOq9yWxUsNeAX5WC7O w5teKnc3WlNuRVkJ2J1IHUdt/KDz095GW2pR1eDiFwBwk/JtiwL0cTSa50m0UDQbCb4/72VejrA 9AQ== X-Google-Smtp-Source: AGHT+IEcGzEx9UodPbhCllVaZK25i6Tbo5ua2Txu4ITHVS9wRNaOSsK0fxtQwdKmWGWPr4qSPnk37CtX2j4= X-Received: from pfaw12.prod.google.com ([2002:a05:6a00:ab8c:b0:728:e1a0:2e73]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:670b:b0:1e0:d32f:24e2 with SMTP id adf61e73a8af0-1e5e081edf3mr103640840637.38.1736264275581; Tue, 07 Jan 2025 07:37:55 -0800 (PST) Date: Tue, 7 Jan 2025 07:37:54 -0800 In-Reply-To: <20250107042202.2554063-4-suleiman@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250107042202.2554063-1-suleiman@google.com> <20250107042202.2554063-4-suleiman@google.com> Message-ID: Subject: Re: [PATCH v3 3/3] KVM: x86: Document host suspend being included in steal time. From: Sean Christopherson To: Suleiman Souhlal Cc: Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chao Gao , David Woodhouse , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, ssouhlal@freebsd.org Content-Type: text/plain; charset="us-ascii" On Tue, Jan 07, 2025, Suleiman Souhlal wrote: > Steal time now includes the time that the host was suspended. > > Change-Id: Ie1236bc787e0d3bc9aff0d35e6b82b7e5cc8fd91 gerrit. > Signed-off-by: Suleiman Souhlal > --- > Documentation/virt/kvm/x86/msr.rst | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/virt/kvm/x86/msr.rst b/Documentation/virt/kvm/x86/msr.rst > index 3aecf2a70e7b43..81c17c2200ca2f 100644 > --- a/Documentation/virt/kvm/x86/msr.rst > +++ b/Documentation/virt/kvm/x86/msr.rst > @@ -294,8 +294,10 @@ data: > > steal: > the amount of time in which this vCPU did not run, in > - nanoseconds. Time during which the vcpu is idle, will not be > - reported as steal time. > + nanoseconds. This includes the time during which the host is > + suspended. However, the case where the host suspends during a > + VM migration might not be correctly accounted. Time during > + which the vcpu is idle, will not be reported as steal time. This belongs in the previous patch. All in all, IMO this can all be one single patch, as I don't see any reason to put crud into common KVM. > > preempted: > indicate the vCPU who owns this struct is running or > -- > 2.47.1.613.gc27f4b7a9f-goog >