From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E0471E3760 for ; Tue, 7 Jan 2025 16:49:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736268597; cv=none; b=OfXDcueZ+evXn+KTq4O/OjTB1s6u35itPRPvi7bGODo4hd3bIsavjTMyL69eT6pv9Zr73/lSsn10XlZ1XSZ46DvDEaCe7Pah/kFYSYGMNrMUcGwtookvzqpRWRBTGFCblCP0H2K8yz9F7uSGG9Zq+v4mFxRjuHY1rndIXSXETrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736268597; c=relaxed/simple; bh=o+Wl34SdBo103Nc1R/lKqtrcRe1UYK9HPCvqt0cNLRo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OVq/+nd8P5QZepyQnTcS3uVn5FHYdU2LalHsTTg/VpYK+lnuL0rsvKEZB0MHJSLPc+mRrAQuTjekqznl//NNxIMfV2BYxRGFXHkpvOhgru0LCKOKz0puybF7iREOWPYIi0kEC8DWuSmyb4pX9zf6JQREE4tUX+1UcS3UDrvejpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=Ll/Vy2bA; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="Ll/Vy2bA" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-468f6b3a439so131988681cf.1 for ; Tue, 07 Jan 2025 08:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1736268593; x=1736873393; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XPyxJ38MGo5fiKfUZUWa+5eEjSnwU1cZs3xFsnDOh8o=; b=Ll/Vy2bAWBJyq+81Drema0imI5VRthA88v+QfmMXVZMxuQCZvCmO5RMR4gbkGNoKoO PM5oriIaUCirNaneggtQGhvZK6zbYTGqx2ozm0j9HCPbDTXcQNQreDgBHPE3PFbDAJUh Jk2Uuox2dfhMlZ0pbHbsfRTrI4e19uGAroAcJ1lEXEXgNkkEBbFXQHHq7lkru3h+d8AS cYB9fzxMIZ/6Scjm3hPS2ka5Qn11pXk1zufh2GxSik6Tt4ZV8Tit5QXUo6+Od4JHbIf9 M/gIz0K6hgrNs4XD+FKQTsc9jgomfqcrpERqx1e6LKcLapYI8GiBftHC4utmMXNkwOv7 F7Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736268593; x=1736873393; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XPyxJ38MGo5fiKfUZUWa+5eEjSnwU1cZs3xFsnDOh8o=; b=f41mWVWpRmF0HZ4bobvrLdbBIsAo7E263HaVbsx649eBb3H3oQjeK49k4coFSbX+8u ko2rdp1cl0fjwKrsFDjSCm59M45QokBdF5PE8rUKRZsxQfbv2Wc0uHnui5G+cLeKldes 68JeS9pAoH0Xc6AvAH3H6CAXHwqzI+IxjOiS0a3JId0amMEvZxbOA7jNQr76AFw4Z7P4 uTofdkZVHpuRHkqLHwDgNENGbaN+jAQZjhxpnEAHAPXnGvlpm+LI5rCBSXdFna5RW/sT eRgPP1iVuC6eJciIccK6EvywhVPLhJcCJpVWc08UwxwLzvFg7g3l7Jf5jkh0rXQmejSB fBZA== X-Forwarded-Encrypted: i=1; AJvYcCU8HB7nWSSda7hpd82cBpeVMCSvbVKFtsSEe02d+nyP+AySp8OkO3eRWigt8k/ZZg+g9Njwl9yH43zXLtg=@vger.kernel.org X-Gm-Message-State: AOJu0YxOJO2lyjWhfxFw8zyPAhXr7YF75MWXDHoGptJnjKBpfYkHzw0A l6ED93F8lI+4/F852ymb6d7DZ6D+VQCrrDiISYNoEvWgIXo2wKqhWQwtOXaLYEU= X-Gm-Gg: ASbGncuEGAmPT28pDzyPkDTXManccoryd+XhJIT/XOefKuBQK1cJ328VSNTn3U17Uy7 L6CdnH+tMkCKE69xdQHNp3SgycD8KUqVD+kqUKOUrBLw8i/UOUsdO/8ga7i7wHf1bvFcGVdpCvO nPfJe2zHRHwfT/gbBDploAgntZP9WH/Nct465qQ9Wt5iemQvF1S1E7uiv29LVvIeNFK8puDNr80 YS5Xp5Tj1KmUcBQTFAkU27obJnS/S9uU+z9eyPUnUcD8VVD5RwuEs2JHe2md2nYx2W8SNEUIEnP uB8xcNg3UnMITbtWdh+kPM8NywXCI4qutb7fRvA= X-Google-Smtp-Source: AGHT+IFBSXLroR2FgsUlB0mbrlBft/EgrN6qscz6sm1Q4LClYVj49SJmQjMmH9K3UzEgee4wzb3bkg== X-Received: by 2002:ac8:7f41:0:b0:466:b394:92bc with SMTP id d75a77b69052e-46a4a8b81famr955610131cf.6.1736268593595; Tue, 07 Jan 2025 08:49:53 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3e6a106fsm187506001cf.38.2025.01.07.08.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 08:49:53 -0800 (PST) Date: Tue, 7 Jan 2025 11:49:51 -0500 From: Gregory Price To: Robert Richter Cc: Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Jonathan Cameron , Dave Jiang , Davidlohr Bueso , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio M. De Francesco" , Terry Bowman Subject: Re: [PATCH v1 05/29] cxl/region: Move find_cxl_root() to cxl_add_to_region() Message-ID: References: <20250107141015.3367194-1-rrichter@amd.com> <20250107141015.3367194-6-rrichter@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107141015.3367194-6-rrichter@amd.com> On Tue, Jan 07, 2025 at 03:09:51PM +0100, Robert Richter wrote: > When adding an endpoint to a region, the root port is determined > first. Move this directly into cxl_add_to_region(). This is in > preparation of the initialization of endpoints that iterates the port > hierarchy from the endpoint up to the root port. > > As a side-effect the root argument is removed from the argument lists > of cxl_add_to_region() and related functions. Now, the endpoint is the > only parameter to add a region. This simplifies the function > interface. > > Signed-off-by: Robert Richter Reviewed-by: Gregory Price