From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4324819E979 for ; Tue, 7 Jan 2025 22:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736288087; cv=none; b=cjC+SyS4e0rRmy0azW3Bc5ow/ur+3pTX9362VJzSdqfzPEJxHK9mO0u09Q1QCx7HzqjWAwpo8hdOhcwaSBGrPX36vued/nwdPuvjCVcd2rVgzF5HB5iHHV+7T1mXK/ps7dVGq7T88XvXjoZ4eURGpsbCjQ/c3zwcZJ+l3+7Od3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736288087; c=relaxed/simple; bh=Q7gsPmAwcKW+iCD5IVNi31ZUXWQBjg1I4E0jayTr9Dk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gEF34JQkK4aTf7MZa/e4uE1PdraZ095YztKi63LWrnMXe+m/AzavKsh6nrSHJ/lBRLByM0Zi/uyEMwHyXlFsLGD/BDj4VpoAJ9hFIv3wvr5hVTV+nLkxA5rbX1t40Sa2k4WXJ0L29QZXIgyiTsra27HyzAVHBMVrJzuoMAdUlEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=lFOYiXlE; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lFOYiXlE" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-21634338cfdso22708515ad.2 for ; Tue, 07 Jan 2025 14:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736288084; x=1736892884; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RV+4e9KhhM+feBvIE88GxANGaUR7qFryxHJqEAou5R8=; b=lFOYiXlEDbzSieWXPm/49QCQUL0R+ksdaM+8gQl1rc8uKy6gjUakUiagavB+G3l9le /VzJC4ECyl2HpJacfH2ZzrtesaZBbdUSv9Dcqdcjg95TqECYwrxPcnvHDer1wVujXcyy b9cydzzwJvKwz6gyWhT4NhdwMKojwajedu0Q4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736288084; x=1736892884; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RV+4e9KhhM+feBvIE88GxANGaUR7qFryxHJqEAou5R8=; b=NfDJ5g3QQNhNd+WbRxEnXiJSVQIyVVwyl+NB6DXPw/WeQfZhSNOMajj3iXC8Hnke0Q OSY1oplki/E++C+2Rr8Lvs77eW1KG8hY90zSmy68o6zCXf3QreQ63oKQ2Mt94HdQW5EH tSkBfrD6Uj7qhEvzYTv+JBlhRkpwPD8egd9kx8AdL2Nqv2ZAHNUvTESO82r8gy2NGlGe yRHzqc9eXDg+ZzBXCJLK3gdyQrGQ3JY+s1bzNrrZ500y9wGfDxR0B6kvRFf/i5MJt0LR IN83tr3havpMVq1XOIOEzzoXArT4LCjbD39+Qeg4h3+bPiQr09yZh6HBmrnyytYmBUYS S8yQ== X-Forwarded-Encrypted: i=1; AJvYcCUKnHC6MLgGwCQjCbsZP+tct5jOZgGgOyVGjrK51RYTrhr9NOBIeiBc2r/ARnLPOihwFgNfet4iyhSULuk=@vger.kernel.org X-Gm-Message-State: AOJu0YwdhoYnR2K0pQrLGNzqH/r3DPqDA7cm1yGq77xj9UWHUzJVnfTJ 37LMCAvo0BlzY8QYNhrzcau61+TKf1cqp6nN+wOWkvEhKgasNDbT84N5Gn1pow== X-Gm-Gg: ASbGncu1sEhr7cePI7DRdhboHTUOL94tHjvYReexzCneEXIh7TR2ujdJfZ2sMXpOPhC R3CquuNMHLle7lMN3UmZTFyjLKlTL26Va45VsETdT7G/gr0inEk/7A9Rl5D8RwJQCEBpy0Qxp/T yKeoWJ3T96Od/IWyHNwVj/tN9hCWY71TrO4kFqm9vi2SfELSm7HmJ5iroooIBZZKz9xc0wdlPfv 0N0SCPL1viR7jUksJyeR5BD8RzP+kMbbQky+JuDzZmEx5byHh4qj4sjp80nUMKewqCN/qELjdqi 9XzB1222h0Qr4BfPE00= X-Google-Smtp-Source: AGHT+IEkAisXGBz/e/a8gkUWJb8Iue3ft+92hn87eXDD4Dkl25YTjIs6OX+OKDfqwZwQcXi/uW2Pcg== X-Received: by 2002:a05:6a00:ad4:b0:725:ebab:bb32 with SMTP id d2e1a72fcca58-72d2201be2amr783291b3a.26.1736288084620; Tue, 07 Jan 2025 14:14:44 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:183c:e247:20b9:87a9]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-72aad8fd7b0sm23040661b3a.139.2025.01.07.14.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 14:14:44 -0800 (PST) Date: Tue, 7 Jan 2025 14:14:42 -0800 From: Brian Norris To: Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown Cc: Hsin-Yi Wang , linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, lukas@wunner.de, Manivannan Sadhasivam Subject: Re: [PATCH v5] PCI: Allow PCI bridges to go to D3Hot on all Devicetree based platforms Message-ID: References: <20241126151711.v5.1.Id0a0e78ab0421b6bce51c4b0b87e6aebdfc69ec7@changeid> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241126151711.v5.1.Id0a0e78ab0421b6bce51c4b0b87e6aebdfc69ec7@changeid> Hi Bjorn, On Tue, Nov 26, 2024 at 03:17:11PM -0800, Brian Norris wrote: > From: Manivannan Sadhasivam > > Unlike ACPI based platforms, there are no known issues with D3Hot for > the PCI bridges in Device Tree based platforms. Past discussions (Link > [1]) determined the restrictions around D3 should be relaxed for all > Device Tree systems. So let's allow the PCI bridges to go to D3Hot > during runtime. > > To match devm_pci_alloc_host_bridge() -> devm_of_pci_bridge_init(), we > look at the host bridge's parent when determining whether this is a > Device Tree based platform. Not all bridges have their own node, but the > parent (controller) should. > > Link: https://lore.kernel.org/linux-pci/20240227225442.GA249898@bhelgaas/ [1] > Link: https://lore.kernel.org/linux-pci/20240828210705.GA37859@bhelgaas/ [2] > Signed-off-by: Manivannan Sadhasivam > [Brian: look at host bridge's parent, not bridge node; rewrite > description] > Signed-off-by: Brian Norris > --- > Based on prior work by Manivannan Sadhasivam that was part of a bigger > series that stalled: > > [PATCH v5 4/4] PCI: Allow PCI bridges to go to D3Hot on all Devicetree based platforms > https://lore.kernel.org/linux-pci/20240802-pci-bridge-d3-v5-4-2426dd9e8e27@linaro.org/ > > I'm resubmitting this single patch, since it's useful and seemingly had > agreement. I massaged it a bit to relax some restrictions on how the > Device Tree should look. > > Changes in v5: > - Pulled out of the larger series, as there were more controversial > changes in there, while this one had agreement (Link [2]). > - Rewritten with a relaxed set of rules, because the above patch > required us to modify many device trees to add bridge nodes. I'm wondering if you have any thoughts on this. Manivannan seemed happy with this in his reply. I'd like to see this land in mainline, so I can avoid the hacks that everyone seems to be picking up (such as adding "pcie_port_pm=force" to their command lines). (While I'm at it ... apologies for the poor versioning. The subject here should probably be "v6", since I'm clearly quoting above that the prior version from Manivannan was v5.) Thanks, Brian