Re: [PATCH net-next v1 7/7] net: usb: lan78xx: Enable EEE support with phylink integration

Oleksij Rempel
2025-01-13T12:42:22Z

On Thu, Jan 09, 2025 at 08:33:07PM +0100, Andrew Lunn wrote:
> > Andrew had a large patch set, which added the phylib core code, and
> > fixed up many drivers. This was taken by someone else, and only
> > Andrew's core phylib code was merged along with the code for their
> > driver, thus breaking a heck of a lot of other drivers.
>
> As Russell says, i did convert all existing drivers over the new
> internal API, and removed some ugly parts of the old EEE core code.
> I'm not too happy we only got part way with my patches. Having this in
> between state makes the internal APIs much harder to deal with, and as
> Russell says, we broke a few MAC drivers because the rest did not get
> merged.
>
> Before we think about extensions to the kAPI, we first need to finish
> the refactor. Get all MAC drivers over to the newer internal API and
> remove phy_init_eee() which really does need to die. My patches have
> probably bit rotted a bit, but i doubt they are unusable. So i would
> like to see them merged. I would however leave phylink drivers to
> Russell. He went a slight different way than i did, and he should get
> to decide how phylink should support this.

Hi Andrew,

Ok. If I see it correctly, all patches from the
v6.4-rc6-net-next-ethtool-eee-v7 branch, which I was working on, have been
merged by now. The missing parts are patches from the
v6.3-rc3-net-next-ethtool-eee-v5 branch.

More precisely, the following non-phylink drivers still need to be addressed:
drivers/net/ethernet/broadcom/asp2
drivers/net/ethernet/broadcom/genet
drivers/net/ethernet/samsung/sxgbe
drivers/net/usb/lan78xx - this one is in progress

Unfortunately, I won’t be able to accomplish this before the merge window, as I
am currently on sick leave. However, I promise to take care of it as soon as
possible.

Best regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |