From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 630541FF61A for ; Wed, 8 Jan 2025 17:26:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736357183; cv=none; b=HRYu/2g5I+sC+1OYD9klh55+/suNwXbBvYqUKOv0vyJz2XFWj/CgVTbGZmsU9X2HBZxeZbpA/Xxjc1cQUYvLfTHgB2xZUwCIOzDVRnaucAiHn6hfqwjaWx8+eeqdm+6SpknsbkKM4/dz56xL404Te7srFJ4sQgo2t8t3A4xSveo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736357183; c=relaxed/simple; bh=D9gSl7xx8gFqjv9ydwHVxZnnvqbCRMlKn8BH+hmDzq8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rCs8Amg2pHK9uMKBaS1EeiwQ394MQumfgVHNlEvR7Nc9DXM9gCtFuFxWyEAUrBeq0KuNi1I8/mhzAkqncCROMBY4tH1icqGIRDJEOrBrGODYMBcqNrzQYvIzdD8y9ZKxRQGIo99ZtiZMfGCcK+8GkvVVtm9+EZTwwisUZiWnAjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch; spf=none smtp.mailfrom=ffwll.ch; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b=ZUkeGw/f; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="ZUkeGw/f" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3862f32a33eso8865f8f.3 for ; Wed, 08 Jan 2025 09:26:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1736357180; x=1736961980; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=bI5BkTsr1Rej7kPzTQ7NrBrtLjPHANabm0Md7VMapXI=; b=ZUkeGw/f24vFVeYgi7L0veV1Gi8nWeb71r+MZxlqwhx+3xkRXcEpWste/LVvxgCPIE pFpZRmFjjfAgdjT2l0jI52bQ5Cp867q4fR3wwdOOCNluIaRvwDgpO58NNNFL0HZ2WKBC s1MCanfljU8twmxkv14x/0Xh2QJWQC4kXJ2zk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736357180; x=1736961980; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bI5BkTsr1Rej7kPzTQ7NrBrtLjPHANabm0Md7VMapXI=; b=gwB7Mqj/6K1sEo7i3wtWkiBip3vqsXzKcI2wQG5p1EWAw3dYUR+u8OobjlbTHEYwT1 lWA2hXbIIHT2LxTM/gR3rq2OqOAaWSr5tjy9qRtYNkWLbXZmDgEv5xlkY9/m4vpAHRWL 0NQOwG2qRfMyYvQj3FPao8l9sLgNWggWLf4g3Vdvcrnc55uF80D0W6KdbIwNYtc9QwoI ZY0uEX4I3wzpbXBGweCymAWVPrZI2ZnJwXYClbsQTIoBzQOHognm2EM7K8USpu8WSoCz FaSnZSvSLW/ywSbV1G6CuPhOr8NYmB5myBvWVtfAM3qWs3cGKV+Nig1aITk8thamDtHs l+8A== X-Forwarded-Encrypted: i=1; AJvYcCUsXASuk+1+V8ePmqN8Gdecqv5PrjRIvzNIrP45yj1lTRDRreN5mQ6X0Q1Xm2UEMbcyngUpCz7mmnBRgFg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9gAeMMcOYeg40+auaKo6P6xQknmULZgMw5SSL/yHZwMePuTVt EZ7UbOq3LbYpkBbdk0PN/sYs4dZPKE7b0OsZzzD5QAp0NVxycfN6Is4JSRxx1ec= X-Gm-Gg: ASbGncu/05IbLx5o7fiEKTwv0D2Ps0ozl9KOlecjIDRUElVVmWdOPCjLDUVb1YGRNR7 fUpbXoprHpNmLRlYKW8HksshliEswqPal/jVPnAipETXiaiYW+ARBXCSZWmI+aVBEEi8RkWshji 7dYcVlMaxJB0aZLUdI0qNMHYcFX7M2Y8NkE41abhe8Upw2r5A7817aqHWDFtHj6LX8wSvTreqhD 9t9x67kz0oUp28tYEMF96GxbXvjSR50ZrOgwwDO8769jPv6lGbgnO+/4uWRN5bUmyL8 X-Google-Smtp-Source: AGHT+IHIG8gIkIZLnGTj2vm2ov4/i2vQzdBqNMlxt0wme6qkxMsRJFFigfl4B+bpgLZ7xuYAvDMDEg== X-Received: by 2002:a05:6000:1446:b0:385:d7f9:f169 with SMTP id ffacd0b85a97d-38a872f6d09mr3033928f8f.12.1736357179644; Wed, 08 Jan 2025 09:26:19 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8334aasm53404544f8f.41.2025.01.08.09.26.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 09:26:19 -0800 (PST) Date: Wed, 8 Jan 2025 18:26:17 +0100 From: Simona Vetter To: Dmitry Baryshkov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Chandan Uddaraju , Jeykumar Sankaran , Jordan Crouse , Sravanthi Kollukuduru , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Archit Taneja , Rajesh Yadav , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Simona Vetter Subject: Re: [PATCH 1/6] drm/atomic-helper: document drm_atomic_helper_check() restrictions Message-ID: Mail-Followup-To: Dmitry Baryshkov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Chandan Uddaraju , Jeykumar Sankaran , Jordan Crouse , Sravanthi Kollukuduru , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Archit Taneja , Rajesh Yadav , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20241222-drm-dirty-modeset-v1-0-0e76a53eceb9@linaro.org> <20241222-drm-dirty-modeset-v1-1-0e76a53eceb9@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241222-drm-dirty-modeset-v1-1-0e76a53eceb9@linaro.org> X-Operating-System: Linux phenom 6.12.3-amd64 On Sun, Dec 22, 2024 at 07:00:41AM +0200, Dmitry Baryshkov wrote: > The drm_atomic_helper_check() calls drm_atomic_helper_check_modeset() > insternally. Document that corresponding restrictions also apply to the > drivers that call the former function (as it's easy to miss the > documentation for the latter function). > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Simona Vetter > --- > drivers/gpu/drm/drm_atomic_helper.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > index 5186d2114a503701e228e382cc45180b0c578d0c..f26887c3fe8b194137200f9f2426653274c50fda 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -1059,6 +1059,15 @@ EXPORT_SYMBOL(drm_atomic_helper_check_planes); > * For example enable/disable of a cursor plane which have fixed zpos value > * would trigger all other enabled planes to be forced to the state change. > * > + * IMPORTANT: > + * > + * As this function calls drm_atomic_helper_check_modeset() internally, its > + * restrictions also apply: > + * Drivers which set &drm_crtc_state.mode_changed (e.g. in their > + * &drm_plane_helper_funcs.atomic_check hooks if a plane update can't be done > + * without a full modeset) _must_ call drm_atomic_helper_check_modeset() > + * function again after that change. > + * > * RETURNS: > * Zero for success or -errno > */ > > -- > 2.39.5 > -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch