From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
Adrian Hunter <adrian.hunter@intel.com>,
Ian Rogers <irogers@google.com>,
James Clark <james.clark@linaro.org>,
Jiri Olsa <jolsa@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/1 perf-tools-next] perf top: Don't complain about lack of vmlinux when not resolving some kernel samples
Date: Wed, 8 Jan 2025 17:20:14 -0300 [thread overview]
Message-ID: <Z37d_pEDFJzw5u5R@x1> (raw)
In-Reply-To: <Z3xFbYjkPz_u1UeK@google.com>
On Mon, Jan 06, 2025 at 01:04:45PM -0800, Namhyung Kim wrote:
> Hi Arnaldo,
>
> On Fri, Jan 03, 2025 at 01:47:19PM -0300, Arnaldo Carvalho de Melo wrote:
> > Recently we got a case where a kernel sample wasn't being resolved due
> > to a bug that was not setting the end address on kernel functions
> > implemented in assembly (see Link: tag), and then those were not being
> > found by machine__resolve() -> map__find_symbol().
> >
> > So we ended up with:
> >
> > # perf top --stdio
> > PerfTop: 0 irqs/s kernel: 0% exact: 0% lost: 0/0 drop: 0/0 [cycles/P]
> > -----------------------------------------------------------------------
> >
> > Warning:
> > A vmlinux file was not found.
> > Kernel samples will not be resolved.
> > ^Z
> > [1]+ Stopped perf top --stdio
> > #
> >
> > But then resolving all other kernel symbols.
> >
> > So just fixup the logic to only print that warning when there are no
> > symbols in the kernel map.
> >
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: Ian Rogers <irogers@google.com>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> > Cc: James Clark <james.clark@linaro.org>
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Kan Liang <kan.liang@linux.intel.com>
> > Link: https://lore.kernel.org/lkml/Z3buKhcCsZi3_aGb@x1
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>
>
> Looks like an old bug since d88205db9caa0e9d ("perf dso: Add
> dso__has_symbols() method"). :)
Agreed, logic inversion, I'm adding the Fixes tag, thanks for finding
it!
- Arnaldo
prev parent reply other threads:[~2025-01-08 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 16:47 [PATCH 1/1 perf-tools-next] perf top: Don't complain about lack of vmlinux when not resolving some kernel samples Arnaldo Carvalho de Melo
2025-01-06 21:04 ` Namhyung Kim
2025-01-08 20:20 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z37d_pEDFJzw5u5R@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox