From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDC8B290F for ; Thu, 9 Jan 2025 01:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736386334; cv=none; b=TarN2HRQzXVrwzt1tvI1snk3FsVXsJlDTZa1GPKLoq8juTPu9Xw3N3uoWvHbfPvwpPkkFaeCf/lvbNOl0PEtTTjk19gp93mfIbNQODOHFudU4BBxRCumQ4DRlPIX4iNwYrEPPQ7pBUEIISoxRqf91EZELMKNlQMr4eePTQku2WE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736386334; c=relaxed/simple; bh=TqlrXvrQM7UKa7Sqrw0xGgYc0rEy693fa3LJNNJh5bM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Tb9ibZ5VNATwqGt7Erpqh5gsNRa/hMUgBOWEE+a4kTz1mItXWWPvUWLKF8eYlDpTnCPjTMnSPsOeHG2sQfURSsvMNSKYrsXx9Ng9q3KOUDtQDfVa+8Kiy9VN/ANN1KuYP8b0LIkZ9HNMEZ4pK1f4BkkPP8DYbeov6m7YOCDaqGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=DPyPkkVj; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="DPyPkkVj" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2efd81c7ca4so563736a91.2 for ; Wed, 08 Jan 2025 17:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1736386332; x=1736991132; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=NcMaIxB89aXYU0HrYQ/juYoMdoNOTBUAqo/G4Be15p4=; b=DPyPkkVj2yN50QJXQ9ZiRnT7f7OMu2Ff7hiKdqV6AfQkCiRse1ssCJizMhA0XvZoYr JfA2ncK/LHqgkewO/8I3z76cR4GOINfrapHxl+fIGSvORbT6EGXch00DuTyjp6thFvGq lV7eH56y33t1JcN/wyzt+WlmRWLxJ5EUw4K0zjAIPtYt2GW/FJ/bRHp75t3Qzc3sw2aN eBUI7nLLcotdt429UoWfO4Wg8yQ/E18zucGF0foJEA0ypoKT1J/4Pe2R2dAyo1BcMXe9 UFsMW4nDMiwc3f8z3OvfSsy/w1ks9D4M8jR0S9WuD0VZUKmSBHxmTEq2hTBuE8XBZgkK gUag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736386332; x=1736991132; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NcMaIxB89aXYU0HrYQ/juYoMdoNOTBUAqo/G4Be15p4=; b=rGvOionYFXpnz4lLwFsqcrh1H/wKkmKPVb8d7PdhaImzkZAIYZTL00c/7VlXEiVQCm Oq9JgmzXYEJZRHi2HBt7TmWfoAX6t1gGt3ey+qgpyFajQDtW3cl7P5wJXtcvAs6EqewP 8d9Fr8tgqN7ZMwpWJmuF0zOFu/tDYe8dwLalg8mx7SbAQT2WkTSK5mAxr1ieDkeHBLyM Gq/GxdLEbOoZrQTu/urkPzWGsxb6/XpABbTKzk/54amR36nAmIV+lknmyE43dWPbEXt/ dhTcmDGVaj84rcH2YJ2yMpRDWr15bvKZg1tcQFHIRCNYGLEGQtvvm3Q0z88h7UIGIcqw DriA== X-Forwarded-Encrypted: i=1; AJvYcCUEAwGreMJz2roo335YsgP6MIqdCerq6GPXu2S0iVUfvHbzW50koliXs1kXWfr/HSPGUAkG++AE07uTlms=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/9ZvjVulcEHBEcoCY6miYN/aB20bclC3piKdXObnw6B8OQBC1 wYMhE4fnhH6wpBz9FzUBb6XakGHVN7k0Crxqg7x+2AiIRaQH+2ZmILzU0/pnYZk= X-Gm-Gg: ASbGnctWiV04d/VXce6/JchI8Db19ypzLEwa3TTYC/M6atrLAXc/JJ9fiLZWK5pvvwm j76+DtXGzAoobCPpCgRrRYUi1VzP3H0ZwEJiHim1p/Xm1780/dNXajftRKU0pLDw32PJnFFWt2Z XAtdlFWcVSz1W3hWGfXQdJgfaVe9isiBDFxIQiMgRWosq8UsRDblrqirtvlRnSaFzHmrURN4npJ Q7VRC+uppcdqUcVUpibcFXEFmk6/mVe6QmGWaxoEbgl1oXgWQdybvpEX0hGyjGJCa9kukLclE9B IdOSCOTef6atN6NTlDpoVUYxcUHO6f9HtQ== X-Google-Smtp-Source: AGHT+IERItTVilccsc5DojWYe/uV0P+F6n8qrBNoNDpbE0qHsRtkGk1iJvW3sm5lRqm37ICkNdryLg== X-Received: by 2002:a17:90b:520e:b0:2ee:9d65:65a7 with SMTP id 98e67ed59e1d1-2f548f447b8mr7523880a91.29.1736386332228; Wed, 08 Jan 2025 17:32:12 -0800 (PST) Received: from medusa.lab.kspace.sh (c-24-7-117-60.hsd1.ca.comcast.net. [24.7.117.60]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-21a917441dfsm905895ad.96.2025.01.08.17.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 17:32:11 -0800 (PST) Date: Wed, 8 Jan 2025 17:32:10 -0800 From: Mohamed Khalfella To: James Smart , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, randyj@purestorage.com, jrani@purestorage.com Subject: nvme-fc: Question about __nvme_fc_abort_outstanding_ios() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello, I was looking at this code and I had a question about it. drivers/nvme/host/fc.c 2473 static void 2474 __nvme_fc_abort_outstanding_ios(struct nvme_fc_ctrl *ctrl, bool start_queues) 2475 { ... ... 2503 blk_mq_tagset_busy_iter(&ctrl->tag_set, 2504 nvme_fc_terminate_exchange, &ctrl->ctrl); 2505 blk_mq_tagset_wait_completed_request(&ctrl->tag_set); nvme_fc_terminate_exchange() calls __nvme_fc_abort_op() to abort all active ops with status FCPOP_STATE_ACTIVE. I think these active ops map to in-flight requests MQ_RQ_IN_FLIGHT. After blk_mq_tagset_busy_iter() returns it is not guaranteed that all ops had done callback functions called on them. Some of these requests might still be in-flight. blk_mq_tagset_wait_completed_request() makes sure that we do not have pending completed requests, but it does not check for in-flight requests? Am I missing something obvious here? Why we need blk_mq_tagset_wait_completed_request() here? Is it possible to have in-flight requests after the function returns? Should this call be moved to nvme_fc_delete_association() after all the requests are aborted by LLDD? Thanks, Mohamed Khalfella