From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Carlos Song <carlos.song@nxp.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
"moderated list:I3C SUBSYSTEM" <linux-i3c@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] i3c: master: Fix missing 'ret' assignment in set_speed()
Date: Thu, 9 Jan 2025 08:43:24 +0100 [thread overview]
Message-ID: <Z39-HEG6AaAFvDk6@shikoro> (raw)
In-Reply-To: <20250108225533.915334-1-Frank.Li@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On Wed, Jan 08, 2025 at 05:55:33PM -0500, Frank Li wrote:
> Fix a probe failure in the i3c master driver that occurs when no i3c
> devices are connected to the bus.
>
> The issue arises in `i3c_master_bus_init()` where the `ret` value is not
> updated after calling `master->ops->set_speed()`. If no devices are
> present, `ret` remains set to `I3C_ERROR_M2`, causing the code to
> incorrectly proceed to `err_bus_cleanup`.
>
> Cc: stable@vger.kernel.org
> Fixes: aef79e189ba2 ("i3c: master: support to adjust first broadcast address speed")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Precisely.
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested with a Renesas RZ/G3S-SMARC board with some test code added to
the still under-development controller driver:
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-01-09 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 22:55 [PATCH 1/1] i3c: master: Fix missing 'ret' assignment in set_speed() Frank Li
2025-01-09 7:43 ` Wolfram Sang [this message]
2025-01-09 8:50 ` Mukesh Kumar Savaliya
2025-01-09 13:04 ` Miquel Raynal
2025-01-12 23:04 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z39-HEG6AaAFvDk6@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=carlos.song@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox