[PATCH net-next] net: mdio_bus: change the bus name to mdio

[PATCH net-next] net: mdio_bus: change the bus name to mdio

[Yajun Deng]

Since all directories under the /sys/bus are bus, we don't need to add a
bus suffix to mdio.

Change the bus name to mdio.

Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
 drivers/net/phy/mdio_bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 7e2f10182c0c..20dd59208973 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -1425,7 +1425,7 @@ static const struct attribute_group *mdio_bus_dev_groups[] = {
 };
 
 const struct bus_type mdio_bus_type = {
-	.name		= "mdio_bus",
+	.name		= "mdio",
 	.dev_groups	= mdio_bus_dev_groups,
 	.match		= mdio_bus_match,
 	.uevent		= mdio_uevent,
-- 
2.25.1

Re: [PATCH net-next] net: mdio_bus: change the bus name to mdio

[Andrew Lunn]

On Thu, Dec 19, 2024 at 02:58:55PM +0800, Yajun Deng wrote:
> Since all directories under the /sys/bus are bus, we don't need to add a
> bus suffix to mdio.
> 
> Change the bus name to mdio.

Please add an explanation to the commit message of how this is safe in
terms of ABI.

    Andrew

---
pw-bot: cr

Re: [PATCH net-next] net: mdio_bus: change the bus name to mdio

[Russell King (Oracle)]

On Thu, Dec 19, 2024 at 02:58:55PM +0800, Yajun Deng wrote:
> Since all directories under the /sys/bus are bus, we don't need to add a
> bus suffix to mdio.
> 
> Change the bus name to mdio.
> 
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>

No. Just no. This is a user ABI breaking change. There needs to be
_very_ good reasons to make this change, and there needs to have been
research into whether anything in userspace breaks - and all that needs
to be documented in the commit message.

I think you sent a v2, which received similar feedback (I'm catching up)
but if not, I've stated my position on this.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!