From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1317218EBD for ; Thu, 9 Jan 2025 14:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736431977; cv=none; b=OrI6H505SdDv/OavaAzKrgsu/YoOamxgyQEPEACS4xwLK7kLFA18UNSd5ym2OHFkooHOirHy9qIIS79IjL0N3tyJ1XOU0AWZHeIWl+WwHnAtj7I6vxVgjqiWxsPK3sC1p8sTMnpoqZsZ3ZbxAO+oaHcy/pyl8eFMNEJvbMX4qaA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736431977; c=relaxed/simple; bh=2+kPAr0dvmHCcJWjxbEc5aC2Udav9z+QVmz7IcF6XTE=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EWEYnyc+r1T0ED95dAjZb3ZvSVCNqyqy86UjBRaVL0HoeIh1eXKlPEFdaTjqAWF01fMvKBBXFMx8IIqMY2XjN+uMJb94UB0c7qfVsk25Wb0ATcqIE8lMY2bzrghj9m/sjHf5Dwbczvqw3Q/KKyCQ5i97kgbVrI9ORKdk+yZkIQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Yzv2soNm; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Yzv2soNm" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5d3d479b1e6so1219215a12.2 for ; Thu, 09 Jan 2025 06:12:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736431974; x=1737036774; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=wlBu6Jl4eyQAszKaCyX1ruIoK5I/dtBYkp0OS6r+WLA=; b=Yzv2soNm0uBp2fUxOQWj9AGYLawzBswwdFnZVZg4SwuEFqtvM/USr9J/LJEg6EMwMC 2pFmK4gO5Gc9C9JgBdok3FICOHteEI+4lUwltS9wttnV+YW5vN5yMKQ6PHFy/FaRE2JN qfgVjHJ3mZp3BPlkiRiZwffeiY/vFDR1GS781O6u4tArk+cZ7pdc93YCx3KJpFxTVmY5 ABmlcLZcpfFqmt0x9Jr4L0kXVN5DmEHrHjOd/Uv3AXXWIHHI2xzZuHmuwyTHQjb9tfNG lv4olp0Lr7hwMQVdLgBL9CskOOqRyyPYo5i/Wkb21Ms8aAq8u3b7Qs5u7R/p6AEA9V0X bPyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736431974; x=1737036774; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wlBu6Jl4eyQAszKaCyX1ruIoK5I/dtBYkp0OS6r+WLA=; b=xJdDBPcIxp5UFySl8ySCmctxV7mAOHAG5vy6grz+CpPIkHpaBSdiooudRUjuHhYy/I vBZKr8m8sO+CSVj4A7Oh+6GCYX6W8DvS+PA0d6z9ZFheB/8e08UlnyTgNUQ0/EV7anTY ApEK1ij30xfhiat+qoHOkcUTMIdduszFd6BBbaVkwoKfmfyWlYrsPvO5pjHVW+OJXoq7 JyjmEzaKZTnK912FmzFGrp6i6RHFaRaW8seooa1OxpivpibMYxy+9R2jVPPtPtX67SLm nYvTEVLarS5Mxk+wpafcEdWvSHhFzLfjFplrTpGsEGn8Qh8hVN7r8LAoMSF/R6n5kYi8 HuAw== X-Forwarded-Encrypted: i=1; AJvYcCWkVuG9eFeUAldbEM9jy71ka+U+7yOIOsc8XTfh88QkA8aYsiL8GMvliBqSMd+Y9Gnwvy4ZqtebE2zOvpk=@vger.kernel.org X-Gm-Message-State: AOJu0YxvvTJm8R098LnG1NTSRWvo/VE/0sTgjYG93f74olAMTKM/JOdJ nqAIAWHepcUYDYmYRJWcRGNott0tTzIUqR6LM78WGbhkVIG1Qy+gi7/Bew9H2pE= X-Gm-Gg: ASbGncslP8J8dKlJcExgn4HvMmnDcZEj1eydF0o+EBrjk8pygkoxtLbjvEaT4eO8M04 ESSVA8MirT8bKQ0QBlfaCLlS4TBq0UU5Gdjzaju3CV2Kpo6AQtxT30yH4GIqP3My5k5yrNt2bhU jIBuagcfvzw6vL2m6tS/nI646nQLRIyxH69X7rE8bF1m5Rm67YvhCqnHSB5Zc+WVxDctZWNExHE BSEVomEUpo1S+NExkgYpI3Hw94dZZCUHocaZEUGXq87nt/5uXaF/UESCnRQQn+EkBFnRdi4vIhm 6wLB4n8Mz9EeKLU8iYYumdmCcHt5Ag== X-Google-Smtp-Source: AGHT+IEOXSEbBA1axGYMcra+RQ2TbWnh4xp8zHitSs1AcfUx4imSb6e/9u6/B80hfC1lQxS7w4XDzw== X-Received: by 2002:a05:6402:530f:b0:5d1:2377:5af3 with SMTP id 4fb4d7f45d1cf-5d972e00027mr14520603a12.5.1736431974259; Thu, 09 Jan 2025 06:12:54 -0800 (PST) Received: from localhost (host-79-40-232-186.business.telecomitalia.it. [79.40.232.186]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c90e8888sm75783566b.80.2025.01.09.06.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 06:12:53 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 9 Jan 2025 15:13:42 +0100 To: Andrea della Porta Cc: Rob Herring , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v5 08/10] misc: rp1: RaspberryPi RP1 misc driver Message-ID: References: <28fe72eec1c08781770cee65032bb10a6d5994a9.1733136811.git.andrea.porta@suse.com> <20241210224837.GA702616-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Rob, On 15:08 Mon 16 Dec , Andrea della Porta wrote: > Hi Rob, > > On 16:48 Tue 10 Dec , Rob Herring wrote: > > On Mon, Dec 02, 2024 at 12:19:32PM +0100, Andrea della Porta wrote: > > > The RaspberryPi RP1 is a PCI multi function device containing > > > peripherals ranging from Ethernet to USB controller, I2C, SPI > > > and others. ... > > > +#define RP1_INT_ADC_FIFO 52 > > > +#define RP1_INT_PCIE_OUT 53 > > > +#define RP1_INT_SPI6 54 > > > +#define RP1_INT_SPI7 55 > > > +#define RP1_INT_SPI8 56 > > > +#define RP1_INT_SYSCFG 58 > > > +#define RP1_INT_CLOCKS_DEFAULT 59 > > > +#define RP1_INT_VBUSCTRL 60 > > > +#define RP1_INT_PROC_MISC 57 > > > > Why all these defines which will never be used because they come from > > DT? > > > > Right, those defines where originally designed to be included from dts, but > previous discussion deemed interrupt numbers to be hardcoded instead of being > specified as mnemonics. In the driver source code I just use RP1_INT_END as the > number of interrupts but I thought that the specific interrupt numbers should > be documented in some way or another. Since no one is currently referencing > those defines, would it be better to just turn those in a multiline comment > just to describe them in a more compact form? So, here's a couple of proposals about the interrupt defines: - since they were banned from devicetree, and are not used anywhere in the code, turn them into a (admittedly long) multiline comment, so they are still at least documented - since they were banned from devicetree, and are not use anywhere in the code, just drop them, we don't currently need them after all Not sure what's the best way here, anyone can advise? Many thanks, Andrea