From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B20EF1ADFF6 for ; Thu, 2 Jan 2025 13:06:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735823206; cv=none; b=uyAJf7S4eewJkHqdRUll5Hgddf4UmWuKCRw1PflYkPmbdMOiaa93nXekP9Eyby9l1e5rM3boMYhTAXVKBrOKEuWMc9baDxfh+X2u7rOr8B5xPqxC74E2yRyewssdewNuoZX+x5bT1SjMqZ+qWzUNvVT6FEAljLmZ2DHAc7t1h9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735823206; c=relaxed/simple; bh=okPhzHKZwSnBnr+JyEP/BuCmjowStk3XeeC8NmwJhmE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZX+nxjjrgyqToCRJSAvo7DAGnk8D6TJrrksvUjNaV5+gj9sVlMdJ+OjmVmYv0aJaH6QcUYOv/vyL9Qr1weWC+IkCB1qRSJr3ApSol4SmoAWt+IdrcxhmnMP9yZvEjCZt1ltB7yfSkJH42ClfdzZIpbpqoz8px1W8y79rSOSo1jQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TqvMD0+V; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TqvMD0+V" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-436a03197b2so29675905e9.2 for ; Thu, 02 Jan 2025 05:06:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1735823202; x=1736428002; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QwWQjY7eg9shlfr3qhPfsf98UOxBUnEIZuJxINmilJo=; b=TqvMD0+VUZVlFklR+7vnMQIIxjk2N9LX5nY2WgIu7XZRATJhSRv8JKzOz3nV4JN/45 VV6Bw0gI/fWOY4kiPUKu8RoTdpQRApn9/Z5DZ7/qJzlY8GBodjkwZ4yzefQURVgJU9kd d05k1caPIff+n5oFD+2T5cJ01i+d2tTWJU9s8PWZnqumlGOrJwIf4JyBsHFLl7qvgcaA wlfswBmA4zi6b8xxkTjrcJ34KeoXPc/w2DN+3FfOk5jhXYzvMVn67BuSPH3WxcWUwPIn U7ui6zMgmpzLONL96mXC1lOhkU5XkdE7WdJKBUFHaGqE5KzM5KdSpA9uCX/cHvrawkWQ YtgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735823202; x=1736428002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QwWQjY7eg9shlfr3qhPfsf98UOxBUnEIZuJxINmilJo=; b=geCNLRwWWzTwc3LmvPjkDKWsz1djJ0f2UT8RZ7gs83gl1bm3yPlUQ/zP5YiB6FD+Rh E/GB/RmMRYD1wqqOELGSJSOcnbr4Il2RiEQ0cSj18KD4v6JgGb6l74CmLPPGkBcj/fE+ SHLmAPv/VazdDPBEoQb+6W+NR3EigrF8RuHEZL2OWNRFqhPKp6Yb+FP4nS3d5WI5CUun D13KIYt60KVkNDKtDlb39yj6M44hhSK6Y2sfE5Q0NcG6Wi0jVNFIwjWTBSGrsGRIJEZE 7KpofNQwtqOahw+keSxxWnfhg1FMwO3aHZAc2ZK54lh9nMkcGu8ns9BeCMosdyC13aVX T1HA== X-Forwarded-Encrypted: i=1; AJvYcCXgQcZ4rE6DyX7OLnzvKPjIbRiYvMZy7GmZnX1wypZ+FFBKzlfIzkKehLnvq8V5QuR6THu1qwBQUtoAiBU=@vger.kernel.org X-Gm-Message-State: AOJu0YwPf7HCEDLjnbKBWDK1PNt88tvr9iuybgdbFJ4Ea4dGpZ2HlxWv UJe8s+dv6cTXD8oDH4DiEuiFP/YRIxUIk2Q8rlBUFDyCEj5C/6wp3BVPfIrDnd4= X-Gm-Gg: ASbGnctI2e8DISxObk0wNnU5zHF2RRF/SSCZ355cW/SokQQBgN8QK6XcpKsxfKgXgcf p68vEuwO5RdstTNCciQ7RiBtoLeO7dssUc4m98be4yuuw55xMgKU3yGpjrxFZ6x4uZOgeZlTXfK dZL3VhUEQc7jIqIGzv30gtXSdwP4A91dn+QncJtIHxTO2CkHCDlCSfppHoQz5OtrGp/UhlGZsk1 0tvFg6Cb8vW3TvLsHcKUDXYevmYr3B86Ynkyk5vSs6Bni6sFB6YC0Pu0Q== X-Google-Smtp-Source: AGHT+IGbAPNnwVSa4laD20KJjG9xXhqX/JBOhxU0k/AK/PW0K07dro8G76+BCLcrFDNvyKXd3AGGyw== X-Received: by 2002:a05:600c:1f85:b0:434:f2f4:4c07 with SMTP id 5b1f17b1804b1-436686464d9mr422782235e9.15.1735823202011; Thu, 02 Jan 2025 05:06:42 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b3b295sm493767545e9.33.2025.01.02.05.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2025 05:06:41 -0800 (PST) Date: Thu, 2 Jan 2025 14:06:39 +0100 From: Petr Mladek To: Rob Herring Cc: John Ogness , Linus Torvalds , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Saravana Kannan , Andrew Morton , Peter Zijlstra , Thomas Gleixner , Zijun Hu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: lock in vsprintf(): was: Re: [PATCH] of: Add printf '%pOFm' for generating modalias Message-ID: References: <20241217183711.2525863-1-robh@kernel.org> <84wmfxm6em.fsf@jogness.linutronix.de> <84o7171o9y.fsf@jogness.linutronix.de> <20241230202643.GA2488017-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241230202643.GA2488017-robh@kernel.org> On Mon 2024-12-30 14:26:43, Rob Herring wrote: > On Thu, Dec 19, 2024 at 08:17:21PM +0106, John Ogness wrote: > > On 2024-12-19, Petr Mladek wrote: > > > I do not want to revert everything now just because of theoretical > > > problems. > > > > What would you revert? This has always been an issue for printk(). > > > > > Well, it would be nice to document the lock dependency in > > > Documentation/core-api/printk-formats.rst > > > > Yes. If any locking is involved at all, such specifiers should be > > documented as not safe in NMI context or within printk_cpu_sync > > blocks. > > For the folks that don't read documentation, should we bail out on > in_nmi() for these as well? I like this idea. Best Regards, Petr