From: Niklas Cassel <cassel@kernel.org>
To: Krishna chaitanya chundru <quic_krichai@quicinc.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Konrad Dybcio" <konradybcio@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
andersson@kernel.org, quic_vbadigan@quicinc.com,
quic_mrana@quicinc.com
Subject: Re: [PATCH v5 0/3] PCI: dwc: Skip waiting for link up if vendor drivers can detect Link up event
Date: Thu, 2 Jan 2025 17:42:23 +0100 [thread overview]
Message-ID: <Z3bB79Wu2U6-65Z4@ryzen> (raw)
In-Reply-To: <20241123-remove_wait2-v5-0-b5f9e6b794c2@quicinc.com>
On Sat, Nov 23, 2024 at 12:39:58AM +0530, Krishna chaitanya chundru wrote:
> If the vendor drivers can detect the Link up event using mechanisms
> such as Link up IRQ, then waiting for Link up during probe is not
> needed. if the drivers can be notified when the link comes up,
> vendor driver can enumerate downstream devices instead of waiting
> here, which optimizes the boot time.
>
> So skip waiting for link to be up if the driver supports 'use_linkup_irq'.
>
> Currently, only Qcom RC driver supports the 'use_linkup_irq' as it can
> detect the Link Up event using its own 'global IRQ' interrupt. So set
> 'use_linkup_irq' flag for QCOM drivers.
>
> And as part of the PCIe link up event, the ICC and OPP values are updated.
>
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> ---
> Changes in v5:
> - update the commit text as suggested by (mani).
> Changes in v4:
> - change the linkup_irq name to use_linkup_irq a suggested by (bjorn
> andresson)
> - update commit text as suggested by bjorn andresson.
> - Link to v3: https://lore.kernel.org/r/linux-arm-msm/20241101-remove_wait-v3-0-7accf27f7202@quicinc.com/T/
> Changes in v3:
> - seperate dwc changes and qcom changes as suggested (mani)
> - update commit & comments as suggested (mani & bjorn)
> - Link to v2: https://lore.kernel.org/linux-pci/20240920-remove_wait-v2-0-7c0fcb3b581d@quicinc.com/T/
> Changes in v2:
> - Updated the bypass_link_up_wait name to linkup_irq & added comment as
> suggested (mani).
> - seperated the icc and opp update patch (mani).
> - Link to v1: https://lore.kernel.org/r/20240917-remove_wait-v1-1-456d2551bc50@quicinc.com
>
> ---
> Krishna chaitanya chundru (3):
> PCI: dwc: Skip waiting for link up if vendor drivers can detect Link up event
> PCI: qcom: Set use_linkup_irq if global IRQ handler is present
> PCI: qcom: Update ICC and OPP values during link up event
>
> drivers/pci/controller/dwc/pcie-designware-host.c | 10 ++++++++--
> drivers/pci/controller/dwc/pcie-designware.h | 1 +
> drivers/pci/controller/dwc/pcie-qcom.c | 7 ++++++-
> 3 files changed, 15 insertions(+), 3 deletions(-)
> ---
> base-commit: cfba9f07a1d6aeca38f47f1f472cfb0ba133d341
> change-id: 20241122-remove_wait2-d581b40380ea
>
> Best regards,
> --
> Krishna chaitanya chundru <quic_krichai@quicinc.com>
>
For the series:
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2025-01-02 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 19:09 [PATCH v5 0/3] PCI: dwc: Skip waiting for link up if vendor drivers can detect Link up event Krishna chaitanya chundru
2024-11-22 19:09 ` [PATCH v5 1/3] " Krishna chaitanya chundru
2024-11-22 19:10 ` [PATCH v5 2/3] PCI: qcom: Set use_linkup_irq if global IRQ handler is present Krishna chaitanya chundru
2024-11-22 19:10 ` [PATCH v5 3/3] PCI: qcom: Update ICC and OPP values during link up event Krishna chaitanya chundru
2024-12-23 6:55 ` [PATCH v5 0/3] PCI: dwc: Skip waiting for link up if vendor drivers can detect Link " Krishna Chaitanya Chundru
2025-01-16 1:57 ` Krzysztof Wilczyński
2025-01-02 16:42 ` Niklas Cassel [this message]
2025-01-15 11:19 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3bB79Wu2U6-65Z4@ryzen \
--to=cassel@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=konradybcio@kernel.org \
--cc=kw@linux.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_mrana@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox