From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C709155322 for ; Fri, 3 Jan 2025 03:20:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735874417; cv=none; b=D5x05gN9jBEQq2ZC+NTD0dCwvKcdna1rSOo57GWztH5nnhdYbBw+GBaeNBOCJ54qkEBf/KDX33gmswHsFdEJyAkJlg9gD6Ru4dI26kS1KjPU17dm+6/vsRXUfAlHbxQewHcpttNIoaIVEOC5QARPEdvtKVUO22O1LAWKtsT6tv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735874417; c=relaxed/simple; bh=XZDthz/V/ZiEqlAcwYPLa5Gag0LMiz2/PnP2KGU0f3c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VcQBf6sBrhUnTLl0bOTgrEhMcofV+RlDJVg55vV0bK/8JWCB/CfuBx7K6tRVQoC5NIHgc70J5+bFGJEx8a+UCwjhgArh1lZHmtJQwsTMjIwkULaToZ7dAmV4Q7XkvX6SnRmjtRdgR0UnKpZ98YbAcm7MDbkHvR5QRIlkMRE0qG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=minyard.net; spf=none smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard-net.20230601.gappssmtp.com header.i=@minyard-net.20230601.gappssmtp.com header.b=qoPx02BO; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard-net.20230601.gappssmtp.com header.i=@minyard-net.20230601.gappssmtp.com header.b="qoPx02BO" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-29e5c0c46c3so6123499fac.3 for ; Thu, 02 Jan 2025 19:20:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard-net.20230601.gappssmtp.com; s=20230601; t=1735874415; x=1736479215; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5rnDHCeVOhcASBhii6Cfw8DGHqfc5aMSozqh3rmlpCE=; b=qoPx02BObOGJZRvlzN+mz1jyLzy13F8luSuP1BUA9zbSYjBN2k0rWn9aZQhd4StNQG a1g+F/npPlmR8pOlUSaF1G6QVQ5SUcCDcABxtnER/1tuTJXbY30RxBxhAGGe++zpwjDb BfRbxJOofaVde/LFwrtQu449If6+z6hArl32At2skC7OJe+Hc8jYrn3qJPlOru5T90uD Cl1AQv26blbxj3Jym6NkOH+ZWejvwi96haraPmuDrE0KuB4ooJ2ZmEmWiwCdpnDy6cZC INKiLhBAR/bUjNYOjOb0/H4QHY9dfwG6eazvFhV4xbr1Z9PO5VvSmhI54jFwVx6xfVvE tuxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735874415; x=1736479215; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5rnDHCeVOhcASBhii6Cfw8DGHqfc5aMSozqh3rmlpCE=; b=P3hhpEuuyt2bB5HBTt1pnLkOoocx/MuzEdeNUggYZoxeLMpbDLaaBnjuY+UKMle6Pz vrrqxddQteDkfuC8tu/121viXsavv5WMl5QSChBKY8M1mnyTHBmYKXXkF5r7ca4OGaP8 taiknjvMBk9m9gcAbE4Y5jtFkA2O6UWSTmTNAe75roYA5SDWk3mBr/qHYaiEjKe0IXsm opID3cr9tmJHp3UZT6RsLymVrJTH+Bnn+PK6+z8UZ2AY3TiiiF9nKzKS5x3RqIqbz/Kp oP+C7Qoyyi0dWeiAiow8gQVfEM2Gp8ZNMUL3kXoj4+/4ROsFxRoGDaNS3eXXjHzgD+CI GkTg== X-Forwarded-Encrypted: i=1; AJvYcCUqQ+A1I9nm9ohc72oSdWZo+LkoknD1UnZVPtk71Jb3Mib4DuAo9sQACjahrX5LBlpKpii8nJWGOVL4NDU=@vger.kernel.org X-Gm-Message-State: AOJu0YwR+fk++fFcfHg1ZZdn0UvRo10KgRTfdt9mPnI8wFiCejmbfSHh Dx0MPXnZU+Cjju7NdfmkszSownbAUqdmPLmB2xSyjfR5svjrIF8eqH85Mr/hj5Q= X-Gm-Gg: ASbGncuIIxFgZu0fYF6t+LVlDkcOmN9SmH52Tao5HQpxJqIVj+Qu3AV8CvpRRyrh8UJ tuLAwZrF4DI7fCDQpBXJ/2laKKzDsKGUp7b4k2GRcXKMhVnuQlvJ3WhW2scwgermpiShJhHOCWv eU88TwMkd8Ney0q2wezg2tsEZBoDXvRLjSZh7PuT4XXLOhW5rHaV5xCGCycvi7IsRI+mYYsbB6W ANxr7rBA+yr/6/DFM09W8eYQVA8silszatpvjxERYNEzVjEm6lLUd3DCzNX X-Google-Smtp-Source: AGHT+IEyXSjph+/pYcsKC+/1wwAYZ4l/FEii+50iKcIiE37HIWxy0McfM5MaXdZlXTOORMrzB6TBkA== X-Received: by 2002:a05:6870:f615:b0:29e:671b:6019 with SMTP id 586e51a60fabf-2a7fb4c9d10mr27130592fac.31.1735874415134; Thu, 02 Jan 2025 19:20:15 -0800 (PST) Received: from mail.minyard.net ([2001:470:b8f6:1b:81ab:b2d6:d879:cada]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2a7d7453f76sm9533454fac.9.2025.01.02.19.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2025 19:20:13 -0800 (PST) Date: Thu, 2 Jan 2025 21:20:08 -0600 From: Corey Minyard To: Cosmo Chou Cc: minyard@acm.org, quan@os.amperecomputing.com, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, cosmo.chou@quantatw.com, potin.lai@quantatw.com Subject: Re: [PATCH] ipmi: ssif_bmc: Move smbus_cmd assignment after cleanup Message-ID: Reply-To: corey@minyard.net References: <20250101165431.2113407-1-chou.cosmo@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250101165431.2113407-1-chou.cosmo@gmail.com> On Thu, Jan 02, 2025 at 12:54:31AM +0800, Cosmo Chou wrote: > Move smbus_cmd assignment to the end of process_smbus_cmd() to ensure > the new command is not lost when complete_response() is triggered. Ok, I see, patch is applied. Thank you. Quan, I assume this is ok. Please double-check it for me. -corey > > Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver") > Signed-off-by: Cosmo Chou > --- > drivers/char/ipmi/ssif_bmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c > index a14fafc583d4..7a4f52987a7d 100644 > --- a/drivers/char/ipmi/ssif_bmc.c > +++ b/drivers/char/ipmi/ssif_bmc.c > @@ -579,7 +579,6 @@ static void process_request_part(struct ssif_bmc_ctx *ssif_bmc) > static void process_smbus_cmd(struct ssif_bmc_ctx *ssif_bmc, u8 *val) > { > /* SMBUS command can vary (single or multi-part) */ > - ssif_bmc->part_buf.smbus_cmd = *val; > ssif_bmc->msg_idx = 1; > memset(&ssif_bmc->part_buf.payload[0], 0, MAX_PAYLOAD_PER_TRANSACTION); > > @@ -596,6 +595,7 @@ static void process_smbus_cmd(struct ssif_bmc_ctx *ssif_bmc, u8 *val) > if (ssif_bmc->aborting) > ssif_bmc->aborting = false; > } > + ssif_bmc->part_buf.smbus_cmd = *val; > } > > static void on_read_requested_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val) > -- > 2.34.1 >