From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D21F31B393C for ; Fri, 3 Jan 2025 09:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735897857; cv=none; b=dpWJQ4afd27dOP7TxFg9+GrdH9o8xpup82+L6QKoOiFrfPJupsTidRWaTEaDc2+leelKgC7pGiCbikM5vIfduMZGpowhSj6VHSUcqA5f3Zc2ELE61wZOkHwPRfKKV43tYh2xitJ4E9qtY5tARkg4Grh9NbP9wKBlPh0jE233vMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735897857; c=relaxed/simple; bh=H2Tn3QQHdE8KgsAg7KeLhSP8MekEW26c5Lb3yvzZBfk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jT/Iuv6hD1F/a/+TLBwVQ8NtZR3os8YFtCTZPlWZ50rhY/UCD1Keqi0PrDRcS+K6dxsmk03LrkgizyU5LinUyG126EkfI21vR1wbMRAhHfVnXw8mC/LPpEbglj17ZHda0ymaWct8+lrtYuLy7lytxT66S+zwmGFmcteeadnJyCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Etyo59Ly; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Etyo59Ly" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34419C4CECE; Fri, 3 Jan 2025 09:50:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735897857; bh=H2Tn3QQHdE8KgsAg7KeLhSP8MekEW26c5Lb3yvzZBfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Etyo59LybjO+m6PwWqogt5jV5ePBKAmKrl0/CGxdM7uWD+yzw3QYVBUqkFDXQA8fq RfJVIo36Rb4K2NPHTtX+aIJK/RWGRAHucOUG6iYB0WVBSQwa9wgDshk93EBPnZcA0o N/5WZhwGOd5qu8cbgkWlIGmBHx2sJlRWyZ+oWxtRxEkEvaglUfwN2d1ObVD8aRUjfv C2pSfQCq4B1zmI2ijXOlxznBDW23JA3P9nCNkjOrHsJXJWL2CcQC10mDSp8LolquAM M/3511Hs4sXQQgI6mDmzJvXMD5dRMha//VHwCV+tkBCmS3KlI4QHaDAJgOz7KzY8ZU m+m2KCfIfBO5w== Date: Fri, 3 Jan 2025 10:50:53 +0100 From: Niklas Cassel To: Pei Xiao Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] PCI: dw-rockchip: remove redundant dev_err Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 03, 2025 at 03:04:52PM +0800, Pei Xiao wrote: > dev_err is redundant because platform_get_irq_byname() already prints an > error. > > cocci warnings: > drivers/pci/controller/dwc/pcie-dw-rockchip.c:454:2-9:line 454 is > redundant because platform_get_irq() already prints an error > > so remove redundant dev_err. > > Fixes: 8719dbc54668 ("PCI: dw-rockchip: Enumerate endpoints based on dll_link_up irq in the combined sys irq") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202412312343.najrW1Db-lkp@intel.com/ > Signed-off-by: Pei Xiao > --- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index ce4b511bff9b..a9795866e915 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -458,10 +458,8 @@ static int rockchip_pcie_configure_rc(struct platform_device *pdev, > return -ENODEV; > > irq = platform_get_irq_byname(pdev, "sys"); > - if (irq < 0) { > - dev_err(dev, "missing sys IRQ resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_threaded_irq(dev, irq, NULL, > rockchip_pcie_rc_sys_irq_thread, > @@ -504,10 +502,8 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev, > return -ENODEV; > > irq = platform_get_irq_byname(pdev, "sys"); > - if (irq < 0) { > - dev_err(dev, "missing sys IRQ resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_threaded_irq(dev, irq, NULL, > rockchip_pcie_ep_sys_irq_thread, > -- > 2.25.1 > You did not CC: linux-pci. Patches for drivers/pci/controller/dwc/pcie-dw-rockchip.c are merged via the PCI tree. Please send a V2 to the proper list. Kind regards, Niklas