From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C89EF1527AC for ; Fri, 3 Jan 2025 11:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735903140; cv=none; b=eZiDhc4wYRilLbvUdrIrHKkK/wdh8WrVX7cECuWlYgO/e2p+5opiqlkwY5P8LdFPqff8qfUbSO4vkKnO/lHl6kX9tmPAZDGi6Wob7lxnfZ6GHu4uTdz4xqZVO6znXk0fCo3WFt1W6+tH/IMLAf2amA7EoV4sH/yfQAvbvSplwYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735903140; c=relaxed/simple; bh=iv1ecZ0oga8ifZpHznoElzsE/Av3WnNwxt7tjkScA7I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r5ug7n526kuQokbBxxU6hvRX+21u7Yk5PrwMJSR0LllJ3peDbhQsTuYvZ5+olQHKjyvepmgj+NpWupudSprWiSG4FVB+pBoWpf0+ucbp8W4oNiygTZ2aS0n5fbhy3F+6v/KQcDNOV7UZgvG4oZiDJSDPs9camo4X1RG6mN0Fyww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Il/KEJ19; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Il/KEJ19" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43618283d48so88279165e9.1 for ; Fri, 03 Jan 2025 03:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1735903136; x=1736507936; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OQppFz7LylosxCTW/9ZVy9Kacnt0MCt8fPDuV2Ypyb8=; b=Il/KEJ193Mub9mhr3l/8xWo6lR4z/1GUy/Lvgsgs6p0+2A3gT5hL+8C6whPo9nEsCJ BQE9frCJE9vpoq9v30eRJmGg0k9k1fBFdQ+xsxyVaEBxdW0nRPoyCIds3OiVwnlmnnAG al+7SondTYKHiP4Bd+KFwYGnlnIImtto5Z6h+xHmSge8w7EMgYQhi6a23cxKyG3ytjxW aFRoJwXm0kuw6TpPNWYNHza1fcKzW1SboRUgBx+aMrkn8+xUfZMxi8dlXMEfnAek5b7j Anjiss4vliPamYrnhAbcU9yuXMUJXB2Pgs1GsRYe1cVmltdXK1doiqonZs3K33SC9i0i mffA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735903136; x=1736507936; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OQppFz7LylosxCTW/9ZVy9Kacnt0MCt8fPDuV2Ypyb8=; b=tTfuLzpNeyhKWipqFBFAxFFZG791ieJozfDUiRgRd3BBIpSDAejkbrdt7SNeNDUaOD aiy6/wXfnE6S/OkI3/pMPFjpm5701EK70/jhUlBiik1AYaGo3/gUlpkVBFNMgmIbhpbQ uada20bhji/o7U00HYrKxd8mUF4f7mur193h9eaAuigrIMPhQM722TFcSRJws4clmBh1 KOPK/MdKMJxz6Gmyn9ZRM20CnL15NQ/cuqcDjD/vCikioSOVRARN5Klhcz4Kj/HV6CEl Rsazuq/wBwuVsCeAJfyBqkii1m4b1RmVS75UEb4rCAuVm5fRd/1asVjkrpJwVQSoy8gI sjGQ== X-Forwarded-Encrypted: i=1; AJvYcCVm0BCJ/2jvOJK9+klndfubH0jo4IcM0575wtGtWpfue/22vn/8cCPJqDNreHezW0j0l4vb77r1D5RHZKw=@vger.kernel.org X-Gm-Message-State: AOJu0YybiYevgNi5EMfTM0gxsE0dDIFmhcPELG6DwT0nlbJG+NRaHie0 US91dYzyZKw0rqTnyy0PdZVXvbJYFdgmRZWZCNRAC1lxySo14EmGe++Ipsqe0Ls= X-Gm-Gg: ASbGncuofTOnAmiXx98DWioh9mM7pjbGY+1/t01Zs3t2Mg5JRoMBDp6gFKQgAVzZ5kL tO924bIakt6Ul7h2dXC6yzhaFpo9Tz3BuBkys85eX3TFH6fl440xcxSKkPAgHCodZqjVbPq07gP GIOjRjmE6b2jaoSFCFw2V6dpShgNN02xDAiBUNpvN9Bofb+YKq7t1dLpV/0LmWmkpjQFg6dVDZh c63zDORUbpqsd+4ctjvDqVtRsORie8JQ8ok2LLGqFFfaIwq7pIe4K1LLQ== X-Google-Smtp-Source: AGHT+IHIzKRySngKIdsX5MXXxtZ66zKTRho8isEjBhPejn+RjlVrqd8HJLW0nNhdNjbTY53Oz02ZIg== X-Received: by 2002:a05:600c:35d2:b0:434:a929:42bb with SMTP id 5b1f17b1804b1-436686464cemr444893925e9.18.1735903135958; Fri, 03 Jan 2025 03:18:55 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4366128a44fsm478127005e9.43.2025.01.03.03.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 03:18:55 -0800 (PST) Date: Fri, 3 Jan 2025 12:18:52 +0100 From: Petr Mladek To: John Ogness Cc: Greg Kroah-Hartman , Jiri Slaby , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , Esben Haabendal , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Arnd Bergmann , Rengarajan S , Niklas Schnelle , Serge Semin Subject: Re: [PATCH tty-next v4 2/6] serial: 8250: Use frame rate to determine timeout Message-ID: References: <20241227224523.28131-1-john.ogness@linutronix.de> <20241227224523.28131-3-john.ogness@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241227224523.28131-3-john.ogness@linutronix.de> On Fri 2024-12-27 23:51:18, John Ogness wrote: > Rather than using a hard-coded per-character Tx-timeout of 10ms, > use the frame rate to determine a timeout value. The value is > doubled to ensure that a timeout is only hit during unexpected > circumstances. > > Since the frame rate may not be available during early printing, > the previous 10ms value is kept as a fallback. > > Signed-off-by: John Ogness It makes sense and looks good to me with and even without the changes proposed by Andy: Reviewed-by: Petr Mladek Best Regards, Petr