From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C23BB1DCB09 for ; Mon, 6 Jan 2025 12:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736167556; cv=none; b=PMSnfeGPev0LRnF4TIkKa5NPM3kRuDwinDuuV2sZnmR/BtxOshIUVsXl8mLNL+ms7gjTFqk2OKoxBdSKvMKdZkysQ0ILk8V7o09sgTRaDLnlXltD6BCJZeNZV/70Sf4uKot7SPfrv21bRHieGH9L4Dh+JQqXQ+D7/pekMQJi7WQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736167556; c=relaxed/simple; bh=fd7zdlxTAGFRBS7rqsaz7guw5qHgt0UMqK/lopJACT0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZEFSfPZAZ+IM/VE6/5PyDv38LgYut26Ru5kn5p3N+G2sW67c3HJE3rluPlUEAUBXxb9FDfB45rube/wi2ojbO0xQ3R1lRGjRgBFd+V6hadwZWTeWxILry9eME6rr/aUTUZTo4+JlX+kvXwn54vHyYZSoJs9ZVEv3AIAepvZhG0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SCf5WWz8; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SCf5WWz8" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3862f32a33eso6473156f8f.3 for ; Mon, 06 Jan 2025 04:45:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736167552; x=1736772352; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M2cI20yQvFh0oTzvXey8G3cCYkJTkl8Kp3cskcOiadM=; b=SCf5WWz80v4RQr1XHjrA0yKWGzYLavXAfbQXQ+5h68kG5hpzqyvJYK00kgiyh+G6UU A0VI9BlZJc84L8fFXUBty0oY97hsJ1KTwPzAF5tHpzpfgQbaCQAEt+YUBf948capUvXU Zb/ISigP+7YBcwB8zakEf4nbv7NYaScD4j0Fwueht/6TKHIlPsMVy1aXj/AB74Hh6gjL Gl9fUESZu62zpT9g9b82HyNlkaB/Me76GndsAVBZFz59JjqzRhpT8WkdUzh+WGS9p7IE sQx6FNStGknBl5i7KJsLhKPUM+w+PVsaTfd4hl2SpW9w3rsYqWDMLDPDXzQvFMnfGcM2 MffA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736167552; x=1736772352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M2cI20yQvFh0oTzvXey8G3cCYkJTkl8Kp3cskcOiadM=; b=fAaSw8fJ/TAEiJPrIVxf8JQ36P7+aHfsKfNZUbRo9PTCDXMrByLNqp7XJ9n+NMBIa9 aD4UlL3Owv+kxs70UTcP47/j/ywW/pJ6R6BWWgXXP2E9b03GNH9hKciQQxEtQ2/ImYvq lqwVLOuFjqAK9aV7bkE29/bUvEJ588xbDYnqDvGNMCkRmaaPzb4HgH/Wdfv8e4h11N2Q pbyFIxeagjyqqm1/IdNNqsG1F45EY1X7DFMn3IRsvXCapVQffwaI+sVLl3Z4wdvx6pSH F/M7bSO+awxtTeOfwBNi6fQ6TEyfkBjG5G/rVy9OfX7pUnf5Jm/NOwjyRKhazZkiuoA7 lXNg== X-Forwarded-Encrypted: i=1; AJvYcCWU4vHt6qH2Kru6vo89UDcaphr4HVDLmbrGLiVAzd4uhineq3g9HAbU9S1UWps65Q2r1mNUZNAziacOB10=@vger.kernel.org X-Gm-Message-State: AOJu0YxA6GGRLg/bjkwkEQpAJPmizPtC3rFdStxR6qGW+1kN65jqVo0i H34Z7qJ+hCMqA9CEGwj9znpsNpPJ2Cne2xv1qzqDr2zG4Uk3HIKF2KspmOagZeo= X-Gm-Gg: ASbGncsvzkbjXZALYLoahmSFs5cToqnzW0s9Xo/rw4qqRchwlC+C5ejjtcW0Ptcz5kz diI0uf0LxIfKqG+vQ7l73CcC4AK8XEwyitmYx6SfvrrT8MKHsMgzjg5N0H0jfjvqWCU46jR2sT0 STyLjD9M7tHy1X6TMppDotvxnyt09gQDDUWgiOWjTMsR7VSdf5OmOTQ5TLfesIsGIO+KcLDPihF Zmz8LA5yeZWBL7iGHfmaU6YVnXnTV/Cvtts8+rLM+VZI+Vl3VMuCkg= X-Google-Smtp-Source: AGHT+IGPXXCGpVVL8gkklF9ZQV+if58UuE9ZivrnPJUbIt2RzTzppNgGN6AJ5opvpHjGWhdKOASxmQ== X-Received: by 2002:a05:6000:4b07:b0:385:fa20:658b with SMTP id ffacd0b85a97d-38a221f6135mr46513894f8f.24.1736167552118; Mon, 06 Jan 2025 04:45:52 -0800 (PST) Received: from linaro.org ([86.121.162.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b4274csm603466965e9.38.2025.01.06.04.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 04:45:51 -0800 (PST) Date: Mon, 6 Jan 2025 14:45:48 +0200 From: Abel Vesa To: Dmitry Baryshkov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Karol Herbst , Lyude Paul , Danilo Krummrich , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Bjorn Andersson , Konrad Dybcio , Johan Hovold , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Imre Deak Subject: Re: [PATCH v3 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode Message-ID: References: <20250103-drm-dp-msm-add-lttpr-transparent-mode-set-v3-0-5c367f4b0763@linaro.org> <20250103-drm-dp-msm-add-lttpr-transparent-mode-set-v3-3-5c367f4b0763@linaro.org> <3p3wgzhtptjexplxrluod6sk36xeltpoh4hxg2yagssw7nh7hj@ikc4rssp6zej> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3p3wgzhtptjexplxrluod6sk36xeltpoh4hxg2yagssw7nh7hj@ikc4rssp6zej> On 25-01-03 20:09:42, Dmitry Baryshkov wrote: > On Fri, Jan 03, 2025 at 02:58:17PM +0200, Abel Vesa wrote: > > LTTPRs operating modes are defined by the DisplayPort standard and the > > generic framework now provides a helper to switch between them, which > > is handling the explicit disabling of non-transparent mode and its > > disable->enable sequence mentioned in the DP Standard v2.0 section > > 3.6.6.1. > > > > So use the new drm generic helper instead as it makes the code a bit > > cleaner. > > > > Acked-by: Imre Deak > > Signed-off-by: Abel Vesa > > --- > > .../gpu/drm/i915/display/intel_dp_link_training.c | 24 +++++----------------- > > 1 file changed, 5 insertions(+), 19 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > index 8b1977cfec503c70f07af716ee2c00e7605c6adf..c5bad311edf7b9a5cebb633b9e9692bae397f9ed 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > > @@ -119,9 +119,6 @@ intel_dp_set_lttpr_transparent_mode(struct intel_dp *intel_dp, bool enable) > > u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT : > > DP_PHY_REPEATER_MODE_NON_TRANSPARENT; > > > > - if (drm_dp_dpcd_write(&intel_dp->aux, DP_PHY_REPEATER_MODE, &val, 1) != 1) > > - return false; > > - > > intel_dp->lttpr_common_caps[DP_PHY_REPEATER_MODE - > > DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV] = val; > > > > @@ -146,6 +143,7 @@ static bool intel_dp_lttpr_transparent_mode_enabled(struct intel_dp *intel_dp) > > static int intel_dp_init_lttpr_phys(struct intel_dp *intel_dp, const u8 dpcd[DP_RECEIVER_CAP_SIZE]) > > { > > int lttpr_count; > > + int ret; > > > > if (!intel_dp_read_lttpr_common_caps(intel_dp, dpcd)) > > return 0; > > @@ -172,22 +170,8 @@ static int intel_dp_init_lttpr_phys(struct intel_dp *intel_dp, const u8 dpcd[DP_ > > return lttpr_count; > > } > > > > - /* > > - * See DP Standard v2.0 3.6.6.1. about the explicit disabling of > > - * non-transparent mode and the disable->enable non-transparent mode > > - * sequence. > > - */ > > - intel_dp_set_lttpr_transparent_mode(intel_dp, true); > > - > > - /* > > - * In case of unsupported number of LTTPRs or failing to switch to > > - * non-transparent mode fall-back to transparent link training mode, > > - * still taking into account any LTTPR common lane- rate/count limits. > > - */ > > - if (lttpr_count < 0) > > - goto out_reset_lttpr_count; > > - > > - if (!intel_dp_set_lttpr_transparent_mode(intel_dp, false)) { > > + ret = drm_dp_lttpr_init(&intel_dp->aux, lttpr_count); > > + if (ret) { > > lt_dbg(intel_dp, DP_PHY_DPRX, > > "Switching to LTTPR non-transparent LT mode failed, fall-back to transparent mode\n"); > > > > @@ -196,6 +180,8 @@ static int intel_dp_init_lttpr_phys(struct intel_dp *intel_dp, const u8 dpcd[DP_ > > goto out_reset_lttpr_count; > > } > > > > + intel_dp_set_lttpr_transparent_mode(intel_dp, false); > > + > > I think the code now misses a way to update intel_dp->lttpr_common_caps > in a transparent-mode case: > intel_dp_set_lttpr_transparent_mode(intel_dp, true). It is being called if the drm_dp_lttpr_init() returns a non-zero value, but that is not part of the diff here. > > > return lttpr_count; > > > > out_reset_lttpr_count: > > > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry